From patchwork Sat Feb 25 08:59:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656438 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1351466wrb; Sat, 25 Feb 2023 01:01:02 -0800 (PST) X-Google-Smtp-Source: AK7set/f1UERdGUmvjPIQlY198bgLMZjT10JPPNGNhJjRaj34EZ3YFOTI31ZJuE1tpZFPS6JVIUz X-Received: by 2002:a05:622a:1b9f:b0:3bb:7c6b:9cb6 with SMTP id bp31-20020a05622a1b9f00b003bb7c6b9cb6mr4225260qtb.17.1677315662762; Sat, 25 Feb 2023 01:01:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677315662; cv=none; d=google.com; s=arc-20160816; b=XAXuSNMp0JJe1qEiEV2zB+34JHSoegV9xeXbjWJoxcYIncXNbJFlvHVruARE+17Lgq O6cl1esrmfnPrDffr+1n5gdZPkkGCRcRlXMRGRoWgxO8pWjAp6trddYM70IZQOcIucyy /0JkzkY96cwh/SCq4w1SrhHrqFc+O6E/VOraGxFYD1kZUYr8bEoRECvHVJLlGULYcP9N XGeBzraiBA6yWEepAiE4V74jKfczzxyiH6xTXPKCfwL/GnPxWMX5VbpOURnGpFQ3X9iL 74BynJOBylY6/AFDjZQEerA8N63yhkm7grHvxpR0d8Jt48MtIV1lqNaV2WW3jHGV5tTc VCsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=SeFErTMIOzugEP/vf6yz38O9dJv9Z8ACda+9IdaOdYWFK+1jpAZrbbJhVTeqO+GLYR VhinMl8cHJ6yo1Ll+6GlrjPdW5jXRMbQBn59O8bu3c0ntLFyUp1QyZAHOGEXiPQ2xcLc 1/otrtzyx1wSkiIq4wOJa5/WoqQWX2mMJRwasv5svKv+or5sYtCjhZMf/xGVF6Kuol/I a7oDQHYvvYSz8CsckrCbfEElNviV9b04JqwNw4cE9k/XqK8oupLq5M60WOdBsK3XcDxn ChTaIwqfEo8sEpEORyLQnT1W08isI7xdtj91meNRj6tq1ZYtPOhDWggRbubq4whCfiAV EHiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7Rw93VA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 13-20020ac8590d000000b003b9bb33ef8dsi1449739qty.432.2023.02.25.01.01.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:01:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7Rw93VA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVqQC-0001LT-W1; Sat, 25 Feb 2023 04:00:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVqPt-0000uS-06 for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:29 -0500 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVqPp-000588-UO for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:27 -0500 Received: by mail-pj1-x1031.google.com with SMTP id h17-20020a17090aea9100b0023739b10792so1585815pjz.1 for ; Sat, 25 Feb 2023 01:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=E7Rw93VAOVIWRUpjrONfSt0T2aD5rYQxmIzZUiebo+hP5deqpSWs08gu3cu7ONirLX 19t/Z3kEy5FkAefICkM8OtpYDlQ3WuCszpfixInNchnFAvnAkyb1HaDLKLPK0lttP+Kk 19rvESQzXuK+mMr7t9cfYjimb09DVHUgCVIDeANI3MKjgoW1u/PoXl+cslNsq/o9yonI AiRByIvYEEhl36X39tWPjmnSM5TN14/8L4LOKAut8KhF9ZL+dYPwVMmRArfNjZnqTiB9 Jq/TU0WWdLAXFq0yJJ6yauiG4fEeH7N7AxWLcwTJ1GHpKF/8TOOXjkoHCuvm9LuchorI A9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=6C0vOEISy8ajVnNEyixb5cV2PoLZEa5x5IsNRrCw6x1YEMtpUJeMlmcEGRadFo5DkX 2ySWpnfDryjwipXHF1buSixRAx1QbXptpxWd91QOnBYpw/M4Q46XZoyM/aEBIXRgxRPL hmZDCsI64H/UYZKFjyxmSapWks834/GaspeesYOi1A0ZuScrFHiaDh4sgS+2DF2ZbxiN 40kAJWshev+ZtQi/fcvJh/fRDT3szmAaGohYSVytfSmbQd6LZ6spH+Ce4p3CZtQ1Md5Z eW006nfD03WoDyp0oxjbTGMQ6Sf97XgwrY2cYCEG0lvYlQpyd8OHqrUvLQmHGUc3cfJ2 by7w== X-Gm-Message-State: AO0yUKV3An6mAgf5XZorV1DKZU2G9S8IoZtHOTw91g3Yh4fMr/+wLmeU d/mhqqPk2HVXQ1KuPJW/NFmi+sWwA4n5XT2w4xc= X-Received: by 2002:a05:6a20:4404:b0:c7:6475:4882 with SMTP id ce4-20020a056a20440400b000c764754882mr2863310pzb.2.1677315624586; Sat, 25 Feb 2023 01:00:24 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s17-20020a639251000000b00502ecb91940sm715546pgn.55.2023.02.25.01.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 01:00:24 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 24/30] target/i386: Don't use tcg_temp_local_new Date: Fri, 24 Feb 2023 22:59:39 -1000 Message-Id: <20230225085945.1798188-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230225085945.1798188-1-richard.henderson@linaro.org> References: <20230225085945.1798188-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since tcg_temp_new is now identical, use that. In some cases we can avoid a copy from A0 or T0. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index a47d60f057..baf1cfc2bc 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -3426,13 +3426,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod == 3) { goto illegal_op; } - a0 = tcg_temp_local_new(); - t0 = tcg_temp_local_new(); + a0 = s->A0; + t0 = s->T0; label1 = gen_new_label(); - tcg_gen_mov_tl(a0, s->A0); - tcg_gen_mov_tl(t0, s->T0); - gen_set_label(label1); t1 = tcg_temp_new(); t2 = tcg_temp_new(); @@ -3444,9 +3441,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_brcond_tl(TCG_COND_NE, t0, t2, label1); tcg_temp_free(t2); - tcg_temp_free(a0); tcg_gen_neg_tl(s->T0, t0); - tcg_temp_free(t0); } else { tcg_gen_neg_tl(s->T0, s->T0); if (mod != 3) { @@ -6248,13 +6243,13 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) #endif { TCGLabel *label1; - TCGv t0, t1, t2, a0; + TCGv t0, t1, t2; if (!PE(s) || VM86(s)) goto illegal_op; - t0 = tcg_temp_local_new(); - t1 = tcg_temp_local_new(); - t2 = tcg_temp_local_new(); + t0 = tcg_temp_new(); + t1 = tcg_temp_new(); + t2 = tcg_temp_new(); ot = MO_16; modrm = x86_ldub_code(env, s); reg = (modrm >> 3) & 7; @@ -6263,11 +6258,8 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod != 3) { gen_lea_modrm(env, s, modrm); gen_op_ld_v(s, ot, t0, s->A0); - a0 = tcg_temp_local_new(); - tcg_gen_mov_tl(a0, s->A0); } else { gen_op_mov_v_reg(s, ot, t0, rm); - a0 = NULL; } gen_op_mov_v_reg(s, ot, t1, reg); tcg_gen_andi_tl(s->tmp0, t0, 3); @@ -6280,8 +6272,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_movi_tl(t2, CC_Z); gen_set_label(label1); if (mod != 3) { - gen_op_st_v(s, ot, t0, a0); - tcg_temp_free(a0); + gen_op_st_v(s, ot, t0, s->A0); } else { gen_op_mov_reg_v(s, ot, rm, t0); } @@ -6304,7 +6295,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) modrm = x86_ldub_code(env, s); reg = ((modrm >> 3) & 7) | REX_R(s); gen_ldst_modrm(env, s, modrm, MO_16, OR_TMP0, 0); - t0 = tcg_temp_local_new(); + t0 = tcg_temp_new(); gen_update_cc_op(s); if (b == 0x102) { gen_helper_lar(t0, cpu_env, s->T0); @@ -7052,7 +7043,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu) dc->tmp2_i32 = tcg_temp_new_i32(); dc->tmp3_i32 = tcg_temp_new_i32(); dc->tmp4 = tcg_temp_new(); - dc->cc_srcT = tcg_temp_local_new(); + dc->cc_srcT = tcg_temp_new(); } static void i386_tr_tb_start(DisasContextBase *db, CPUState *cpu)