From patchwork Sat Feb 25 08:59:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656444 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1352197wrb; Sat, 25 Feb 2023 01:02:56 -0800 (PST) X-Google-Smtp-Source: AK7set/BEzmeDd7f6qMwqtev57nKMixMTHRiZye9aRASxsxtgol/2igIyLedzc1rbvgctiw3uOxQ X-Received: by 2002:a05:622a:18aa:b0:3bf:b504:d5ea with SMTP id v42-20020a05622a18aa00b003bfb504d5eamr13414264qtc.48.1677315776667; Sat, 25 Feb 2023 01:02:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677315776; cv=none; d=google.com; s=arc-20160816; b=j/FwoArJ53Lsafb5a5HvVrj3pcyrhtepoc7REKjcWue4QtqWgfN8eOEvbOZpKEJgo4 NExBn6tDE8jbLlPUQG3p713cVBNBiQSSJ75iuVzi1CNuA53ANZVBw8I8MKCxt+M+zi3V k0p+dK5K2BCuJlY4bby23gYLmjlD8eEvItNKNqxlW7cpxeY//+LIoLiYb7w5Kniu12aI KqYcoB9gEYp+S9ShrWDyD9VYCsZDUIgMJQmS74NmL0lj8Vc5JhyY0dwEwgLLBe4+P6oF LluzdEL1ONYe5NAdFf3xo9BLr4ao1S8Of+u0dyco2W0AAnQcII/4QX3McDsH3KZCn3kX aXdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=L/CRGrAXoy0I0U2f47XrfnXHSDepPYdq71QllQBa+J0=; b=IiisBy+msI0R8HQRWjLvqhxVm+Ru5CciygiPJ+V96V/3DoaYdJwDAxmosRGNhoX6Ga 9h8VgysBcE8yl29Fnxi8yM4nJa3cPrQppSt+78H4edGDacQCQBqtLTGOqPGhsWRTzpqU /2GpchEU76twQsaRmqayKPw0Fetx1hw7+tSy/Qp+cgfpxlQZRPaIpJKzMkoN0FvCBAkQ wM/URZszkiX9g8sT3hXLmo9HchGSZB98NmeFoyPVU5cT4RY7RzOY03LoBuie9I30FQdC BpLfAI8cspsttfb6L9oeMrh2U3rRip/66EnWCADdHIugUz7bEoUPqg8VyNZfHzWoN5VF sC7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m3+siJuk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x8-20020a05620a448800b007335d88968esi1446389qkp.439.2023.02.25.01.02.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:02:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m3+siJuk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVqPX-0000Qc-KK; Sat, 25 Feb 2023 04:00:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVqPW-0000Pw-4H for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:06 -0500 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVqPU-0004re-8w for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:05 -0500 Received: by mail-pf1-x432.google.com with SMTP id n5so812926pfv.11 for ; Sat, 25 Feb 2023 01:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L/CRGrAXoy0I0U2f47XrfnXHSDepPYdq71QllQBa+J0=; b=m3+siJukSfr2ktfNyYQV0pVIqH4Zj02JJ7RUq2CIu7uVssMf4weQX2/G3uP2Y6fchV a7GdDDXYjiretVX6d6RewpuvdYeTRaYkTvPTxGCfNHJhqFHodU6ICM1il2tg486zA70T yP0uwJmxLr6zR1DsW3NsGBlGsRYZrhU7SdIoIMpwV9ikOLfeXWzzuZpNxaEIM7F6ua+M ZdhA1yLzRxDltksnURaFWLSMo8wvud8ltcIfZzpaSg5yaLcAD+lldn09A3Y1jeJ2prHC 0dy206re6Fr+Jg1wDnNi9NpaP7Xt5yD1AqcKscyKvL3vehzTTfvZPCWxtw9K368FJRfF vh1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L/CRGrAXoy0I0U2f47XrfnXHSDepPYdq71QllQBa+J0=; b=H3QjsrYPQt4dKKRGMga97fgpE3pCnU9z5bWGYluhxjzOHMLmUBFunq1sN9arFaNCgs RFCzlRxt5vFYxUiVL23n0ctp0wGo7hRKUMr3SeA6L1zjf1Ke5px3e+eMCAkyRijI2hxW eSwaOqlbXnSSKhUBFXuZ0XoSQJIuBNq++dAo8KK68AcCJn+liJjdsKasi99cFZcpHiLt AkMvcaxoP5APGydsodFTIygUq43SlAEeSD9M4VhJuRGjXpF1fejZKD4Ceg8fed21x8J8 I/MdaZx1iJLl9t+/JPYZs0ZjSrs3B5lh4XHSGRojgResa3iTHmCAIuiND1cH9Ooins4c 0akg== X-Gm-Message-State: AO0yUKXSzYvv6lzm0xsrO4bPtcrSGvWizagRpItMsKbfm/COlimgZYgJ dMmqKfBLwVLmd7AjNva1MzNh2qgtRw7KWsKh8gk= X-Received: by 2002:aa7:9715:0:b0:5dc:e03d:b95 with SMTP id a21-20020aa79715000000b005dce03d0b95mr8509280pfg.12.1677315602890; Sat, 25 Feb 2023 01:00:02 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s17-20020a639251000000b00502ecb91940sm715546pgn.55.2023.02.25.01.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 01:00:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 09/30] tcg: Pass TCGTempKind to tcg_temp_new_internal Date: Fri, 24 Feb 2023 22:59:24 -1000 Message-Id: <20230225085945.1798188-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230225085945.1798188-1-richard.henderson@linaro.org> References: <20230225085945.1798188-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While the argument can only be TEMP_EBB or TEMP_TB, it's more obvious this way. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 18 +++++++++--------- tcg/tcg.c | 8 ++++---- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 02d5cfc049..8d896bcbf4 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -855,7 +855,7 @@ void tcg_set_frame(TCGContext *s, TCGReg reg, intptr_t start, intptr_t size); TCGTemp *tcg_global_mem_new_internal(TCGType, TCGv_ptr, intptr_t, const char *); -TCGTemp *tcg_temp_new_internal(TCGType, bool); +TCGTemp *tcg_temp_new_internal(TCGType, TCGTempKind); void tcg_temp_free_internal(TCGTemp *); TCGv_vec tcg_temp_new_vec(TCGType type); TCGv_vec tcg_temp_new_vec_matching(TCGv_vec match); @@ -894,13 +894,13 @@ static inline TCGv_i32 tcg_global_mem_new_i32(TCGv_ptr reg, intptr_t offset, static inline TCGv_i32 tcg_temp_new_i32(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I32, false); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I32, TEMP_EBB); return temp_tcgv_i32(t); } static inline TCGv_i32 tcg_temp_local_new_i32(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I32, true); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I32, TEMP_TB); return temp_tcgv_i32(t); } @@ -913,25 +913,25 @@ static inline TCGv_i64 tcg_global_mem_new_i64(TCGv_ptr reg, intptr_t offset, static inline TCGv_i64 tcg_temp_new_i64(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I64, false); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I64, TEMP_EBB); return temp_tcgv_i64(t); } static inline TCGv_i64 tcg_temp_local_new_i64(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I64, true); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I64, TEMP_TB); return temp_tcgv_i64(t); } static inline TCGv_i128 tcg_temp_new_i128(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, false); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, TEMP_EBB); return temp_tcgv_i128(t); } static inline TCGv_i128 tcg_temp_local_new_i128(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, true); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, TEMP_TB); return temp_tcgv_i128(t); } @@ -944,13 +944,13 @@ static inline TCGv_ptr tcg_global_mem_new_ptr(TCGv_ptr reg, intptr_t offset, static inline TCGv_ptr tcg_temp_new_ptr(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_PTR, false); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_PTR, TEMP_EBB); return temp_tcgv_ptr(t); } static inline TCGv_ptr tcg_temp_local_new_ptr(void) { - TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_PTR, true); + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_PTR, TEMP_TB); return temp_tcgv_ptr(t); } diff --git a/tcg/tcg.c b/tcg/tcg.c index 7ffd4a4f28..e09ef46b85 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1255,10 +1255,10 @@ TCGTemp *tcg_global_mem_new_internal(TCGType type, TCGv_ptr base, return ts; } -TCGTemp *tcg_temp_new_internal(TCGType type, bool temp_local) +TCGTemp *tcg_temp_new_internal(TCGType type, TCGTempKind kind) { TCGContext *s = tcg_ctx; - TCGTempKind kind = temp_local ? TEMP_TB : TEMP_EBB; + bool temp_local = kind == TEMP_TB; TCGTemp *ts; int idx, k; @@ -1341,7 +1341,7 @@ TCGv_vec tcg_temp_new_vec(TCGType type) } #endif - t = tcg_temp_new_internal(type, 0); + t = tcg_temp_new_internal(type, TEMP_EBB); return temp_tcgv_vec(t); } @@ -1352,7 +1352,7 @@ TCGv_vec tcg_temp_new_vec_matching(TCGv_vec match) tcg_debug_assert(t->temp_allocated != 0); - t = tcg_temp_new_internal(t->base_type, 0); + t = tcg_temp_new_internal(t->base_type, TEMP_EBB); return temp_tcgv_vec(t); }