| Message ID | 20230221094558.2864616-9-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next: docker, avocado, unit, gitlab | expand |
On 21/02/2023 10.45, Alex Bennée wrote: > All we are really doing here is checking that TSAN builds compile and are > therefor a tool available to developers. The benchmarks are not > representative of QEMU's actual threading behaviour and they burn > precious CI time. Indeed switching to check-unit reveals many > unaddressed issues which have been logged at: > > https://gitlab.com/qemu-project/qemu/-/issues/1496 > > So for now disable the make check and make this a build only > test. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index 8f332fc36f..e9a67e0191 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -465,7 +465,6 @@ tsan-build: > CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 > --enable-trace-backends=ust --enable-fdt=system --disable-slirp > TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user > - MAKE_CHECK_ARGS: bench V=1 > > # gcov is a GCC features > gcov: Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 8f332fc36f..e9a67e0191 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -465,7 +465,6 @@ tsan-build: CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 --enable-trace-backends=ust --enable-fdt=system --disable-slirp TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user - MAKE_CHECK_ARGS: bench V=1 # gcov is a GCC features gcov:
All we are really doing here is checking that TSAN builds compile and are therefor a tool available to developers. The benchmarks are not representative of QEMU's actual threading behaviour and they burn precious CI time. Indeed switching to check-unit reveals many unaddressed issues which have been logged at: https://gitlab.com/qemu-project/qemu/-/issues/1496 So for now disable the make check and make this a build only test. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .gitlab-ci.d/buildtest.yml | 1 - 1 file changed, 1 deletion(-)