| Message ID | 20230216134911.6803-5-pierrick.bouvier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Adds support for running QEMU natively on windows-arm64 | expand |
On 2/16/23 03:49, Pierrick Bouvier wrote: > When compiling for windows-arm64 using clang-15, it reports a sometimes > uninitialized variable. This seems to be a false positive, as a default > case guards switch expressions, preventing to return an uninitialized > value, but clang seems unhappy with assert(0) definition. > > Change code to g_assert_not_reached() fix the warning. > > Signed-off-by: Pierrick Bouvier<pierrick.bouvier@linaro.org> > --- > target/ppc/dfp_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 16/2/23 14:49, Pierrick Bouvier wrote: > When compiling for windows-arm64 using clang-15, it reports a sometimes > uninitialized variable. This seems to be a false positive, as a default > case guards switch expressions, preventing to return an uninitialized > value, but clang seems unhappy with assert(0) definition. > > Change code to g_assert_not_reached() fix the warning. > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > target/ppc/dfp_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c > index cc024316d5..0a40bcfee3 100644 > --- a/target/ppc/dfp_helper.c > +++ b/target/ppc/dfp_helper.c > @@ -121,7 +121,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, uint8_t rmc, > case 3: /* use FPSCR rounding mode */ > return; > default: > - assert(0); /* cannot get here */ > + g_assert_not_reached(); /* cannot get here */ If you respin to update the comments to match QEMU style (also the // in configure), please remove this pointless comment here.
On 2/17/23 18:23, Philippe Mathieu-Daudé wrote: > On 16/2/23 14:49, Pierrick Bouvier wrote: >> When compiling for windows-arm64 using clang-15, it reports a sometimes >> uninitialized variable. This seems to be a false positive, as a default >> case guards switch expressions, preventing to return an uninitialized >> value, but clang seems unhappy with assert(0) definition. >> >> Change code to g_assert_not_reached() fix the warning. >> >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> target/ppc/dfp_helper.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c >> index cc024316d5..0a40bcfee3 100644 >> --- a/target/ppc/dfp_helper.c >> +++ b/target/ppc/dfp_helper.c >> @@ -121,7 +121,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, uint8_t rmc, >> case 3: /* use FPSCR rounding mode */ >> return; >> default: >> - assert(0); /* cannot get here */ >> + g_assert_not_reached(); /* cannot get here */ > > If you respin to update the comments to match QEMU style (also > the // in configure), please remove this pointless comment here. Sure, will do.
diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index cc024316d5..0a40bcfee3 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -121,7 +121,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, uint8_t rmc, case 3: /* use FPSCR rounding mode */ return; default: - assert(0); /* cannot get here */ + g_assert_not_reached(); /* cannot get here */ } } else { /* r == 1 */ switch (rmc & 3) { @@ -138,7 +138,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r, uint8_t rmc, rnd = DEC_ROUND_HALF_DOWN; break; default: - assert(0); /* cannot get here */ + g_assert_not_reached(); /* cannot get here */ } } decContextSetRounding(&dfp->context, rnd);
When compiling for windows-arm64 using clang-15, it reports a sometimes uninitialized variable. This seems to be a false positive, as a default case guards switch expressions, preventing to return an uninitialized value, but clang seems unhappy with assert(0) definition. Change code to g_assert_not_reached() fix the warning. Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- target/ppc/dfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)