diff mbox series

[v1,08/19] target/arm: Add atom_data to DisasContext

Message ID 20230216030854.1212208-9-richard.henderson@linaro.org
State New
Headers show
Series target/arm: Implement FEAT_LSE2 | expand

Commit Message

Richard Henderson Feb. 16, 2023, 3:08 a.m. UTC 
Use this to record the default atomicity of memory operations.
Set it to MO_ATOM_WITHIN16 if FEAT_LSE2 applies.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/translate.h     | 14 +++++++++++---
 target/arm/translate-a64.c |  4 ++++
 target/arm/translate.c     |  1 +
 3 files changed, 16 insertions(+), 3 deletions(-)

Comments

Peter Maydell Feb. 23, 2023, 3:47 p.m. UTC | #1 
On Thu, 16 Feb 2023 at 03:11, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use this to record the default atomicity of memory operations.
> Set it to MO_ATOM_WITHIN16 if FEAT_LSE2 applies.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/translate.h     | 14 +++++++++++---
>  target/arm/translate-a64.c |  4 ++++
>  target/arm/translate.c     |  1 +
>  3 files changed, 16 insertions(+), 3 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
diff mbox series

Patch

diff --git a/target/arm/translate.h b/target/arm/translate.h
index 3717824b75..809479f9b7 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -54,6 +54,7 @@  typedef struct DisasContext {
     bool eci_handled;
     int sctlr_b;
     MemOp be_data;
+    MemOp atom_data;
 #if !defined(CONFIG_USER_ONLY)
     int user;
 #endif
@@ -556,10 +557,10 @@  static inline TCGv_ptr fpstatus_ptr(ARMFPStatusFlavour flavour)
 /**
  * finalize_memop:
  * @s: DisasContext
- * @opc: size+sign+align of the memory operation
+ * @opc: size+sign+align+atomicity of the memory operation
  *
- * Build the complete MemOp for a memory operation, including alignment
- * and endianness.
+ * Build the complete MemOp for a memory operation, including alignment,
+ * endianness, and atomicity.
  *
  * If (op & MO_AMASK) then the operation already contains the required
  * alignment, e.g. for AccType_ATOMIC.  Otherwise, this an optionally
@@ -568,12 +569,19 @@  static inline TCGv_ptr fpstatus_ptr(ARMFPStatusFlavour flavour)
  * In the latter case, there are configuration bits that require alignment,
  * and this is applied here.  Note that there is no way to indicate that
  * no alignment should ever be enforced; this must be handled manually.
+ *
+ * If (op & MO_ATOM_MASK) or (op & MO_ATMAX_MASK) then the operation already
+ * contains the required atomicity, e.g. for AccType_VEC.  Otherwise, apply
+ * atomicity for AccType_NORMAL.
  */
 static inline MemOp finalize_memop(DisasContext *s, MemOp opc)
 {
     if (s->align_mem && !(opc & MO_AMASK)) {
         opc |= MO_ALIGN;
     }
+    if (!(opc & (MO_ATOM_MASK | MO_ATMAX_MASK))) {
+        opc |= s->atom_data;
+    }
     return opc | s->be_data;
 }
 
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index cd86597172..fa793485c3 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -14762,6 +14762,10 @@  static void aarch64_tr_init_disas_context(DisasContextBase *dcbase,
     tcg_debug_assert(dc->tbid & 1);
 #endif
 
+    /* Record the atomicity of a single AccType_NORMAL memory access. */
+    dc->atom_data = (dc_isar_feature(aa64_lse2, dc)
+                     ? MO_ATOM_WITHIN16 : MO_ATOM_IFALIGN);
+
     /* Single step state. The code-generation logic here is:
      *  SS_ACTIVE == 0:
      *   generate code with no special handling for single-stepping (except
diff --git a/target/arm/translate.c b/target/arm/translate.c
index c23a3462bf..552c376050 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -9449,6 +9449,7 @@  static void arm_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
         dc->sme_trap_nonstreaming =
             EX_TBFLAG_A32(tb_flags, SME_TRAP_NONSTREAMING);
     }
+    dc->atom_data = MO_ATOM_IFALIGN;
     dc->cp_regs = cpu->cp_regs;
     dc->features = env->features;