From patchwork Fri Dec 30 00:02:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 637832 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3180454pvb; Thu, 29 Dec 2022 16:12:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXsdbzTt7QwjjLxMzFJ1j+3oYSUse+jcXe8ZvBnJI4LsMSDQh3SsKoSHtmWz1TenzcLTvTpL X-Received: by 2002:a05:622a:4188:b0:3a7:e4ae:7937 with SMTP id cd8-20020a05622a418800b003a7e4ae7937mr42564469qtb.6.1672359131195; Thu, 29 Dec 2022 16:12:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672359131; cv=none; d=google.com; s=arc-20160816; b=eePXXuocMZX0vZYvUC4ic6ROMZNTitLQNXlMfP2xzCep4Kmbaz/VuhCoSrMKDzH+Hb geH0/s4X/upYEA54sxkyD27cBD3f37be4oJPmyQ3f1woYVu7jr9G8oCAmF21QKZRSwwH AWdz2DMGV/uFca4FJBGUOs1c7fqRWmiJ8B/3Y10//tVQfiVJIG/wpaVFpBb5CBK+KI/y 5jHs2h4NdGEz2Ndh7D9WxVvLJvgaXaIez4PZx9GIwzC3XeXzaJN+gQKE1jOYS3yA3ahA lIg9hPNbiOXUffKyay5cnuVPn/vuqhOh8/gVszGNFdZqO2MsY4tEOZc9czT5kL1SJRah aHkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WRnYCcPWX5BOQQf1a59sccPy8bi18QDF38eChoryi3g=; b=KR4xPhqxkrLA6ZUBOEZTAz/SBfRiLTyL+86h3MFe7DQgRtzDTvn6cwuY7vVl+YE6yS MUhorTYQKagPwk32ciPEQVHaDn2/M/Kn9m4QFw1GBdtXxlSmnSF3g2PUTIGhTCk+Nu5Y 6gYPo7RglvyaMMR9js026hOgfv81a2WOH/jgpmDAZVPL1adm0GG/S4SnKc1QNf2h6Mgk eWZjdpMnj2fXdgsbCDcGvPrOr5uFwLSfLCYJ59aeFS/24pw1CVLQBLfw08EwXtlZWwM+ 3rjQIxUf79TtTvTD1N0S3oAcoXRrNi2h4O0zXg/ZJePFvEToLSNxisfopYRqTIxJ/d1P UA8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fddGhnri; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j6-20020a05620a288600b00704acb14835si9482839qkp.631.2022.12.29.16.12.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Dec 2022 16:12:11 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fddGhnri; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pB2sL-0003o0-AY; Thu, 29 Dec 2022 19:03:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB2rX-00039H-04 for qemu-devel@nongnu.org; Thu, 29 Dec 2022 19:03:05 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pB2rQ-0002f8-7P for qemu-devel@nongnu.org; Thu, 29 Dec 2022 19:03:00 -0500 Received: by mail-pj1-x102f.google.com with SMTP id v13-20020a17090a6b0d00b00219c3be9830so20260341pjj.4 for ; Thu, 29 Dec 2022 16:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WRnYCcPWX5BOQQf1a59sccPy8bi18QDF38eChoryi3g=; b=fddGhnrit6uLD0IY1PsgSgxr2j+Irtqe/mcmGcCeeIGqaST4bcThiIEJvcyFkY9lRf k81MFDIAaeLt+L68nJc3hoCNIe0X1u5j4Ut0qDaYbkJJAVTC4fqG42XBH204zR7wqSDL HpyTARBORX4tzCTzBQeohE5U/2nZHbt8s1PEy6q8oOSLUgXSzmmLrxE2Fe7H7OXl37fF VJg53oKfwyKVGc7RA0xnEPDHP8QrlQlP5agQBLpAoDdH9U6cajxcOnaw3zMevR4yq01P qcgmdvxIey2JBXSXAVcJKGDfhfX2vd4phOCMS+3g0HsquO95x9K3WdIgVpISf7JEp5lp WZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WRnYCcPWX5BOQQf1a59sccPy8bi18QDF38eChoryi3g=; b=62saUgMYNbVZYMWaTeRlN9jSdOxGpF8CrRPuaGFj2x8EzdYQ3ADpxsNbQpNMH7YJu8 0SswmhN80p9sBXRwzlISBvcVmNOf4Oz2/wZ0Ilbpeegfzwyr6ALAvPz/zYIvjM3uYOGJ rbCyIcIl2RD6wwo3qZCjf0qJzX+KxihQCnwpOz5kCWjoKNAlKAIdfo4nrQpci4ndeKG6 KgfXRnxKHtTR3JGbVrSFNcWaFIVTPBMhlPJjZfRzVY8oKJB6/+KkemSwH25PTqN0v5v+ CVI1pUJSwMtRw1QDU+B1IE8wrFjuWTai2oTGiFIMB1m2qBlCqN+NqRJWovEYv44rzdFK BfLA== X-Gm-Message-State: AFqh2kq38neU3J6Aaju18HCky60kRjEYX0sYmJ41uW+d2NS/0hIhkPJ1 2kNsgXpDdFlcl05vkvexAr/F55Mr8vS0dwAS X-Received: by 2002:a17:902:ec89:b0:186:b063:32e with SMTP id x9-20020a170902ec8900b00186b063032emr45957411plg.62.1672358573167; Thu, 29 Dec 2022 16:02:53 -0800 (PST) Received: from stoup.. (76-14-210-194.or.wavecable.com. [76.14.210.194]) by smtp.gmail.com with ESMTPSA id j14-20020a170903028e00b00192849e1d0asm7343953plr.116.2022.12.29.16.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 16:02:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philipp?= =?utf-8?q?e_Mathieu-Daud=C3=A9?= Subject: [PULL 33/47] accel/tcg/plugin: Avoid duplicate copy in copy_call Date: Thu, 29 Dec 2022 16:02:07 -0800 Message-Id: <20221230000221.2764875-34-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221230000221.2764875-1-richard.henderson@linaro.org> References: <20221230000221.2764875-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We copied all of the arguments in copy_op_nocheck. We only need to replace the one argument that we change. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/plugin-gen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 9e359c006a..77e6823d6b 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -397,9 +397,7 @@ static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *empty_func, func_idx = TCGOP_CALLO(op) + TCGOP_CALLI(op); *cb_idx = func_idx; - op->args[func_idx] = (uintptr_t)func; - op->args[func_idx + 1] = old_op->args[func_idx + 1]; return op; }