diff mbox series

[01/10] target/hppa/helper: Include missing "cpu.h" header

Message ID 20221216220539.7065-2-philmd@linaro.org
State New
Headers show
Series target/misc: Header cleanups around "cpu.h" | expand

Commit Message

Philippe Mathieu-Daudé Dec. 16, 2022, 10:05 p.m. UTC 
'dh_ctype_tr' is defined as 'target_ureg', itself declared in "cpu.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/helper.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Henderson Dec. 17, 2022, 12:30 a.m. UTC | #1 
On 12/16/22 14:05, Philippe Mathieu-Daudé wrote:
> 'dh_ctype_tr' is defined as 'target_ureg', itself declared in "cpu.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hppa/helper.h | 2 ++
>   1 file changed, 2 insertions(+)

No, helper.h is multiply included.
It should probably be renamed across all target/*/.


r~
diff mbox series

Patch

diff --git a/target/hppa/helper.h b/target/hppa/helper.h
index c7e35ce8c7..621bc9738e 100644
--- a/target/hppa/helper.h
+++ b/target/hppa/helper.h
@@ -1,3 +1,5 @@ 
+#include "cpu.h"
+
 #if TARGET_REGISTER_BITS == 64
 # define dh_alias_tr     i64
 # define dh_typecode_tr  dh_typecode_i64