From patchwork Tue Dec 13 21:25:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 633518 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3342348pvb; Tue, 13 Dec 2022 13:26:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf7YdeXHgrykiULBRkcOm0GNK051lbHwcoDFW34iozhI7cAFwChKrx9UW3TRg45Y28LCP+Qo X-Received: by 2002:a05:622a:248c:b0:39c:da20:f700 with SMTP id cn12-20020a05622a248c00b0039cda20f700mr29820952qtb.36.1670966795501; Tue, 13 Dec 2022 13:26:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670966795; cv=none; d=google.com; s=arc-20160816; b=BiT8OSCA/LqpCHXCGIseJk4aREdRM9hpOM2qMuBCUF6opF7k9vTKx0yi6hed9q4VaA Uhu2cgQrAAf8LuZg7teVavZbpU/MngLU6L8CFdGq5k6yu9Tzyh59UISQ42bCKK7bDuqj Ttkt7CirB7akhqPz4eRhBC5BojD1mJVXTBNxuZ5QdMmBaXu9Kuq/wWBZO7C7xRL0Y1FA mAiFY1BxS6+gzRgQNqFvlCqjBasJhdzGzWNy8UwocraR5PD+pIvFsTx9EYKgbof0Cpz8 3dXP/2XHkJsmo8NX+muuXvfthq6rg9AntXqSVLVQTTFtA5q7n2cbkJ0o/6qYnPMpKMfS oaCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1fcBWbZUmm5Jnpz4Izudl/A6K0HNswQpl9r23JhxDb4=; b=RZ9TPEdB/0a2m0MrwKg5D9BpxXea0wNHIYhAIs2hcLTnFagTtKlF3BZUeAUcaateyN vymuO4wy+xBCuYGJwITTfTgpI/Y1kuGRf2ZYT7o95a7zwmUMdOSuT8pC6uJrrscDqz8q lk1qC3u/E1ZIx55k4+nHLCoSjoeysRsl3Y7ZaadnTNzvCDpx4YtEimi547oC6zojFc2h dS2p+9TFggrUJcFgdptvU4QxPOQWvMBd/htrh1Fsqpl1YBBNUooDZkKKef4BZj3K/5Lo ZcmPQAK8yGXnt0jBbI95eCVfqVT+YCcS20aX3ZMmtquXmOOkLR8Lp+td9bfD6EN1Ldjv 9OFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="h/hzm/2F"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v17-20020ac873d1000000b0039cdd679585si657773qtp.40.2022.12.13.13.26.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Dec 2022 13:26:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="h/hzm/2F"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Cme-0000as-KK; Tue, 13 Dec 2022 16:25:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Cmd-0000aM-5i for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:25:51 -0500 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Cmb-0003Cd-Il for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:25:50 -0500 Received: by mail-oi1-x22d.google.com with SMTP id q186so1022121oia.9 for ; Tue, 13 Dec 2022 13:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1fcBWbZUmm5Jnpz4Izudl/A6K0HNswQpl9r23JhxDb4=; b=h/hzm/2FHR1E88XejO8s29lpgq/7aDGg3/Qn4G/blVonnpyeqNPO6Ay9cz2tEP5rkW s5RX6KfDAAZnMoOGfK877pxGROA4qgWlrtt0dRLECySMjKBob4gv9Gw2/8FFCR/h/vgf AQcWTBUiz12fRNU0GPvHFdRkwazEXRoX55TKiqGhM65eVxWWrm2izhsMcqXhlTB9x/MR 7CfRqoxeJDmO0gdsEodm0liPvZSWRjcW2/VnqYRx/NYlfaXQ6W1zZb95+CiMMRQJ/CeF KgZpZFg9vkq2qSbACf/Chf4itF9Wsp6h4vOF++H+Sh92O/UnGCCSyI+3nQRKK2Qj/6nQ kZLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1fcBWbZUmm5Jnpz4Izudl/A6K0HNswQpl9r23JhxDb4=; b=HWbVJigd8Xy6R0JbbNQzi2RA3L/vspS5oSlykrc6fTJwUF/Su8LwBLYXGaX91xEaMG IgOCZpAH62N4kNnPp/iIjRwGiKT1MNRYK8wy8apGchaGk1SW1NaQyYxx3FhncoHvTLJV 3PVccMIDamuafZkfVdzVPuHvUks/6rF0hfrVOMRAVVG7jrzFIIAoOycnf7nhJjDQtE8M JHhxhwP9bq2sI2vZEv6obHAn5WbHzekjmxeAS0mDzhCYPEod6HtZrU2+fsB4wV+bls8s vZvjZCTpKNP2HBkkN8h8vT+MAaVDFP8/Z2hmy1TKOYc/ER7AqGxF+6nx+COJh4Rx8Udj +oRA== X-Gm-Message-State: ANoB5pnsSiEroqqSbiYmAigc69DcufnpUg2UNKWlfuSE1AoufX21pfBU FM0gDT3YDEOQ9IDag+lmu73BHMX3kPzE3XRJN9s= X-Received: by 2002:a05:6808:23d6:b0:35b:eddd:653c with SMTP id bq22-20020a05680823d600b0035beddd653cmr13015445oib.40.1670966748410; Tue, 13 Dec 2022 13:25:48 -0800 (PST) Received: from stoup.. ([2806:102e:18:2efc:c63:85ed:4256:8ad0]) by smtp.gmail.com with ESMTPSA id a7-20020a056808098700b0035c073aa0d8sm5006831oic.18.2022.12.13.13.25.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:25:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 05/27] accel/tcg: Set cflags_next_tb in cpu_common_initfn Date: Tue, 13 Dec 2022 15:25:19 -0600 Message-Id: <20221213212541.1820840-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221213212541.1820840-1-richard.henderson@linaro.org> References: <20221213212541.1820840-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While we initialize this value in cpu_common_reset, that isn't called during startup, so set it as well in init. This fixes -singlestep versus the very first TB. Fixes: 04f5b647ed07 ("accel/tcg: Handle -singlestep in curr_cflags") Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- hw/core/cpu-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index f9fdd46b9d..6a4022eb14 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -235,6 +235,7 @@ static void cpu_common_initfn(Object *obj) /* the default value is changed by qemu_init_vcpu() for softmmu */ cpu->nr_cores = 1; cpu->nr_threads = 1; + cpu->cflags_next_tb = -1; qemu_mutex_init(&cpu->work_mutex); QSIMPLEQ_INIT(&cpu->work_list);