From patchwork Tue Dec 13 21:25:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 633523 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3342539pvb; Tue, 13 Dec 2022 13:27:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf6dZ8c+CJ1CQLZJ7kmftdXEKxw6jUKgiKPrdxvnWwE+cFWch3ECvP2O4xlLfjQsHlaa6idM X-Received: by 2002:a05:622a:1f88:b0:3a6:8aa6:98a3 with SMTP id cb8-20020a05622a1f8800b003a68aa698a3mr28754905qtb.39.1670966826312; Tue, 13 Dec 2022 13:27:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670966826; cv=none; d=google.com; s=arc-20160816; b=P/8ZRjg95k4DE2U68FaiIsL0DTJtsK7WRQfSLWNaNP8HHxjK9yfNfrlGPC9F6ZFRmc IRt1wNgExaD3L30ykVBBIqYXcj8ijDRn3fLDgUtO41JEu/XMcDQgnT5535T2iXZdfw/r AfG0JXaCSJiIPUEyLpvgWFOUElq/OJLeghIFsezCbY/1KE7acqEIg7pGg4XNpOIlHF/7 +DphOT9yWiJJAiyju+pkvnepGXw0sQRKyY+KOuYz1cgEaddit+lSpUrm/bprVOQa1vhs HZVjqUZIvgLHNbFRHKjpDQmTplNBfGuPbm1l+ZcX/ewkMmHX1ooGSryN5ZY7buFehEgh fV4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0EHWQ74OByxZK6+6bk+BFaesKcqluoqr4XzyR1zvNEg=; b=XTT4RZ20eZOCvh4HCDjJGLKdEoo9lxKxkegJafM87MJ7C1Ut6ktlynaTWDF1pfxrht IGznjkMTWfQvj5rqWQ+7JKXTcyoBi+xNxYjx5vP4H50H3Y7XTvPpEH0HAR9Szx+fHyyE 9spcuoZmxweSMjfj/mNes1AVP7v6xFPes36Nj1BFPuRnvOt+gnlN2Dm0i3JRbFjwlc4O 1kO37c2VmK2MG7eOmgC0vYfnl6bC7dWpJIa6DL53RtOAQM5tzVPnGn6UtB/eSXNI93ht 1Kuf+OeflcGZup7LbqBkl35AjZ7qKhil0rORySh6hAxcv05NaA34mBOMHzokkqs37qvs Zudw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gk1fOzRC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x8-20020ac84a08000000b00343582e11c7si594403qtq.603.2022.12.13.13.27.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Dec 2022 13:27:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gk1fOzRC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Cmx-0000hq-LC; Tue, 13 Dec 2022 16:26:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Cmu-0000g2-2q for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:26:08 -0500 Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Cmo-0003Dw-TU for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:26:06 -0500 Received: by mail-oi1-x22f.google.com with SMTP id v70so1049807oie.3 for ; Tue, 13 Dec 2022 13:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0EHWQ74OByxZK6+6bk+BFaesKcqluoqr4XzyR1zvNEg=; b=Gk1fOzRC3WJm44NRNJYyGD0xGEfKt24xNB9nCingYr746yCIS/yryamoOABxGsByqB 55zJlE5OVlaIQYvMBv0+skk25hbwmeeIlO14ntojHrzOd1r3gYOhphn4b6jmqonaoBl7 xhv62L8Q/JRfbOuIJoao4XV+iT4/2RQ2tpjiNIDl08DpVeU6X8esuLEQOvUAq0leXNA5 9xHdP98szmYCo9dhxYgXv3R1BYsb/C2t3pTvN3x3rL7Gwp+x+0/dBYiUaASPy7VfUQjU MFNcAtBEY07t6sSKtUh7wfJtGuZoTMY4tzZ2ENpQsmbGVFZvfgnxsolzhVAXx9jOY9Ze zyvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0EHWQ74OByxZK6+6bk+BFaesKcqluoqr4XzyR1zvNEg=; b=JQ6mbLcHYoxU4y7Uzxiibs+MO7nfBSNyaUMyFEt/E1ta7FjNAieyBRTeapLfHuf1+f Iitahfs7Gdm6wALBPW3FhAY9MCWIz6RQ6ANqnOFpcUg45qyQ/NSMfsfApcHuUJnoeJF3 qe1NIhjlxOXAk4fnyD3McBlkgOUtleIxDLh2DyKui7Bt32NTgtkNYs0zLeZItR9TI5HX IM5Td7V/MsmFSOCHDDz5bOH3fVUX8aK+88B7ESMtStMFRWdv1AOozG0Oh4cVwGWb9gHw 950jTqfFP7fyzGL78pb45Qx9hOcWqi7aFB2J2Xh/K4Z2asdcp67ke8w+T4L1yLz6IQ2H s92w== X-Gm-Message-State: ANoB5pm6StUt9NhFobZE1zvCZjSkfw7zotq99cakAefwxH3VYNrCb5jH bFkWwUArd5bqlnXSU1UxPmIMjr0wKJYnt00Eqbk= X-Received: by 2002:a54:4596:0:b0:35e:1be8:2354 with SMTP id z22-20020a544596000000b0035e1be82354mr9309906oib.48.1670966762238; Tue, 13 Dec 2022 13:26:02 -0800 (PST) Received: from stoup.. ([2806:102e:18:2efc:c63:85ed:4256:8ad0]) by smtp.gmail.com with ESMTPSA id a7-20020a056808098700b0035c073aa0d8sm5006831oic.18.2022.12.13.13.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:26:01 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?A?= =?utf-8?q?lex_Benn=C3=A9e?= Subject: [PATCH v4 18/27] accel/tcg/plugin: Avoid duplicate copy in copy_call Date: Tue, 13 Dec 2022 15:25:32 -0600 Message-Id: <20221213212541.1820840-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221213212541.1820840-1-richard.henderson@linaro.org> References: <20221213212541.1820840-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::22f; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We copied all of the arguments in copy_op_nocheck. We only need to replace the one argument that we change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Acked-by: Alex Bennée --- Cc: Alex Bennée --- accel/tcg/plugin-gen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 9e359c006a..77e6823d6b 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -397,9 +397,7 @@ static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *empty_func, func_idx = TCGOP_CALLO(op) + TCGOP_CALLI(op); *cb_idx = func_idx; - op->args[func_idx] = (uintptr_t)func; - op->args[func_idx + 1] = old_op->args[func_idx + 1]; return op; }