From patchwork Tue Dec 13 21:25:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 633519 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3342396pvb; Tue, 13 Dec 2022 13:26:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf6YVlnuWgouZwmIANTRliiBRli3ZFK962d6uI67LLAdJKiDQ/wx6fRNNv6x5NZ9TJfS/T5z X-Received: by 2002:a05:6214:1853:b0:4c7:595c:9940 with SMTP id d19-20020a056214185300b004c7595c9940mr26240279qvy.51.1670966802177; Tue, 13 Dec 2022 13:26:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670966802; cv=none; d=google.com; s=arc-20160816; b=f+Pmc6yXRUNzscwBoNcN43DXHJNwZKKZ5bwppmKxcw+KQ4RBBMh/uc/3tjY9xMh1AI C98m0lDWvhTgIbUpxv+UbpV+nvliSetZvWzCxtPOs8XHwHBKRbn2y1QL86Fu83GZcKxX E1+0VNyN9GBq+uZEvl0X535nHVN1i3sSF4NXrKu5naIGKPZIIaq7gJo4zrSeAFcFEJFm pnlLbEQ6smdWskw8a3kZ93jqymmZ5Oc5MIT8xpy34yCfWUuPREIIaGc7q0CE/wc/yK7f XhaD9sylyrVyC4Pn2hb9X9bCGCLMMAQii+jYprVSEMLsuy/T8OYHjcMkirJ1OL23DGq/ VOCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=AADJsK1S30bnJazg8/q+dVkIQuSQjRIPsLPoQjmDJDw=; b=H5P65K/yQlt/RpiQyfcBtbGsOu5p9mQ9Tem4zvfnUAau8jnCzdjGaCPCvklENfNZb+ 0nBpp4a/59W0cO0QcayBNaDrqw+zi3til2stR14LzF+MsZ1DbNlwApPj6g/P3QoWcFC1 QN2zkrzURZuzXxpz4J/rP2A2Ri016X5u1touB3M7iLyIY57RNPMIYVavx4DTguEhzt7k uFHNgRT7eCDkQ05iA5u+Vriq9WEEUw5gDsQxMtXgR+6B+qJx2iD4M2xms9wEx2QG9JHa z5f2t49emQ07Aop4WWhcExYkJYOyqnO2omEcnMZytuDSNYYJOdnWEDnyzRxelkr+eZjj Ofkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iitDdmIf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id kj28-20020a056214529c00b004c6eb67ef5asi8133765qvb.348.2022.12.13.13.26.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Dec 2022 13:26:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iitDdmIf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Cmj-0000cq-DI; Tue, 13 Dec 2022 16:25:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Cmh-0000cC-D9 for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:25:55 -0500 Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Cmf-0003Dw-S0 for qemu-devel@nongnu.org; Tue, 13 Dec 2022 16:25:55 -0500 Received: by mail-oi1-x22f.google.com with SMTP id v70so1049422oie.3 for ; Tue, 13 Dec 2022 13:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=AADJsK1S30bnJazg8/q+dVkIQuSQjRIPsLPoQjmDJDw=; b=iitDdmIfdl6DKWI5km3kvb8jeGi8uGmBr/j0jyHHPXH8dtDj0TZ4iqz2WrcMf6R7my VQx6ei64MTRif+2nb0+xFhFr5bfFICudb4xdKi89D7GcJmlVywzm+gchIGZePyRuD+HS 512u/7f0iAAkwxuwdY54VNKrCsH3i57ZKDZ35VtW+mChxBbgyvCZJ009M72yD0k7SPRw QBBlPILVOuaYbmPXJGpym383JYTsUcbjwqwJlpxN7Lu2beoWsRPNXBLC1cxUr9GoIHH9 BpxZSdteDg+oRxkmK+lC8lMisRoJ+lNKMYDZFc55rpn2C5uCbokg5qCBUcTz6+6uZvTo XcjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AADJsK1S30bnJazg8/q+dVkIQuSQjRIPsLPoQjmDJDw=; b=hh06pQiW7SCC4vCbF2DHUWLTt8cSTKS5LAw4J+Pa/BnLW6LnEoTtuvw18T8dWQ3S/v 1dieMNyhquLr9oIuB4zfLj6muHlfYPUbvv733+lFtDCZum3v6TSpD9KHzDI91MpLNTHr 1ldmKAiQHTQMDsrAbNQtuOz41PA+obbd60KSOLEuqjUW+uEJ1775GEsShUmkFmhjdqLm HJT9PEhOvLH6f/K6q8sZGfqk2cbb/9EOwn29mGZHQZwlpzLzXp9+8Td33+PSN8wFsekh sr8OGg0uvijK0etawdzEHMkQQ3TvvNF+el0s1brHlL5g4QEL09EA+CV6Yc/HSKnBa+D9 4A6Q== X-Gm-Message-State: ANoB5pn6i+MchjUmmF8up1qFcfk4dWi2zRabDK3n7nvNfABpHRiqQ9g5 08sPt5A43illV9DEKuTQYsSe1PTS94lI3Ve2ZwU= X-Received: by 2002:a05:6808:64a:b0:35e:34b9:f793 with SMTP id z10-20020a056808064a00b0035e34b9f793mr9295179oih.20.1670966752538; Tue, 13 Dec 2022 13:25:52 -0800 (PST) Received: from stoup.. ([2806:102e:18:2efc:c63:85ed:4256:8ad0]) by smtp.gmail.com with ESMTPSA id a7-20020a056808098700b0035c073aa0d8sm5006831oic.18.2022.12.13.13.25.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:25:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 09/27] tcg: Simplify calls to temp_sync vs mem_coherent Date: Tue, 13 Dec 2022 15:25:23 -0600 Message-Id: <20221213212541.1820840-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221213212541.1820840-1-richard.henderson@linaro.org> References: <20221213212541.1820840-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::22f; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The first thing that temp_sync does is check mem_coherent, so there's no need for the caller to do so. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 0f58013a5a..36a33a122c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -4075,12 +4075,8 @@ static bool tcg_reg_alloc_dup2(TCGContext *s, const TCGOp *op) /* If the two inputs form one 64-bit value, try dupm_vec. */ if (itsl + 1 == itsh && itsl->base_type == TCG_TYPE_I64) { - if (!itsl->mem_coherent) { - temp_sync(s, itsl, s->reserved_regs, 0, 0); - } - if (!itsh->mem_coherent) { - temp_sync(s, itsh, s->reserved_regs, 0, 0); - } + temp_sync(s, itsl, s->reserved_regs, 0, 0); + temp_sync(s, itsh, s->reserved_regs, 0, 0); #if HOST_BIG_ENDIAN TCGTemp *its = itsh; #else