From patchwork Mon Dec 5 09:51:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 631046 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2423843pvb; Mon, 5 Dec 2022 01:59:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Ka7X7TNdFaEcoEgIFQMOSQNB6b5FDUjPkCV5UjGU2vIoemoG53mb1e6WXtnoVUj3HUGXR X-Received: by 2002:a05:620a:201c:b0:6ce:51a0:a80e with SMTP id c28-20020a05620a201c00b006ce51a0a80emr70914570qka.591.1670234347478; Mon, 05 Dec 2022 01:59:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670234347; cv=none; d=google.com; s=arc-20160816; b=tCUISQ18TUW+yS7qVh5oVMONmQ5h3M5u2Jh7EpnBvmstaITCmz16yRxvGsa7ReJxts OYKw9dfRsEgoPL35TzIZNIy7ghE1IGMdDZZYsXtRlUEEDTTPeiuxdFmusR91XT7Veqxh DD+fkraCrAvEqwWKBSJ81i8ZmhJzozqEglPSDKdG4YkTaGW9vLltvyYSbajcViY7mEsB BKX2RsbGZ+kTySAUZ1TQaHLYZs/NRCyeH/MvcsnVClSvVOuhyXgyS1XqvavXC0axsAW4 ogNIF/T/TdUhjMDW5Y8sZXgCrb5hKPpH58nubIXViLNcCLHNYJziMfkL3HjSxaINGbYu BSqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JzR6LoP80zahpbmKbQVOVIoUoQ6EpDTG7DyoVVDdz14=; b=P+UYF78YLDYK8D9TE7Q9D7/+hcST/4sGdLzwB5DavTDzBh4BbhYyE8wqiGMj1ffKLD bW814DqOUHBOW2VpyZWI4j5d9iFvVpS7CkY7mIuj65wjF+gecB1/BwOW6Wedtgp6vlKL +WDcT8XZ9+p6H4mAUxs+Py3yxDWGo/hENblQYgKZhpFcI9ma2zu4TSPtRrYEGmsKBCVR zcqh+Lgk/wU3j3YvOed8JNDv2hImIW7a43OI8oyVGS8IP+An/IRfgO/vizas4rdNp0IO 8DLNGSditom8L75cjbHQNlzUrgPG07hEITEltNimLaM42wTUiCIj1ldnHwbPOgnGS8fh UnFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bEjnPzKf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l4-20020a378904000000b006fec601fc23si403960qkd.477.2022.12.05.01.59.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Dec 2022 01:59:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bEjnPzKf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p28B9-0001hZ-IH; Mon, 05 Dec 2022 04:54:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p28B5-0001be-8w for qemu-devel@nongnu.org; Mon, 05 Dec 2022 04:54:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p28B3-0006ga-Ob for qemu-devel@nongnu.org; Mon, 05 Dec 2022 04:54:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670234061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JzR6LoP80zahpbmKbQVOVIoUoQ6EpDTG7DyoVVDdz14=; b=bEjnPzKfJlIs3/gwzjcfRzawCwEirnI2v6v8hxfj6ge9EVNXY9gqlwlMjJgGy/C8hjU9nG UItlqBwNdmMHu45oMINSq2EaUZ8tIqT3uLE7Ijjvf84Hl+lPbkijpmnSD2A4C/d1X6QL2Q fHn6n2xCSrvqXaiZ+x2Od86PAFPRVqU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-V-jSwxfUPjSLf24igefaqw-1; Mon, 05 Dec 2022 04:54:15 -0500 X-MC-Unique: V-jSwxfUPjSLf24igefaqw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBA01101A54E; Mon, 5 Dec 2022 09:54:14 +0000 (UTC) Received: from secure.mitica (unknown [10.39.194.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id A245F2166B29; Mon, 5 Dec 2022 09:54:07 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Cc: Fam Zheng , Thomas Huth , Viresh Kumar , Kevin Wolf , Mathieu Poirier , Laurent Vivier , Eric Blake , Richard Henderson , Raphael Norwitz , Stefan Hajnoczi , Juan Quintela , virtio-fs@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Christian Borntraeger , "Gonglei (Arei)" , qemu-block@nongnu.org, Xiaojuan Yang , Thomas Huth , Ilya Leoshkevich , Eduardo Habkost , Gerd Hoffmann , "Dr. David Alan Gilbert" , Alex Williamson , Eric Farman , Halil Pasic , Peter Maydell , Vladimir Sementsov-Ogievskiy , Jason Wang , Laurent Vivier , Song Gao , qemu-s390x@nongnu.org, Pavel Dovgalyuk , Klaus Jensen , John Snow , Michael Tokarev , qemu-arm@nongnu.org, Paolo Bonzini , "Michael S. Tsirkin" , Keith Busch , David Hildenbrand , qemu-trivial@nongnu.org, Hanna Reitz Subject: [PATCH v2 12/51] tests/qtests: override "force-legacy" for gpio virtio-mmio tests Date: Mon, 5 Dec 2022 10:51:49 +0100 Message-Id: <20221205095228.1314-13-quintela@redhat.com> In-Reply-To: <20221205095228.1314-1-quintela@redhat.com> References: <20221205095228.1314-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Alex Bennée The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a legacy MMIO interface we miss out that feature bit causing confusion. For the GPIO test force the mmio bus to support non-legacy so we can properly test it. Signed-off-by: Alex Bennée Reviewed-by: Michael S. Tsirkin Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1333 Message-Id: <20221130112439.2527228-2-alex.bennee@linaro.org> Acked-by: Thomas Huth Signed-off-by: Michael S. Tsirkin --- tests/qtest/libqos/virtio-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqos/virtio-gpio.c b/tests/qtest/libqos/virtio-gpio.c index 762aa6695b..f22d7b5eb5 100644 --- a/tests/qtest/libqos/virtio-gpio.c +++ b/tests/qtest/libqos/virtio-gpio.c @@ -154,7 +154,8 @@ static void virtio_gpio_register_nodes(void) QOSGraphEdgeOptions edge_opts = { }; /* vhost-user-gpio-device */ - edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test"; + edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test " + "-global virtio-mmio.force-legacy=false"; qos_node_create_driver("vhost-user-gpio-device", virtio_gpio_device_create); qos_node_consumes("vhost-user-gpio-device", "virtio-bus", &edge_opts);