From patchwork Fri Nov 11 14:55:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 623740 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp827705pvb; Fri, 11 Nov 2022 06:57:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf6qgVFk7qrfRmLcjwExmYvFQvfQ1xOQnWPlNFuJIrBTE64/TTheB/pwfaWa1q24tSmB6hwM X-Received: by 2002:a05:622a:1cc6:b0:39c:eb15:b6df with SMTP id bc6-20020a05622a1cc600b0039ceb15b6dfmr1537182qtb.518.1668178662096; Fri, 11 Nov 2022 06:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668178662; cv=none; d=google.com; s=arc-20160816; b=YsJOXYFldSMCDw7Uj78tsKDELlXWTLGySIRdagBF49WFxd/i5/e8S2pl7uhKzAyICj 1HfkxBrd8QinNGr6/8qGqA7xexo5xVPrle5WOh2ovd7G1EiHKaOkggfhNFR8HNYGbhLG +Sj977rpW1275fSINNig/9045SPYh18oYp5RZG2n2YApVe6Vd29nWUdkaa5iuun0HCsw myb692hRpYBqQ+3UEBEA6i8splDy7cMBmh11FS0LbHbf5TH1j9c0LLfpl/o8QXCOogdC ay6DJJNKj8tmQWmEQRiPXpK3wXkD52Smh9pecOlKfsseTA8aJaVsRkEp5ElMBbssLLp2 3QaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=xqn6Rb3zGq9w0EurBYNXTkbWKvLvYQnPHBl32p2JUj1Zdvp8CQiLDsHFXAPvIwd/8V Fo4SK5I7kjaJkkZWA7McL+Z8O+rsZnrI5IAJ6RR1t7MDKKw0nImmZrzJAHBZ71C8Nox7 F10D7MzTaaLUcW6dwkD3MXPzYxf2QwCsioXjX8Im3dOr+fMc8ETN5raMhNd2Nj3hJ48S k2W7ysQIPZXhEiSE6GMYOYtKyXtbB3dGBPJ4Kx6KUSw2Pebv1itIviZkj4jq2DAecpj2 Kanh4jL+/CS2DoMR3yyDxQ2UEiPcUaeWBzgmdurbru4/nbYGZggXgu5pd7BcDVGMhC+k BDWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoeQrQnI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q5-20020ad45745000000b004af9e63b490si1061363qvx.4.2022.11.11.06.57.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Nov 2022 06:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BoeQrQnI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otVRb-00075C-NE; Fri, 11 Nov 2022 09:55:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otVRW-00072t-DN for qemu-devel@nongnu.org; Fri, 11 Nov 2022 09:55:42 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otVRT-0007xV-Hx for qemu-devel@nongnu.org; Fri, 11 Nov 2022 09:55:42 -0500 Received: by mail-wm1-x32b.google.com with SMTP id t4so3072008wmj.5 for ; Fri, 11 Nov 2022 06:55:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=BoeQrQnI2ZGynBzAvlcqSMhgTLDrnrzj5VQILDx2IiaEyT0k5ab4id+mD6gswK1tlg RjVH2YqCPaMmyykL1JEhreuc56uXeYnBBE4360FNR+HeZHEfwGmn6q8tzGi18Ynj15JO qhnJqnkU+P08rGX122no8HIBYBdWfAUk0Rzp96dbcmN9kb0H1cf2WLSFMCUTYsGg992Y Rp1SNWIhCWil30LpnAZsl3xIbJmjO74i8kUZupjUOFqMcimURqR+IW1KesYJD59yFqoM yJNV4jNncqzBIAtCB5Mdgr3KXUNzz2DPXc/KpVQhdyLYolq/1va1+1ulju18al8eAJxq 6ioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=ShDmYgi6zINtqc7XaVfG1ofk/KHctqDk4Yy2z1CqEMuKj0pN2/7Uxb2/Pq/J71riFG JvEFD81nMyF2ITx0Y9f+iSfrMlmqgxZR3+InqgTWlt7ogELND8ZEii7BCJd5Ucn40R5z Uyubv9Q5IcazzoArOicrFAXjL2rkhA3BPt6Bq1+dwNN+HrRnAgVuFnT5Ste0Y/KKxOkK COytcJJK4Ks81EUrQ3MUj7I6sYAsxWKEb66ICPQkwQpUXrqimunRdpa3OvW6t55irbYB eTVSKV+YRHMESbHAW3qxjMoS2FHx8upcsPsUyr3qsiCbA8WZ2a4aw0Owr3u2E3tkRFsW 18Mw== X-Gm-Message-State: ANoB5pnhqoLsHZMhoW7ryU99WbT21256KKiQkZCkb84RRQeMcg35Ofjn t+pFReLX2RFmwGa5ZkVbOAIxCQ== X-Received: by 2002:a7b:c4d3:0:b0:3cf:88e7:f808 with SMTP id g19-20020a7bc4d3000000b003cf88e7f808mr1492201wmk.200.1668178537813; Fri, 11 Nov 2022 06:55:37 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id n2-20020a05600c3b8200b003b476cabf1csm3672104wms.26.2022.11.11.06.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 06:55:32 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id BD5D71FFC0; Fri, 11 Nov 2022 14:55:30 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Markus Armbruster Subject: [PATCH v2 08/12] docs/devel: try and improve the language around patch review Date: Fri, 11 Nov 2022 14:55:25 +0000 Message-Id: <20221111145529.4020801-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221111145529.4020801-1-alex.bennee@linaro.org> References: <20221111145529.4020801-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Bennée Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221012121152.1179051-5-alex.bennee@linaro.org> --- docs/devel/submitting-a-patch.rst | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 1f2bde0625..80e8693bb6 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner approach, or even just point out code style issues or commit message typos. You'll need to respond to these, and then send a second version of your patches with the issues fixed. This takes a little time and effort on your part, but -if you don't do it then your changes will never get into QEMU. It's also -just polite -- it is quite disheartening for a developer to spend time -reviewing your code and suggesting improvements, only to find that -you're not going to do anything further and it was all wasted effort. +if you don't do it then your changes will never get into QEMU. + +Remember that a maintainer is under no obligation to take your +patches. If someone has spent the time reviewing your code and +suggesting improvements and you simply re-post without either +addressing the comment directly or providing additional justification +for the change then it becomes wasted effort. You cannot demand others +merge and then fix up your code after the fact. When replying to comments on your patches **reply to all and not just the sender** -- keeping discussion on the mailing list means everybody -can follow it. +can follow it. Remember the spirit of the :ref:`code_of_conduct` and +keep discussions respectful and collaborative and avoid making +personal comments. .. _pay_attention_to_review_comments: