From patchwork Fri Nov 11 07:40:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 623704 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp628220pvb; Fri, 11 Nov 2022 00:13:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf4XTgpf51XtXSxladAL1v0bogVII+npErAy00kkBKQ/KlrLfCV7CJHgn2LjOLOev1n+sH1t X-Received: by 2002:a05:6214:1192:b0:4bb:65cb:cff5 with SMTP id t18-20020a056214119200b004bb65cbcff5mr1024829qvv.38.1668154387600; Fri, 11 Nov 2022 00:13:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668154387; cv=none; d=google.com; s=arc-20160816; b=BsM496zLoJObL+skkv/xNSBFWaXDHK3cXOXF1aUmAA49RcFWaPRQ2FmveM1g/hR4WC zFj+mAryhdBLrRp9KJr1RKEch6EzEeTWe9X1DKi5wzHbYHMDM8MpITEu5x1yU93PyBbu 3Vu7nlbYqdqHM14iLb9RJzRRag4m/KTFg+X5hfdk+uX5QE8iS1oYK4APPRz2WVmJi6YH wRhJaC7a3QHfS/YQSr2tJQj3WSReQ6bk89sV7GchyIK827lMLGdZzpNgZYsaW2EI7tO6 11tUQE1nkQyObLsdfuR2gBCnqHmWHwx0R0kVQNyr8TnGeZ5kfx3SpiJTuu1Ihqogp88w nL4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=8Y1g/wUg06QV14OKflOwRGsY0ezG4rnZiU5/c0ET0lg=; b=iRhZ/WT45EvmiA/Tq27ETDBFNJ7Tdo1PD2wc9k6e3A3X3ZqA5AGIjGHeGLttRv8MY+ lo6bRLIeOHMSIA2WQZqEb0V1EL9tUYU+fhHEKBtBHO3RrTD/hLzDxf7+O+77crivYBe4 U0Yv8dTI+V3csjAdwwxgPtVfpEjoZJGFPfohCYjJjwGIVOB2D7Q72BoQgfl9F0WS2Fsn ZUtuNcdEq1YB7tCxFoLBsPurtm06JFvxsyQdMxn+H9cJTB7Q0E1a4Hgjnl99XAAK5s+D OUIKQvgzfuAKNN6cloExVLku3xAHnt2/sUBTK6mUuHxspKz2q19r++yO4yLkyhtJ2n4i N01A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lY7a8gE2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gv10-20020a056214262a00b004bb95ea0e4fsi626561qvb.350.2022.11.11.00.13.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Nov 2022 00:13:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lY7a8gE2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otOjV-0001Pb-OL; Fri, 11 Nov 2022 02:45:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOjT-0001N0-RZ for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:45:47 -0500 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otOjS-000182-36 for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:45:47 -0500 Received: by mail-pj1-x1033.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so4089262pji.0 for ; Thu, 10 Nov 2022 23:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8Y1g/wUg06QV14OKflOwRGsY0ezG4rnZiU5/c0ET0lg=; b=lY7a8gE2C9IWsGik3j4R92fFRpym2KWYCKJn/lpenv1VRt/JfEd+0xbV3odxYqI8js aX2OcgwqE+YtjuPPfXM+oBfMTLmr3P7YxRludhe2ntBYidiNh9V77dy35TS1gyzp6Ojm aFIKxfXAiyhtbdAc7l2JD3W4WfKeH1slF9/CD2YImHjZCjqunuVMmemuKtRGyvl/X8kH vN6WVQu+4ke/HyqCV7Z6bseTs1irFGOPKoBNhzfCMQX63JkWoZ+y7obw+kWzwrHufh9h AeFHl+fmYMACwBWF3jihb9khVPJwfYqAivgDHA0y/SBHYgznyp7hQoeKafzIM0WL3653 6O0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Y1g/wUg06QV14OKflOwRGsY0ezG4rnZiU5/c0ET0lg=; b=OgrVvwKiAEzhOrOb1HrBU3CFF7rhZUa3QDPEpi7AydJrOo0VP7rasMUaWhJHUQ2W7M ipQ/dYCtSQVkt8OZSnJdKEB/a8yv0Aq0UawwD+L4hsvVRITARkyY7nGQ2dFN3aS1cDDD Xk/sNBf9aySdQnFgGwc2OiVaLhbWT9Ac/SSsP8gVxhUvBz/5h95ww4N7R2EUk6zuIeki DJ67PxjmwzkezmDHyu5mQRBFShrlGLfrvYjczm51Th7ZAIKhIDaxwYmyuRtCZ+xJ1LGi UjAjYzRf/dFomoSbDT2GyjqG/6Hrb6VZh/Bt3cwiRGRdB+3QLwi9aWKBCJfw7fnSZuei IoNw== X-Gm-Message-State: ANoB5pmSdgC58lwP8pXMXqCSIPOvBCoo6y04YkUytF1q8A2s4yo99RFo RbyB3bSKs2zIpa0/hE+9LFdqVOKbh91z+n3t X-Received: by 2002:a17:903:284:b0:186:b91b:17ec with SMTP id j4-20020a170903028400b00186b91b17ecmr1479921plr.10.1668152744588; Thu, 10 Nov 2022 23:45:44 -0800 (PST) Received: from stoup.lan (2001-44b8-2176-c800-0aef-59aa-1faf-7e61.static.ipv6.internode.on.net. [2001:44b8:2176:c800:aef:59aa:1faf:7e61]) by smtp.gmail.com with ESMTPSA id u13-20020a170902e80d00b001869f2120a6sm983802plg.108.2022.11.10.23.45.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 23:45:44 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-8.0 v3 41/45] tcg: Add temp allocation for TCGv_i128 Date: Fri, 11 Nov 2022 17:40:57 +1000 Message-Id: <20221111074101.2069454-42-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221111074101.2069454-1-richard.henderson@linaro.org> References: <20221111074101.2069454-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This enables allocation of i128. The type is not yet usable, as we have not yet added data movement ops. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 32 +++++++++++++++++++++++++ tcg/tcg.c | 60 +++++++++++++++++++++++++++++++++-------------- 2 files changed, 74 insertions(+), 18 deletions(-) diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 7d346192ca..a996da60b5 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -697,6 +697,11 @@ static inline TCGTemp *tcgv_i64_temp(TCGv_i64 v) return tcgv_i32_temp((TCGv_i32)v); } +static inline TCGTemp *tcgv_i128_temp(TCGv_i128 v) +{ + return tcgv_i32_temp((TCGv_i32)v); +} + static inline TCGTemp *tcgv_ptr_temp(TCGv_ptr v) { return tcgv_i32_temp((TCGv_i32)v); @@ -717,6 +722,11 @@ static inline TCGArg tcgv_i64_arg(TCGv_i64 v) return temp_arg(tcgv_i64_temp(v)); } +static inline TCGArg tcgv_i128_arg(TCGv_i128 v) +{ + return temp_arg(tcgv_i128_temp(v)); +} + static inline TCGArg tcgv_ptr_arg(TCGv_ptr v) { return temp_arg(tcgv_ptr_temp(v)); @@ -738,6 +748,11 @@ static inline TCGv_i64 temp_tcgv_i64(TCGTemp *t) return (TCGv_i64)temp_tcgv_i32(t); } +static inline TCGv_i128 temp_tcgv_i128(TCGTemp *t) +{ + return (TCGv_i128)temp_tcgv_i32(t); +} + static inline TCGv_ptr temp_tcgv_ptr(TCGTemp *t) { return (TCGv_ptr)temp_tcgv_i32(t); @@ -860,6 +875,11 @@ static inline void tcg_temp_free_i64(TCGv_i64 arg) tcg_temp_free_internal(tcgv_i64_temp(arg)); } +static inline void tcg_temp_free_i128(TCGv_i128 arg) +{ + tcg_temp_free_internal(tcgv_i128_temp(arg)); +} + static inline void tcg_temp_free_ptr(TCGv_ptr arg) { tcg_temp_free_internal(tcgv_ptr_temp(arg)); @@ -908,6 +928,18 @@ static inline TCGv_i64 tcg_temp_local_new_i64(void) return temp_tcgv_i64(t); } +static inline TCGv_i128 tcg_temp_new_i128(void) +{ + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, false); + return temp_tcgv_i128(t); +} + +static inline TCGv_i128 tcg_temp_local_new_i128(void) +{ + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, true); + return temp_tcgv_i128(t); +} + static inline TCGv_ptr tcg_global_mem_new_ptr(TCGv_ptr reg, intptr_t offset, const char *name) { diff --git a/tcg/tcg.c b/tcg/tcg.c index 5465297495..50db393594 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1232,26 +1232,45 @@ TCGTemp *tcg_temp_new_internal(TCGType type, bool temp_local) tcg_debug_assert(ts->base_type == type); tcg_debug_assert(ts->kind == kind); } else { + int i, n; + + switch (type) { + case TCG_TYPE_I32: + case TCG_TYPE_V64: + case TCG_TYPE_V128: + case TCG_TYPE_V256: + n = 1; + break; + case TCG_TYPE_I64: + n = 64 / TCG_TARGET_REG_BITS; + break; + case TCG_TYPE_I128: + n = 128 / TCG_TARGET_REG_BITS; + break; + default: + g_assert_not_reached(); + } + ts = tcg_temp_alloc(s); - if (TCG_TARGET_REG_BITS == 32 && type == TCG_TYPE_I64) { - TCGTemp *ts2 = tcg_temp_alloc(s); + ts->base_type = type; + ts->temp_allocated = 1; + ts->kind = kind; - ts->base_type = type; - ts->type = TCG_TYPE_I32; - ts->temp_allocated = 1; - ts->kind = kind; - - tcg_debug_assert(ts2 == ts + 1); - ts2->base_type = TCG_TYPE_I64; - ts2->type = TCG_TYPE_I32; - ts2->temp_allocated = 1; - ts2->temp_subindex = 1; - ts2->kind = kind; - } else { - ts->base_type = type; + if (n == 1) { ts->type = type; - ts->temp_allocated = 1; - ts->kind = kind; + } else { + ts->type = TCG_TYPE_REG; + + for (i = 1; i < n; ++i) { + TCGTemp *ts2 = tcg_temp_alloc(s); + + tcg_debug_assert(ts2 == ts + i); + ts2->base_type = type; + ts2->type = TCG_TYPE_REG; + ts2->temp_allocated = 1; + ts2->temp_subindex = i; + ts2->kind = kind; + } } } @@ -3413,9 +3432,14 @@ static void temp_allocate_frame(TCGContext *s, TCGTemp *ts) case TCG_TYPE_V64: align = 8; break; + case TCG_TYPE_I128: case TCG_TYPE_V128: case TCG_TYPE_V256: - /* Note that we do not require aligned storage for V256. */ + /* + * Note that we do not require aligned storage for V256, + * and that we provide alignment for I128 to match V128, + * even if that's above what the host ABI requires. + */ align = 16; break; default: