From patchwork Fri Nov 11 07:40:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 623707 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp628980pvb; Fri, 11 Nov 2022 00:15:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf4iilCmRz6MnY6KN2hj2d9jVw2sqt2p9xEk3gfasW48RKyOB2nDwiJPVMLpb7K2i748P8z6 X-Received: by 2002:a37:84b:0:b0:6f9:ffc7:a9e4 with SMTP id 72-20020a37084b000000b006f9ffc7a9e4mr239611qki.277.1668154508303; Fri, 11 Nov 2022 00:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668154508; cv=none; d=google.com; s=arc-20160816; b=b8KJY0p1DIPVPLQfI9SP7xOrZTEx/kyemVJPwQKWNZUkb59dkqjYxvatN0rNec7kRC L1sitf08RjAA5HSg8IJwYUapK+bW4PSLJz4N8Oefj0eRjVQFc1W9QOqPr3oAxg6qapGX SrO7tc8QeqzPMYJ6Pm3R5Hsra5+nfwsuwzUDJXQPE8KIJAvbrxZ7YSyfy4OAMOR18Bl9 iclt5Vc4N2qoxkYTGBHTUE0mqnmrYojmO3Rkp3RHm3eGdFgFG80X+2hhwzk/CeA6CEO9 djjtXwB6TFm4ZVWPpv5r6YeZxJ1yoiYblzVS13VXLpM9oge71zC2udBVKlxhW7EWZIEU ebag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=KbxYnYMZOdgUIKzB3W7e4WMSmPoKgVqMloJtF9P8blQ=; b=X7j7T9kfcekk4aTFLEUuv3PW7nnUv5clcGschQdGyJnCEE8pWbaAVvywmORyPHM0c5 weUsjBNfmVys4baIPoFih92/3vJaPNNlbODZfk7WnvPEPH6MZzqhWPUk5VK/jlilBdFo 99FKgYXtzrDiBYgWUcboWi67dNwV03/alZ6Qyqj6fUwLwn6HliE6+3LLrUYFsLmP1dIU Z8eaXx0gI0K9NsxuOLxmFFpBlTf4MVNLyTTAyI7m37XERZuWyhDSiG/ONTeJl1Hx0ZF/ bKR0SIJ26dog/UEdLeXRekFwA19SnqIO/qzCFWwE1ad91uZCoi3atF3PwnfgyQ2RebK/ iJSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JIq3MuhG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h17-20020ac87d51000000b003a50cd2492bsi761260qtb.457.2022.11.11.00.15.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Nov 2022 00:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JIq3MuhG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otOfs-0006dY-Ne; Fri, 11 Nov 2022 02:42:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOfn-0006Qr-Eu for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:41:59 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otOfk-0007wx-Vn for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:41:59 -0500 Received: by mail-pl1-x630.google.com with SMTP id c2so3606800plz.11 for ; Thu, 10 Nov 2022 23:41:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KbxYnYMZOdgUIKzB3W7e4WMSmPoKgVqMloJtF9P8blQ=; b=JIq3MuhGP0xwgKD7RVZhZAtekwztkmgNKhrEPRscQ4bjdpIqzEhyDZ3b5upHGgqZ9e yebruR2XNtCPWMqgPS6jQbXCc7Ebx+YcTL4NtP7lnJvT2/d8/syi0oSgMhIkW7Ic3JZr LrgfBv3g1jcMGAHOiT7Mor9WbwA73XOG9j6FA55975u+1MMzLyln1xkR4czbz6MTi/Ql BIApSoav1vWNmEWep6k0FAIpMYiz0yT5bkozL91vutXmIqMmrUYx59iSuEU5UPf1v4ll yDxD6KkyOzqA03i371UnA4f/6Q8tq6dXYMzzsLgqBa57FQDHRYSrldz7ONnjbR+gv/dM YKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KbxYnYMZOdgUIKzB3W7e4WMSmPoKgVqMloJtF9P8blQ=; b=xH5kfjGuFH3g0kK+Llg0NQLAlK42epzLQ5ECn1nmf7ch+k61M9K7C4oJly9kNhi5QX 4VaYxcDS+mAGqRHP/YU3UhJh2qq9WP8BdM1GXVDp8jwBpPtpyWn7LoMFqreUzhQgqfC3 spDq707be8/9xz4FsRf1VxHzRCExDhjXi6D7DiglM6jarKbfeZCzWj8PQQEIfHeSRB/v 57y7vV9lvYxf5elRn69/ZX6gaNbKgWf3ZcsQ4OvLcSqUXPyu1gnottLZhOSyaw7U34Bk Vlc7Yiw8Mlvlmbq8lFJf5NbhEKLZxvQgrKvFAIb1XPV5Skmx87L8sbDTNb3aK88XNSyW tDOw== X-Gm-Message-State: ANoB5pnFvzUZfUlTA4lTcnjoc0Uo4nUQpgjM6gm7NRIXbkLjv2qL9S3Q TMHNKrExEU9IlZKQ30XS4FLMbiP0BuxAh037 X-Received: by 2002:a17:90a:ac11:b0:213:f398:ed51 with SMTP id o17-20020a17090aac1100b00213f398ed51mr575046pjq.216.1668152514904; Thu, 10 Nov 2022 23:41:54 -0800 (PST) Received: from stoup.lan (2001-44b8-2176-c800-0aef-59aa-1faf-7e61.static.ipv6.internode.on.net. [2001:44b8:2176:c800:aef:59aa:1faf:7e61]) by smtp.gmail.com with ESMTPSA id o15-20020a170902d4cf00b001754fa42065sm976069plg.143.2022.11.10.23.41.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 23:41:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-8.0 v3 20/45] accel/tcg/plugin: Avoid duplicate copy in copy_call Date: Fri, 11 Nov 2022 17:40:36 +1000 Message-Id: <20221111074101.2069454-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221111074101.2069454-1-richard.henderson@linaro.org> References: <20221111074101.2069454-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We copied all of the arguments in copy_op_nocheck. We only need to replace the one argument that we change. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- accel/tcg/plugin-gen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 9e359c006a..77e6823d6b 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -397,9 +397,7 @@ static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *empty_func, func_idx = TCGOP_CALLO(op) + TCGOP_CALLI(op); *cb_idx = func_idx; - op->args[func_idx] = (uintptr_t)func; - op->args[func_idx + 1] = old_op->args[func_idx + 1]; return op; }