diff mbox series

[RESEND,2/6] disas/nanomips: Merge insn{1,2,3} into words[3]

Message ID 20221106023735.5277-3-richard.henderson@linaro.org
State New
Headers show
Series Two -Wclobbered fixes, plus other cleanup | expand

Commit Message

Richard Henderson Nov. 6, 2022, 2:37 a.m. UTC 
Since Disassemble wants the data in this format, collect
it that way.  This allows using a loop to print the bytes.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 disas/nanomips.c | 44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

Comments

Philippe Mathieu-Daudé Nov. 6, 2022, 5:50 p.m. UTC | #1 
On 6/11/22 03:37, Richard Henderson wrote:
> Since Disassemble wants the data in this format, collect
> it that way.  This allows using a loop to print the bytes.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   disas/nanomips.c | 44 +++++++++++++++++++++-----------------------
>   1 file changed, 21 insertions(+), 23 deletions(-)
> 
> diff --git a/disas/nanomips.c b/disas/nanomips.c
> index 9a69e6880a..5438def9af 100644
> --- a/disas/nanomips.c
> +++ b/disas/nanomips.c
> @@ -21905,12 +21905,8 @@ static const Pool MAJOR[2] = {
>          0x0                 },        /* P16 */
>   };
>   
> -static bool nanomips_dis(char **buf, Dis_info *info,
> -                         unsigned short one,
> -                         unsigned short two,
> -                         unsigned short three)
> +static bool nanomips_dis(char **buf, Dis_info *info, uint16_t words[3])

words[] can be const.

> +    for (int i = 0; i < 6; i += 2) {

I'd rather convert this magic 6 and iterate over ARRAY_SIZE(words).

Anyhow,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +        if (i < length) {
> +            (*info->fprintf_func)(info->stream, "%04x ", words[i / 2]);
> +        } else {
> +            (*info->fprintf_func)(info->stream, "     ");
> +        }
>       }
diff mbox series

Patch

diff --git a/disas/nanomips.c b/disas/nanomips.c
index 9a69e6880a..5438def9af 100644
--- a/disas/nanomips.c
+++ b/disas/nanomips.c
@@ -21905,12 +21905,8 @@  static const Pool MAJOR[2] = {
        0x0                 },        /* P16 */
 };
 
-static bool nanomips_dis(char **buf, Dis_info *info,
-                         unsigned short one,
-                         unsigned short two,
-                         unsigned short three)
+static bool nanomips_dis(char **buf, Dis_info *info, uint16_t words[3])
 {
-    uint16 bits[3] = {one, two, three};
     TABLE_ENTRY_TYPE type;
     int ret;
 
@@ -21919,7 +21915,7 @@  static bool nanomips_dis(char **buf, Dis_info *info,
         return false;
     }
 
-    ret = Disassemble(bits, buf, &type, MAJOR, 2, info);
+    ret = Disassemble(words, buf, &type, MAJOR, 2, info);
     return ret >= 0;
 }
 
@@ -21927,7 +21923,7 @@  int print_insn_nanomips(bfd_vma memaddr, struct disassemble_info *info)
 {
     int status, length;
     bfd_byte buffer[2];
-    uint16_t insn1 = 0, insn2 = 0, insn3 = 0;
+    uint16_t words[3] = { };
     g_autofree char *buf = NULL;
 
     info->bytes_per_chunk = 2;
@@ -21951,15 +21947,14 @@  int print_insn_nanomips(bfd_vma memaddr, struct disassemble_info *info)
     }
 
     if (info->endian == BFD_ENDIAN_BIG) {
-        insn1 = bfd_getb16(buffer);
+        words[0] = bfd_getb16(buffer);
     } else {
-        insn1 = bfd_getl16(buffer);
+        words[0] = bfd_getl16(buffer);
     }
     length = 2;
-    (*info->fprintf_func)(info->stream, "%04x ", insn1);
 
     /* Handle 32-bit opcodes.  */
-    if ((insn1 & 0x1000) == 0) {
+    if ((words[0] & 0x1000) == 0) {
         status = (*info->read_memory_func)(memaddr + 2, buffer, 2, info);
         if (status != 0) {
             (*info->memory_error_func)(status, memaddr + 2, info);
@@ -21967,17 +21962,15 @@  int print_insn_nanomips(bfd_vma memaddr, struct disassemble_info *info)
         }
 
         if (info->endian == BFD_ENDIAN_BIG) {
-            insn2 = bfd_getb16(buffer);
+            words[1] = bfd_getb16(buffer);
         } else {
-            insn2 = bfd_getl16(buffer);
+            words[1] = bfd_getl16(buffer);
         }
         length = 4;
-        (*info->fprintf_func)(info->stream, "%04x ", insn2);
-    } else {
-        (*info->fprintf_func)(info->stream, "     ");
     }
+
     /* Handle 48-bit opcodes.  */
-    if ((insn1 >> 10) == 0x18) {
+    if ((words[0] >> 10) == 0x18) {
         status = (*info->read_memory_func)(memaddr + 4, buffer, 2, info);
         if (status != 0) {
             (*info->memory_error_func)(status, memaddr + 4, info);
@@ -21985,18 +21978,23 @@  int print_insn_nanomips(bfd_vma memaddr, struct disassemble_info *info)
         }
 
         if (info->endian == BFD_ENDIAN_BIG) {
-            insn3 = bfd_getb16(buffer);
+            words[2] = bfd_getb16(buffer);
         } else {
-            insn3 = bfd_getl16(buffer);
+            words[2] = bfd_getl16(buffer);
         }
         length = 6;
-        (*info->fprintf_func)(info->stream, "%04x ", insn3);
-    } else {
-        (*info->fprintf_func)(info->stream, "     ");
+    }
+
+    for (int i = 0; i < 6; i += 2) {
+        if (i < length) {
+            (*info->fprintf_func)(info->stream, "%04x ", words[i / 2]);
+        } else {
+            (*info->fprintf_func)(info->stream, "     ");
+        }
     }
 
     /* Handle runtime errors. */
-    if (nanomips_dis(&buf, &disassm_info, insn1, insn2, insn3)) {
+    if (nanomips_dis(&buf, &disassm_info, words)) {
         (*info->fprintf_func) (info->stream, "%s", buf);
     }