From patchwork Mon Oct 31 13:10:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 620237 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2819981pvb; Mon, 31 Oct 2022 06:22:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM71Zzhw5ac57bcNJ6XDEI7PF6BrhqwcRGTOI2JT1UhNJcf33Jgc+r/Y5u1hkK6mrbk7Nk9M X-Received: by 2002:a05:620a:51ca:b0:6f5:71e1:5ccf with SMTP id cx10-20020a05620a51ca00b006f571e15ccfmr8728754qkb.217.1667222541832; Mon, 31 Oct 2022 06:22:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667222541; cv=none; d=google.com; s=arc-20160816; b=wsszTcsXWHP3DeAGuEkOvPEd+WpQWwAy/uxVa7G2+nNrBiVlma+fDdnrRX7QcAbjd3 /OHkQt2r/LxMmLbYsPOQwiKZzjLq6kQ3vELU3MT/8DGiCgdHQYSwx+gfRIQpF+jzbtvO xiwd6MwTTx9emaTSeHbjydmxWDpPhlKWu0fD/RaqvxgbwDudcKlX/thdiTtMt3mke02t 2yqQ4tUQ0PiNl/xiCWCN//jkWOMXRRbsPLYS4TMLdD+jgvQjLhDjMjndKW5ePNTDGBZe MfHPs+kViwsBvQVSRbU3fcUTUud1oDaViw431WbRU4Wl8EMjcSaQg+/U1naPnYJJws/+ xScA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0EBDvZ+RnJ5HvMeb/y4i+e3DUIkgxVD1VYY/3oYu2EI=; b=GmxXXFYzmnTCB03euuadRrzCdzoMvTwMDNcxk3PeD5HJIL0+Bp40OsOyXrKOjvXFNO +EFE3KL/Q3mTGfWjnHoaoHsgBSTE+9f9hEVIwy6+3Dwfpycefn5Y0VKNUWLLJTuMaQxu O9tO5f7W4XHXbxPINfvGi1o85FEo9jn2dZNQ28tqQ2ma/p6xFVI1YMOG+vEkld0t0p9+ qHIZo2p/F63p42yREqmjbgVt566tk+pZ932v/4dXeubAJY0q5laRGBX/WJnccRl+BfDh cJXbt/QD6k5RJXVeMTR2Af5rEhnqvjLn76zHClY1/e5y4zyD/NI269FjDaMCN/7jtbCZ oS7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vuzkvuW2; spf=pass (google.com: domain of qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u10-20020a37ab0a000000b006bb710878d6si3479260qke.47.2022.10.31.06.22.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Oct 2022 06:22:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vuzkvuW2; spf=pass (google.com: domain of qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opUi8-00044Q-7V; Mon, 31 Oct 2022 09:20:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opUhr-0002tq-Rm for qemu-devel@nongnu.org; Mon, 31 Oct 2022 09:20:01 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opUhn-0005Pb-NR for qemu-devel@nongnu.org; Mon, 31 Oct 2022 09:19:59 -0400 Received: by mail-wr1-x42f.google.com with SMTP id z14so15924866wrn.7 for ; Mon, 31 Oct 2022 06:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0EBDvZ+RnJ5HvMeb/y4i+e3DUIkgxVD1VYY/3oYu2EI=; b=vuzkvuW2f8JNqWUeSfHoM7clI/Me281dTiTGmF+nRRiNycyB1KFYY48JXVebarvp6w rJg91NPtAw4LBhfcGFxkyXTn2lSsVF64o7ztfE4QcXAJRACoRZj+TmVRjQQn/cf9j6Sq EjWyjxakBFwZMlcdPN7wHvu7XKic4HrN0h4RcSElowjBC8dPmhv6Iofme1okmb86MGpU 46ejZqirg8UmyAMzovkYFn82CZ+z/RG7KXLbmXXCWtjRcUSu0cOx65IrlEMCv8VyyuTW drYNAswOmdVLrin0nHU6Koc11/sZtFCjcCOA8EKT6AdSZLSrbb2Cj7+Ywlw3gCcI4swB EPuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0EBDvZ+RnJ5HvMeb/y4i+e3DUIkgxVD1VYY/3oYu2EI=; b=VCQnEE/J6TbpqgdzkIwvCY1qWj87pQIEnX9xYZ0i7+A2jIIhOYX3DKAOLso94b0fSG beiUdOnVMgvsX124vdd7l+0vfCfxGdNk1VnvlbEtyKcEulgUYwQD5KbOmIll1ODD8Vd/ hzRT3ssY0RaJgl6r+qNdH5TgwdSQp//oLEVkVRTPiUUMvBMOf5lvSYlhczIW8Ul2GzCp BtL9VrzY/jyEJGKfSO1fA1Dum9yJObB2uNqFi2G8hrVrgwOBATzCnKQT2layzU6oraDu Wodc5e7jE6D/2+YxZ7TX6FJMtiT2W8eHdnWZEPotyztVF5nqlFwI7LIOyFUVbaXHF5dl WW9w== X-Gm-Message-State: ACrzQf0WuRi1EQ7q8ryJ3+l7ovPC9FErdh+60S4pLpKZ+udDSMRIk/CM VG2SZ8YBZLgpxIcURMzJ1Kb6evne3nPcnA== X-Received: by 2002:adf:e5c3:0:b0:236:5092:7cfc with SMTP id a3-20020adfe5c3000000b0023650927cfcmr7910815wrn.285.1667222393111; Mon, 31 Oct 2022 06:19:53 -0700 (PDT) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id n2-20020a7bc5c2000000b003c6c5a5a651sm7169997wmk.28.2022.10.31.06.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 06:19:51 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 502311FFBB; Mon, 31 Oct 2022 13:10:13 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , David Hildenbrand , Richard Henderson , Ilya Leoshkevich , Cornelia Huck , Thomas Huth , qemu-s390x@nongnu.org (open list:S390 TCG CPUs) Subject: [PULL 25/31] target/s390x: don't probe next pc for EXecuted insns Date: Mon, 31 Oct 2022 13:10:04 +0000 Message-Id: <20221031131010.682984-26-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221031131010.682984-1-alex.bennee@linaro.org> References: <20221031131010.682984-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+peter.griffin=linaro.org+patch=linaro.org@nongnu.org We have finished the TB anyway so we can shortcut the other tests by checking dc->ex_value first. Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Acked-by: Ilya Leoshkevich Signed-off-by: Alex Bennée Message-Id: <20221027183637.2772968-25-alex.bennee@linaro.org> diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 9df7f9e693..f4122db434 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -6624,9 +6624,9 @@ static void s390x_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) dc->base.is_jmp = translate_one(env, dc); if (dc->base.is_jmp == DISAS_NEXT) { - if (!is_same_page(dcbase, dc->base.pc_next) || - !is_same_page(dcbase, get_next_pc(env, dc, dc->base.pc_next)) || - dc->ex_value) { + if (dc->ex_value || + !is_same_page(dcbase, dc->base.pc_next) || + !is_same_page(dcbase, get_next_pc(env, dc, dc->base.pc_next))) { dc->base.is_jmp = DISAS_TOO_MANY; } }