From patchwork Mon Oct 10 17:29:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 613772 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2129724pvb; Mon, 10 Oct 2022 10:58:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4pHsVaONl8Wpy6x5FZqn7JlwW/PplB2kV9lxKK4z2BcPt8nzA5sBtX3I/31VRYAoN4LAEA X-Received: by 2002:ac8:7e94:0:b0:38e:2bea:9dd9 with SMTP id w20-20020ac87e94000000b0038e2bea9dd9mr15999669qtj.67.1665424695143; Mon, 10 Oct 2022 10:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665424695; cv=none; d=google.com; s=arc-20160816; b=Ahr3ymkzjV0mCXpPHzjV0H6DhkEY9SArPZ0pVX79U8FQanxoz8lOUu3AQ62biAEbqz sVRLK6aJKIyjPGK655yitVBBNtf6Pbg/r7T0qgLSEsvPTbILp+IwNxkwTkHcoDc9lZud QM1KLObYJuPINiluTzZHb5X4u1Jf4CsXopi6HrAQklT7jo1IfgoS4ksbQ3n5S44JKCQV T4vl8IvrrHgYpLaxxeKfkRe9Ck3sE6HhNhvEJ7nzCG2s+ljBIhkAloOaf8agtSIYN0yI /amj9sOH5q8Luava5bzp1jeI6iTVe84UQiV1rzjm2uhS8pCkOu+xBAxSuEwoUe6X1HOp 85Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yJ+3Ym4q6e4cRDvqrMY+ao2NcRPn7bSMxNJxA/MOCSY=; b=F3DThlJX0wrj7BUc5AveD7Bm8kZvZfmlpg5N1QLYzVp2Z7AUN/JHg4aVgEveiax+f1 M8JWr5GXuY+PXLNMQGGrsv1KHE39eIdEm1VbQ+Wke17oDygbe8EI4vI3z4DQfGT2JYeZ ihSl+cjMYywGstrGGygbdKhXh/ZykOZRM3CObomV/O9PXa8HXMPMr3U7Dv2xTAuxeSvm tYsR9CLEocGKJ1jL0OFMuFrl+lJSKPNo+3AoMIWtbNV6JgL8QXlxqLhIIX/Vj42B9tS3 pK4lgR1fEBQeGrsqV/Wx3b5xgqfNUQUjLt6fFhBnKHwVszeOOS/k9KI8+qWov8bmvE32 l4OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mf7wFhSD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ee7-20020a05620a800700b006e7808fc3casi6002660qkb.308.2022.10.10.10.58.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Oct 2022 10:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mf7wFhSD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:33172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohx2c-0000s2-MB for patch@linaro.org; Mon, 10 Oct 2022 13:58:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwbK-0001vX-9o for qemu-devel@nongnu.org; Mon, 10 Oct 2022 13:30:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwbC-0006e2-P6 for qemu-devel@nongnu.org; Mon, 10 Oct 2022 13:30:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665422994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJ+3Ym4q6e4cRDvqrMY+ao2NcRPn7bSMxNJxA/MOCSY=; b=Mf7wFhSDT2Igw+5L7HjUxurjSM3FPGMSeSHelj7OUh0T6TkioGHhp34ySg82VOQEFuJtii Amo6SDPNSXxyC4CIor4sSsmJu/iZZc2mgoNH9r2uvlNOkqk9rD6cEZxCgDdi1mpcz1D6+e KXsGX66Ay010pgm6M4iWWaUejM7QPyw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-114-fvOY0u2zOPGu41F1xT9XSg-1; Mon, 10 Oct 2022 13:29:53 -0400 X-MC-Unique: fvOY0u2zOPGu41F1xT9XSg-1 Received: by mail-wm1-f69.google.com with SMTP id v23-20020a1cf717000000b003bff630f31aso3259018wmh.5 for ; Mon, 10 Oct 2022 10:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yJ+3Ym4q6e4cRDvqrMY+ao2NcRPn7bSMxNJxA/MOCSY=; b=YMiKikjqgIT8/Z6uETKvl/DXUg04ggmWqYPqLBUlYG5IF9gc7Au93zvYEMUjMt3ZfO /4n30cUgsTQLD5RX36q0nbZH1FhF/p0XaAE0aT4mj8AUbAXOJg1jXWRZhVxaAm28DfoT wkDwrsywmi8Jyc3GNGMcKJUWdU1PrqxiKSU7Xxhc9rMmRstrcUjgnndLQJOTn4lxRe6x Fk0sErzufCOR2eZuX1/wfNtBZB4EuisAXxwbW3DTnRRvIAV7ealo6H9oXprmuofvVqQc TY2teRwlhIDU5w3YuZbWUhmcDuJaiGdIM2XEkFYzP7/hIEuSso9McjyQJ4P05rXSsyQH vZtg== X-Gm-Message-State: ACrzQf2om6G7CSxTkXhaWrBlalKZTPRXyScFP7GDPN2AKI8MHAjB/6gR /phwJSODLXw7mPUpqhxjyo2RiGK+HbxGzF0JKYhHugujkCpDIEC787Zfn+acduwOkI1Mn6Wo4PM gq3iNu0jzyrSV1KTvfQsDSbHxEEIiJ5R0TNnog95aFFx3NO2zdT65J2smDToq X-Received: by 2002:a7b:cc0c:0:b0:3c5:a58f:afbc with SMTP id f12-20020a7bcc0c000000b003c5a58fafbcmr6586031wmh.169.1665422991706; Mon, 10 Oct 2022 10:29:51 -0700 (PDT) X-Received: by 2002:a7b:cc0c:0:b0:3c5:a58f:afbc with SMTP id f12-20020a7bcc0c000000b003c5a58fafbcmr6586012wmh.169.1665422991374; Mon, 10 Oct 2022 10:29:51 -0700 (PDT) Received: from redhat.com ([2.55.183.131]) by smtp.gmail.com with ESMTPSA id k20-20020a05600c1c9400b003c131c5a997sm11680579wms.7.2022.10.10.10.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 10:29:50 -0700 (PDT) Date: Mon, 10 Oct 2022 13:29:47 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Alex =?utf-8?q?Benn=C3=A9e?= , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PULL 16/55] tests/qtest: add assert to catch bad features Message-ID: <20221010172813.204597-17-mst@redhat.com> References: <20221010172813.204597-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221010172813.204597-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée No device driver (which is what the qvirtio_ access functions represent) should be setting UNUSED(30) in the feature space. Although existing libqos users mask it out lets ensure nothing sneaks through. Signed-off-by: Alex Bennée Message-Id: <20220802095010.3330793-20-alex.bennee@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/libqos/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c index 09ec09b655..03056e5187 100644 --- a/tests/qtest/libqos/virtio.c +++ b/tests/qtest/libqos/virtio.c @@ -101,6 +101,8 @@ uint64_t qvirtio_get_features(QVirtioDevice *d) void qvirtio_set_features(QVirtioDevice *d, uint64_t features) { + g_assert(!(features & QVIRTIO_F_BAD_FEATURE)); + d->features = features; d->bus->set_features(d, features);