From patchwork Tue Sep 27 10:03:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Philippe Brucker X-Patchwork-Id: 609601 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp255039pvb; Tue, 27 Sep 2022 03:38:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4jAmJR9ZUt6VjAYq3hMHYyUdEGWkJghXSxWhYTBUxUz5xHs5P+BZyVcDDaoqtYFvVIwGwf X-Received: by 2002:a05:6214:1c87:b0:4af:8d8d:f319 with SMTP id ib7-20020a0562141c8700b004af8d8df319mr1372749qvb.11.1664275092168; Tue, 27 Sep 2022 03:38:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664275092; cv=none; d=google.com; s=arc-20160816; b=MYnPlDIY5J/SAxJZXjvF9wSvn4H7BXOEktvJe9pBHF1qHdFSnvEfwhOx0JdrldZdap ldPZZlJTprciAGBd7/Pfc4YYZ1/H/nDBYr3ynj/X8vUiGFtj2RhuMaZfRHQwqFyFi7gZ g2M5tSiLGsXxG4hMH+FuKu267txhb1tC7/MlN3UV3cKezAh0aXz5+5fCX17/OO3SdPJ0 7+4QVbzgRuOjpQAcUx0VuIRSE2OmTxje58WBCO0K55W4bWa5wYLqvMOFO2SWni31ofCT EowAxARtsQ9CjT8tutpaM4+oYg98oIt1tcq3Dc3ybe4lv1ClML+NXHxSvgwp2Gt+jdKG P7zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mdbZvGlemRTML0U9/q6dutguZkYkpzqfdzZefPdbkXA=; b=GaBM0PszpWYLl/Q0dIiOLBP9sChg+L/aGvBAnr64mLTuYvD1wK2G6aqnuI4sQHzUQD A1XzdBtMb3krSjknDh7qJ6IvVnWN4oXQeLonTYa1SeC/6REnKI0H0U4mI5fsFKSztL6u 5BznQkzBHg2RZVCS+mRtbwAKIwFYoQjlWz9n45EmkQrBvVEcnkmj637Av8amipew+cUv GlYjYRiLmSqkfjB1OrOAKYVjvv2SrRfnFdYOfXrJsU6LLqNO3MAnjFszGeUCclDrckoe LzXxkPmb9ZinNTaT3OxJl6TDRAd3hSpkX8MhGabxqgNEmAPUWVfe1J7fZOoNq3HFjqsc KWvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmPqP9vb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id br19-20020a05620a461300b006bc65379d9fsi640186qkb.144.2022.09.27.03.38.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Sep 2022 03:38:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmPqP9vb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od7yb-0004vZ-FF for patch@linaro.org; Tue, 27 Sep 2022 06:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od7a9-0000tM-FQ for qemu-devel@nongnu.org; Tue, 27 Sep 2022 06:12:53 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:46907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od7a7-0002VZ-OP for qemu-devel@nongnu.org; Tue, 27 Sep 2022 06:12:53 -0400 Received: by mail-wr1-x42f.google.com with SMTP id bk15so6461238wrb.13 for ; Tue, 27 Sep 2022 03:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=mdbZvGlemRTML0U9/q6dutguZkYkpzqfdzZefPdbkXA=; b=CmPqP9vbY+PGpz+U22K2Ul/camvnXkDS+a1pak+dmDNnSZBe+WyD047bdwQ51PDnGe eCuJOyQtIzS75Si8r+aP3krDTDBBeeBUT27Hvn4b9s80qDalbkZroeov5WUW6kfXzEpn YVYAL1xThHWODyay4szCmdncz/qjPMCI27CJBBuZWxbIk8KZBh4xk0m0uB+5wDYQ3bBp FVFjGBwtSkGrryTjPRNrMMgshjbHH8h30YKFOTbyEgPaKkeDjzi+22C4sfIypz+OVAQX fMRPLR/HwghA2y30kzPT23L72d6MRBQ8p147loX8/5AuUCyIo3Kif5qCRU7AOc2wWBo6 LQ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=mdbZvGlemRTML0U9/q6dutguZkYkpzqfdzZefPdbkXA=; b=0ksajEp3R8JXHXYtubsH429bFa02Bd56tZz1SvU/MaMCi1NYpiSD/q7EU1G+Vm7yKe VEigN9HN2UqCf8BmZvpsuGio1rQqgtXGGLZzfVF5Djuygx8NBpllaTW+wSsY5CJcUkEW VENOze3DmvMz7UIeVuKaVyUMatrcIQi1elXF+m3sQn1sXJwa9GOAU1hO/DeGjfEW+rZf XmnpgBki6f7WfBadYczZqUeEflN878BVnyMrpHKh+Dt63omtwWnUscuifB3tA2Xp9yjA uSv7fxrqLpbcyvQYTxMtVuCF/J+TSNRfa/LF47jSQjfICr0uJb4h470qpOScuz8ma7+S ZUwg== X-Gm-Message-State: ACrzQf2LGf76eTtEnZ+vihmBUuuI5ST1KIG6g8PWQSZRujP8i6FoMUvU flPQxpMqSQmMdBU2c2hjVLcjDA== X-Received: by 2002:a5d:49ca:0:b0:22c:bc93:a9b6 with SMTP id t10-20020a5d49ca000000b0022cbc93a9b6mr1643313wrs.10.1664273568980; Tue, 27 Sep 2022 03:12:48 -0700 (PDT) Received: from localhost.localdomain (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id w6-20020adfd4c6000000b00223b8168b15sm1398387wrk.66.2022.09.27.03.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 03:12:48 -0700 (PDT) From: Jean-Philippe Brucker To: peter.maydell@linaro.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, robh+dt@kernel.org, Jean-Philippe Brucker Subject: [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node Date: Tue, 27 Sep 2022 11:03:45 +0100 Message-Id: <20220927100347.176606-5-jean-philippe@linaro.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220927100347.176606-1-jean-philippe@linaro.org> References: <20220927100347.176606-1-jean-philippe@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=jean-philippe@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The node name of the gpio-key devicetree node should be "key-poweroff": gpio-keys: 'poweroff' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' From schema: linux/Documentation/devicetree/bindings/input/gpio-keys.yaml Signed-off-by: Jean-Philippe Brucker Reviewed-by: Eric Auger --- hw/arm/virt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 8605f5058a..6805c57530 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -932,12 +932,12 @@ static void create_gpio_keys(char *fdt, DeviceState *pl061_dev, qemu_fdt_add_subnode(fdt, "/gpio-keys"); qemu_fdt_setprop_string(fdt, "/gpio-keys", "compatible", "gpio-keys"); - qemu_fdt_add_subnode(fdt, "/gpio-keys/poweroff"); - qemu_fdt_setprop_string(fdt, "/gpio-keys/poweroff", + qemu_fdt_add_subnode(fdt, "/gpio-keys/key-poweroff"); + qemu_fdt_setprop_string(fdt, "/gpio-keys/key-poweroff", "label", "GPIO Key Poweroff"); - qemu_fdt_setprop_cell(fdt, "/gpio-keys/poweroff", "linux,code", + qemu_fdt_setprop_cell(fdt, "/gpio-keys/key-poweroff", "linux,code", KEY_POWER); - qemu_fdt_setprop_cells(fdt, "/gpio-keys/poweroff", + qemu_fdt_setprop_cells(fdt, "/gpio-keys/key-poweroff", "gpios", phandle, 3, 0); }