| Message ID | 20220927100347.176606-2-jean-philippe@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/arm/virt: Fix dt-schema warnings | expand |
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > The devicetree specification requires a 'model' property in the root > node. Fix the corresponding dt-validate warning: > > /: 'model' is a required property > From schema: dtschema/schemas/root-node.yaml > > Use the same name for model as for compatible. The specification > recommends that 'compatible' follows the format 'manufacturer,model' and > 'model' follows the format 'manufacturer,model-number'. Since our > 'compatible' doesn't observe this, 'model' doesn't really need to > either. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Hi jean, On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The devicetree specification requires a 'model' property in the root > node. Fix the corresponding dt-validate warning: > > /: 'model' is a required property > From schema: dtschema/schemas/root-node.yaml > > Use the same name for model as for compatible. The specification > recommends that 'compatible' follows the format 'manufacturer,model' and > 'model' follows the format 'manufacturer,model-number'. Since our> 'compatible' doesn't observe this, 'model' doesn't really need to > either. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 1a6480fd2a..83ab1a37fb 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -252,6 +252,7 @@ static void create_fdt(VirtMachineState *vms) > qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt"); > qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2); > qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2); > + qemu_fdt_setprop_string(fdt, "/", "model", "linux,dummy-virt"); > > /* /chosen must exist for load_dtb to fill in necessary properties later */ > qemu_fdt_add_subnode(fdt, "/chosen");
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 1a6480fd2a..83ab1a37fb 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -252,6 +252,7 @@ static void create_fdt(VirtMachineState *vms) qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt"); qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2); qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2); + qemu_fdt_setprop_string(fdt, "/", "model", "linux,dummy-virt"); /* /chosen must exist for load_dtb to fill in necessary properties later */ qemu_fdt_add_subnode(fdt, "/chosen");
The devicetree specification requires a 'model' property in the root node. Fix the corresponding dt-validate warning: /: 'model' is a required property From schema: dtschema/schemas/root-node.yaml Use the same name for model as for compatible. The specification recommends that 'compatible' follows the format 'manufacturer,model' and 'model' follows the format 'manufacturer,model-number'. Since our 'compatible' doesn't observe this, 'model' doesn't really need to either. Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+)