diff mbox series

[PULL,18/30] configure: explicitly set cflags for --disable-pie

Message ID 20220920171533.1098094-19-alex.bennee@linaro.org
State Accepted
Commit abafb64b6dcbdb0ca0943cd04373bd84353ce7ec
Headers show
Series [PULL,01/30] gitlab: reduce targets in cross_user_build_job | expand

Commit Message

Alex Bennée Sept. 20, 2022, 5:15 p.m. UTC 
This is working around current limitation of Meson's handling of
--disable-pie.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220914155950.804707-19-alex.bennee@linaro.org>
diff mbox series

Patch

diff --git a/configure b/configure
index 575dde1c1f..0bbf9d28af 100755
--- a/configure
+++ b/configure
@@ -1382,6 +1382,9 @@  elif test "$pie" = "no"; then
   if compile_prog "-Werror -fno-pie" "-no-pie"; then
     CONFIGURE_CFLAGS="-fno-pie $CONFIGURE_CFLAGS"
     CONFIGURE_LDFLAGS="-no-pie $CONFIGURE_LDFLAGS"
+    # Meson currently only handles pie as a boolean for now so if we have
+    # explicitly disabled PIE we need to extend our cflags because it wont.
+    QEMU_CFLAGS="-fno-pie -no-pie $QEMU_CFLAGS"
   fi
 elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then
   CONFIGURE_CFLAGS="-fPIE -DPIE $CONFIGURE_CFLAGS"