From patchwork Tue Sep 6 08:38:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 602964 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp4343672mae; Tue, 6 Sep 2022 02:04:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR7TPiHMp47K4B9IDXytxw5yq0sBwbmcTo0dGNPUODxSXnTWeeQYp9LzWxQ8sNrtKNkMAbRL X-Received: by 2002:a05:620a:4482:b0:6bb:c315:9597 with SMTP id x2-20020a05620a448200b006bbc3159597mr35251576qkp.423.1662455090454; Tue, 06 Sep 2022 02:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662455090; cv=none; d=google.com; s=arc-20160816; b=IxFQFvWD0P/0ogILdXQUq/r4Vae0Ugos/gPR66RQqDfK5ILIcHlNspIYkDzDo3rR8d DHMIe8uVxlt5rFjrw0KD4GDrbCHtbIo/YsiPI1wC9qM2iauGgVz7GhozEilp6uJXkpnL iS6cr4UgBa1IjwynR3+R6SpGMiO3Lz4mf4+dO1MHc8dGbhJXs7eaqDaRHukTDbglThHv dITsexsq1TIZWQMLYr++oid44EkfRtXdGrKKAKAtd8iz62WKrBWs2Otwi1osURnDN1jI +eMlF1YClO38l+Ftbi7wIHW7B8EaPm7oI7nJn5PjSQqRH59w2T4mJHAigm9ipy6RTq77 QxrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=L6+S1C4verjHBqz/uuyCgreQuy1xnosEZw7oND6E5kE=; b=XWgImiPgK7kUUGM+lhMUwSlFMpa+H4KlLpxp4TzfFEEcUKi3yol4W8TMRnfn1d58Vk v1P9gCuMUiOfOoHSJeKwMhfJWDttkR1lQAfsFjPsha53+v2/LkMvGbpJfm36Xfzlgxur +QdQG7aRGY1mM0YMJgqkydfYYvehau13kUWiCepShWuHlktWJY+SC+HQOoL2d2uNEbCH YbAQWRjedi1JM/H+rgxbLz88ZUgY13NGX2P7bfbDlqAERtIFgxkaFp/YFUJ0InYiZ6qW Qv9BlQ27f+lj/WWxkuuYTDD7COSaA+xTJMhsHcLKSLwalO4urD0t6EDKMrPbZoKjxLx2 iWMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=py4fuwOk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k13-20020a05620a414d00b006bb4eb9510dsi8173965qko.302.2022.09.06.02.04.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Sep 2022 02:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=py4fuwOk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVUVl-0001nW-SM for patch@linaro.org; Tue, 06 Sep 2022 05:04:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVU6P-0002mH-Qi for qemu-devel@nongnu.org; Tue, 06 Sep 2022 04:38:37 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:36854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVU6N-0005UN-1z for qemu-devel@nongnu.org; Tue, 06 Sep 2022 04:38:37 -0400 Received: by mail-wr1-x434.google.com with SMTP id b17so958877wrq.3 for ; Tue, 06 Sep 2022 01:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=L6+S1C4verjHBqz/uuyCgreQuy1xnosEZw7oND6E5kE=; b=py4fuwOk3Eww8ZsdFM971XDyRZTjmxi6/uG+RgzwhD5Y4GvZ1N0CfOYROs576LaC1n Yt8Id4NezKVSXmcBoTfDuRnWU6YP5NHqj8JObkTEE4xid5F1NMHHixXAwqOH6yckoJGY Mwnl6PahBumBoyHh4raLrV9GEVctgjF4CAprVwJWvpLf6demCmup6eMMlJabSyW19sQ8 1GnWt0Tw8TnSQ1lhgoCyqu6gwHFalNXJemg3vgo3g59Ixb+OdYUE1yqUE6r/m+xhgGkn 0hbuPNugZdxa0ls9GJmZNfI/Cm6R/fdZkt5Bqx4jOrY7DPr8+9/Lv+rP3rz5+MyPZ6FH +IVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=L6+S1C4verjHBqz/uuyCgreQuy1xnosEZw7oND6E5kE=; b=2XxtGvzGE3cuzhg7xgoHIxg3J+JXrztejo9Vq4cTAO6NyMDhIZecAdmmwOu8gu3jvs Butov/MJv6RYBUfc+anT/sbwWX57eGuSIfsYWlTVr64vGMxlT/0RoHlrUkc5ugTfnnAN jLxCzHWSmGM9AX49sT5I3R41FcnDaKcvYegeKz0tO+bmqBHDFHnkRQA6+T4LNCEhuOV5 zX1jA8e2zIeqO70vrnXLL7VO8nh4cKMeMokqFihguJXwv7bmkb9hm0GDjtwUjYq3XCHx D1JPsDFDOsfnO1kfieau3QW//ucQRyC7QUkieaQN6ESANeC+I1Lq1zs1Ry0p6iRZ5BIM gzVg== X-Gm-Message-State: ACgBeo3DkmGPfnzBlglPvAO1/WbRv7NC7fgiEsDsa+kB7B2ACHxw60bi 5dgAE1rve8OvvRcjIhjJzw4ppilItKVzmsHm X-Received: by 2002:a5d:584f:0:b0:226:edcd:b467 with SMTP id i15-20020a5d584f000000b00226edcdb467mr15281518wrf.363.1662453514337; Tue, 06 Sep 2022 01:38:34 -0700 (PDT) Received: from localhost.localdomain ([2a02:8084:a5c0:5a80:ba98:3a71:8524:e0b1]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003a54f49c1c8sm13421859wmk.12.2022.09.06.01.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 01:38:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, Alistair Francis , Ilya Leoshkevich Subject: [PULL v3 14/20] accel/tcg: Remove translator_ldsw Date: Tue, 6 Sep 2022 09:38:09 +0100 Message-Id: <20220906083815.252478-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220906083815.252478-1-richard.henderson@linaro.org> References: <20220906083815.252478-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The only user can easily use translator_lduw and adjust the type to signed during the return. Reviewed-by: Alistair Francis Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Signed-off-by: Richard Henderson --- include/exec/translator.h | 1 - target/i386/tcg/translate.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index 0d0bf3a31e..45b9268ca4 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -178,7 +178,6 @@ bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest); #define FOR_EACH_TRANSLATOR_LD(F) \ F(translator_ldub, uint8_t, cpu_ldub_code, /* no swap */) \ - F(translator_ldsw, int16_t, cpu_ldsw_code, bswap16) \ F(translator_lduw, uint16_t, cpu_lduw_code, bswap16) \ F(translator_ldl, uint32_t, cpu_ldl_code, bswap32) \ F(translator_ldq, uint64_t, cpu_ldq_code, bswap64) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index fc081e6ad6..983439d926 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2033,7 +2033,7 @@ static inline uint8_t x86_ldub_code(CPUX86State *env, DisasContext *s) static inline int16_t x86_ldsw_code(CPUX86State *env, DisasContext *s) { - return translator_ldsw(env, &s->base, advance_pc(env, s, 2)); + return translator_lduw(env, &s->base, advance_pc(env, s, 2)); } static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s)