From patchwork Thu Sep 1 06:52:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 601807 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp264412mae; Thu, 1 Sep 2022 00:29:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Sjx26EPYXvOEVbgtUavuOFEhJsh782LVAZ+2zPjzzxmy9EzvCqHy2k24vvVWUBIUGK8jt X-Received: by 2002:a05:622a:1819:b0:343:618c:319e with SMTP id t25-20020a05622a181900b00343618c319emr22256526qtc.274.1662017373592; Thu, 01 Sep 2022 00:29:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662017373; cv=none; d=google.com; s=arc-20160816; b=aykrueB1ddUDP++bU6uS+OSJ3jXpgkgaiJmQIc9/AZfjR952faoguWmAZf3LpDT1Nf nrSrS17u2b+FA4//IX2prbxOIlCig2HlIf8V6ZCP8RXTSnIWHkAxIiGJTmtwxudLmZfR rzfwmylytYN6O8RN7FzKYVcrCF9rxlUiRxJbOI0I1blLYBCo/WpepnnNdwRXbZukRi/H gvsBbEXwmOhSjqP5WMBdt4caZS+SLsBusY8pIP/DebBYdEHXkn0mFiD41x/sgZXdkrSV qrm5p6nN0o81CmNiAAXz9tFfT1uYsOzLBoPWg+iOVB7UrPTFVHtK3SHuv2DRRTnjYbZS eIDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tnbTpQq25hji2Az9vsRCegPM/IihGJTki2qN0gANa1Q=; b=zk5/gjfoJbj+Ft9v6jdjOXyna8CCNFv5Rl9k63GaEfPndr5YKc5AiKIhrpPa84YK6v R/3QlIbngBgjheavBJcwsjrom8hV6RI41ft/jIyNaA3JwB0/drIrxeUdq6nNlP7uCX+2 3z1s+WQx2By57Cmhq2F3tRfulDD379Sj99zlEHUl/JueAZKupcMBuecA2m/f2EIDrVWj r0TfhW6nEOmwgbOHU+mW49+6lJxJPFgKZ5V3gvFSGTtTVO62wCg87Y18KzicLNqz+XIH qSc77E9mEKzb129xwOmAftHmOqXaGiZT/e1RO0WI2ZYARJPC+5dgZRIpGv4ahOhX91bY RitQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rHXVCrIW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w10-20020ac87e8a000000b0034301eb5c75si11098912qtj.35.2022.09.01.00.29.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Sep 2022 00:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rHXVCrIW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTedp-000575-3y for patch@linaro.org; Thu, 01 Sep 2022 03:29:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTe4c-0006C7-2R for qemu-devel@nongnu.org; Thu, 01 Sep 2022 02:53:10 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:45914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTe4a-0003G2-8D for qemu-devel@nongnu.org; Thu, 01 Sep 2022 02:53:09 -0400 Received: by mail-wr1-x42e.google.com with SMTP id w5so4832845wrn.12 for ; Wed, 31 Aug 2022 23:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=tnbTpQq25hji2Az9vsRCegPM/IihGJTki2qN0gANa1Q=; b=rHXVCrIWx+7kRVBtQUoAF1+HTtZuswSb5YAK7yOGPzsljae6cena2xzVg7XREthmsk LcPfujecr1D5nMMbHyZjctjdrPxqegE2hbGBekxTUo4n/VmDizSRM/SJu2Pn2JE6KIsU ueUFqTpAY6UV9f7x3j3zmQh/O+tNkBcWeBZtMUoh6zScyVbO0TeO+NIMexkBDWTGU5uV ++6ZyIk4wS1kcxlxCOO4FWgi88STKDWwkuoriotUpnkc2MZv97Y1D2IX8UqAW8XF3B8q jCbE5/EH4jd++9Eb846zyaQ5MtsEWEaf9dUwUReq/31BMmrXZu5PeLztlxIJFIaMkM4T 3jyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=tnbTpQq25hji2Az9vsRCegPM/IihGJTki2qN0gANa1Q=; b=WbWTYdJTw8HVQs2QdFoNXPiy5ooTlaT+LXA9N42rdo12MQkTqhFXS4sVr/DYKhdJR6 /3eLpPGTqz/cuNyg/MP0Js/kMGcjPZNGw2dtmAco/Px5lsg4JCJnCFNsE9sBDU3yaPdY d2C4sXk3VWwwi6k/9gDpc1YRnsAbLmxgGlbFWrCTeBQBUt7s6nhK8P4jhsDI4SkHTy1M R8pmAkH9A533OnKEQ4qdZELIFUTLbUNqB6OuKGeGs2Nu9MSqWOuwdc8dcuGNzFvRxbR3 mggLxhL+TqDE5pJPB5O74env0KORhVB/K50hkqsJqQZQLK9PaOEYy3pvS/Udrwke4Wj/ u4TQ== X-Gm-Message-State: ACgBeo0Ov8zOC4Gvef8pEVhGyTJEy0/wEramFCbi+khScCqH5UzQGAL3 hTJMErdPqyWHORYV4y6zqW2XakVgTupuhnK7 X-Received: by 2002:adf:d1c2:0:b0:226:fa44:bab7 with SMTP id b2-20020adfd1c2000000b00226fa44bab7mr346482wrd.195.1662015187547; Wed, 31 Aug 2022 23:53:07 -0700 (PDT) Received: from stoup.. ([87.192.221.83]) by smtp.gmail.com with ESMTPSA id a6-20020a5d4d46000000b00226dedf1ab7sm8308153wru.76.2022.08.31.23.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 23:53:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Alistair Francis , Ilya Leoshkevich Subject: [PULL 14/20] accel/tcg: Remove translator_ldsw Date: Thu, 1 Sep 2022 07:52:04 +0100 Message-Id: <20220901065210.117081-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220901065210.117081-1-richard.henderson@linaro.org> References: <20220901065210.117081-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The only user can easily use translator_lduw and adjust the type to signed during the return. Reviewed-by: Alistair Francis Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Signed-off-by: Richard Henderson --- include/exec/translator.h | 1 - target/i386/tcg/translate.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index 0d0bf3a31e..45b9268ca4 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -178,7 +178,6 @@ bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest); #define FOR_EACH_TRANSLATOR_LD(F) \ F(translator_ldub, uint8_t, cpu_ldub_code, /* no swap */) \ - F(translator_ldsw, int16_t, cpu_ldsw_code, bswap16) \ F(translator_lduw, uint16_t, cpu_lduw_code, bswap16) \ F(translator_ldl, uint32_t, cpu_ldl_code, bswap32) \ F(translator_ldq, uint64_t, cpu_ldq_code, bswap64) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index b7972f0ff5..a23417d058 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2033,7 +2033,7 @@ static inline uint8_t x86_ldub_code(CPUX86State *env, DisasContext *s) static inline int16_t x86_ldsw_code(CPUX86State *env, DisasContext *s) { - return translator_ldsw(env, &s->base, advance_pc(env, s, 2)); + return translator_lduw(env, &s->base, advance_pc(env, s, 2)); } static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s)