From patchwork Thu Aug 25 15:07:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599970 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp356690mae; Thu, 25 Aug 2022 08:12:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ZV32JlwAraehueDQ64ZKxnzVmep3syn8CtZNpnwUqfSXmAGfeFPVSQ620xrNBv0NXa8ey X-Received: by 2002:ac8:4e87:0:b0:343:6249:1810 with SMTP id 7-20020ac84e87000000b0034362491810mr4029749qtp.117.1661440326787; Thu, 25 Aug 2022 08:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440326; cv=none; d=google.com; s=arc-20160816; b=sb262retjIIisMcoM5jIrgH7G4H8ybYW1HB7yBaVd4Q+fPBeQR1gvYjwo5dlwuuP2W Hnl0llKTYo99cYsqCUvIAbr+2YZH+CzYBynIfbQkCAepgdtcDglAbVqqNf4e0OiG3y1B 41uCmtnGaxQWOCj2R141vKvY1ReWxUVlbTSvVy5HJOBQNBWacuzeaJTsgstsecB7LNqr /5Iq4jclf2iK/s/ZC5PkCB18Xw22KozAhYE+9P2j9/jZJSzc6YCHiEKNiacY8bzX5Grr uA7o0HMHzIWKXKRRP4BIx2Q4CUtbo7SwQ2IzDW43oKeKxG1zYnJbphAxd4X9G/S4FUv3 tK8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=gfzBkvKduEMFGr20IRUSeBlVG1QRzWpQAykxC9X/YJ4WEshU4ZQb0x5BWhkWA3FdlL DaFH++ZQ7rNCflh89HqcXmZuETEEn/MPyJT9JPjskp11ECWlfNblaUddwp5kPrFyJCje j3+fGWRcAR5yOmWT9Tb89ukHXHL9ZFo/KljxroP1t1yT9C45t7edSS9MwGepo8BvnrA/ lJpQAGVwMoTJnnj3qOPdMSv428Igp87aDYb+Gp6NiK445/gTehOrhtLcOODPuXF4tVQd vzRavSLj6NUI1MTAqT+Im/aUNMk9sThtj7mULfhwn+UJwIegVE2YcvHu5J0cxsphiEEt 3gzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mlFGuZ5O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p17-20020a05622a13d100b003435f7b3ceasi11386819qtk.197.2022.08.25.08.12.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:12:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mlFGuZ5O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREWc-0001Hm-CO for patch@linaro.org; Thu, 25 Aug 2022 11:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERu-000410-JF for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERs-0002M4-W7 for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n17so392278wrm.4 for ; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=mlFGuZ5OjV2RVek6i01ZKdY8nX6XEU1A/hnnZkSNI/PLwUzz7F6jbGKU4VzilrjCXD ySGTTC5vnst6KrXbO6ZNsZLKQC7r7adpswLbV5JzyVZESOnX5MB/GJexe9Dk7g4BDNxy m226L6htJLAoCHCO7VTMT1kiBaZsWMMUK/T8Yp98EC6q7MqKQ2Lq/9YT842EsNGhYdVQ /DENxN7VKrKxf+e6/u4XCZ6cFW0TObBMHoBXWnmHC3V8wLwuJxSAkvyxfHDaQV7YvQ6z z13eyGueNq3TNuW0GmRuV58yXI6ksRkifGNvr+MRz9nAywtlhWYu4ExmjLbeFM13He/m e11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=BdVVjW/u7nsDote/ypRJ9pYhlj6Bpev2nTnGxZ8xmjVEhrp+ZlYYPDrfhEMZ15f/aS N7N/YnBR/c8Vko5D/cCTXRsp6lo+u1OtWnIaLVMBdrGy7ZjHhlbWj9MEYMGgoa4cx8jP Ey7R6O/AqVuaciLRoYt340uqYZf/434HGI3EIHr/QLjvj8OQL6IbvXvloSLkAgpJpCYT 9c/GqMBR/gPEkVDiJNN3l7KSXq6XI5toQ/t7c5/XDS7lZJ5K9G/o0BKfomwt3ev4lcxD gImpkkCXfKBWmfww3UevAt6VGvkz+0QPUdvkZseqy6FYgkxHW2q0Vpoh7djs1KQpZpuL PSQA== X-Gm-Message-State: ACgBeo24dL0H0Pklpuv3KSx3M692IEgOoMq3mWDxruEKlc2wmAzCZ/x5 oI/R/D1TdqCgouHltmh1YUE6nkWN0eyIAg== X-Received: by 2002:a5d:49c6:0:b0:225:61c9:dd4e with SMTP id t6-20020a5d49c6000000b0022561c9dd4emr2480862wrs.445.1661440032138; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 7/7] configure: Avoid use of 'local' as it is non-POSIX Date: Thu, 25 Aug 2022 16:07:03 +0100 Message-Id: <20220825150703.4074125-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We use the non-POSIX 'local' keyword in just two places in configure; rewrite to avoid it. In do_compiler(), just drop the 'local' keyword. The variable 'compiler' is only used elsewhere in the do_compiler_werror() function, which already uses the variable as a normal non-local one. In probe_target_compiler(), $try and $t are both local; make them normal variables and use a more obviously distinct variable name for $t. Signed-off-by: Peter Maydell --- configure | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index f8d7270a60e..f2f793e3653 100755 --- a/configure +++ b/configure @@ -110,7 +110,7 @@ error_exit() { do_compiler() { # Run the compiler, capturing its output to the log. First argument # is compiler binary to execute. - local compiler="$1" + compiler="$1" shift if test -n "$BASH_VERSION"; then eval ' echo >>config.log " @@ -2071,7 +2071,6 @@ probe_target_compiler() { : ${container_cross_strip:=${container_cross_prefix}strip} done - local t try try=cross case "$target_arch:$cpu" in aarch64_be:aarch64 | \ @@ -2084,8 +2083,8 @@ probe_target_compiler() { try='native cross' ;; esac eval "target_cflags=\${cross_cc_cflags_$target_arch}" - for t in $try; do - case $t in + for thistry in $try; do + case $thistry in native) target_cc=$cc target_ccas=$ccas