From patchwork Tue Aug 16 20:33:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 597531 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:b345:0:0:0:0 with SMTP id w5csp2715823maz; Tue, 16 Aug 2022 14:14:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR6dDUU010r50HwXlS6oG06pQKwwIVmDE4Vnvq4+/maANnNWcbsUrMKE32vw5Plutn85EQYu X-Received: by 2002:ac8:7d90:0:b0:326:b431:6cd3 with SMTP id c16-20020ac87d90000000b00326b4316cd3mr19907614qtd.511.1660684452655; Tue, 16 Aug 2022 14:14:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660684452; cv=none; d=google.com; s=arc-20160816; b=qqTsFuR4f196PbKeIHaQBq2r0HG/pqLOc3Vk53yz1EmEtMnC1e+MBdcIrbzI8xepT7 e2VFVpOdR+yXJPd0UuVp6Rc2cRIUV3umc+1P34w8KbYX4fIk8JTk3YEIytnIG9hAmuCl 2Wq2CVFAfGMGA23ORyfrXo6FXkSk3agc9b1TizwVrBaqXoicvtKelonPcAJ4nzMVHRZB GgJRPl1RyPdTZHMMDW7F5SAJ9DQVFf2EpphFlNHRGrPquj1POSNYOlZeL0H4ZIYfoTrv 1vOIRBSD6AozqWghL6Vx8A4h1twdE1xekn68fJzSC6HBCt6OEAreLfBHLnV06B4NbMhW wfQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3ScK9gYYd7Yu/4MmJJp6WEZrowwZuhBtdiXOVA7xdaE=; b=fZUWrQSNXELvBPUbgNtKEsC0GG81oqMelaexjOtFYVyxbY4xhLCJjlcyZPguoGAb/I HpcXNuCa8oOX9LdWJI6lPcgoiFJin20FIl//PQ32uMKI1xxYw3bQu8VXho71mSNtFl/V qkt2E6yCFE23GwUqFUxq4PZzxEQWqI4W/WUWGDw1Q8qnZ7SPpwUfQEu8kF+F4h2MrrHM jtAVL1kisj025N07ZKWA2OTa/BCeNYsjW/0WHddGVBBheGJbQekJP19wEB8yLqZLft4b D5H++/W6oT47DsshpzcjJwarQ+lZCdcN66ezl9kSu5LRvzTgN/IopAH0keK86L2f/8ym 5Mdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sKFnk2U4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k20-20020a05620a415400b006bb85bc9d1asi704395qko.231.2022.08.16.14.14.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Aug 2022 14:14:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sKFnk2U4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO3t6-00080a-6n for patch@linaro.org; Tue, 16 Aug 2022 17:14:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO3H8-00059Z-Vj for qemu-devel@nongnu.org; Tue, 16 Aug 2022 16:34:59 -0400 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]:40600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO3H1-0004au-4k for qemu-devel@nongnu.org; Tue, 16 Aug 2022 16:34:58 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-10ea7d8fbf7so12927468fac.7 for ; Tue, 16 Aug 2022 13:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=3ScK9gYYd7Yu/4MmJJp6WEZrowwZuhBtdiXOVA7xdaE=; b=sKFnk2U42+arEPTPyQUqCdP2C2tK0Ga35UD58mGl02wfr2GqzCDBPyS1PDMaGybbou 9ID6WdoP/FqXFLxTuK38MjBvlM33h0/kivxnCxHPsz8ujEayYWeb5gZmgkky/Z3XLmLW xQFI6wm8Cmay3uZ1vtaw3WSQHGTbzS5rGZzNNlhAgzUeWtihAA9IAIoWxnwrarpKn1j7 thStVklcEUTTaD1Cz+ovziHSBoIN+AlTyrVfOlGyDeQqFYXhKVEgQVBgODqTOTnBM/ZP 3HZ+RXqPugrIWL5FmZrGH/YHxWIQnTP8JnDcKPvC5yUrWgbugz9wVpyGRv1gp5uf5ow9 OI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=3ScK9gYYd7Yu/4MmJJp6WEZrowwZuhBtdiXOVA7xdaE=; b=HH67bCILIvFU+6h6YR9n5qv/dwSKKVLD2RdrVqchOByULuB1aQkoaXg7TosYGaJw0l 14itIOkJE6gcOLOEORiGr2Zn1DAyt5EASGyeNNzqfWcm7nUs0eO9YZ52kvbEWUUNh8A0 bEi/MrJc7WYsAeQiOfbxQOZ+t/wMk+w3MPSQk1ICSyhRIm44Z7cg1KGJRhBPkLXH6x+h pfxKEAk7foe+Z9m5yVwYpJkm4RmT+dpfjdORmdH1413gW/0v18r2HJeg6ZlB5bBUJxGl WSvMPalVfsrPOgWzoP1QyJeYlCs/HnkRf/nORqnlXmrWWQH7fOvqBhUqWh5TKi7zhuGU xkMQ== X-Gm-Message-State: ACgBeo1e8bH8kKqpAtVvuT6++e/58TulpYePCGtR3W7U7FRUdKPmymfi i7q/VyK6yyGtFNpmNXxJqwwHz8P4rf1uRQ== X-Received: by 2002:a05:6870:5809:b0:101:ce10:b267 with SMTP id r9-20020a056870580900b00101ce10b267mr146813oap.83.1660682082602; Tue, 16 Aug 2022 13:34:42 -0700 (PDT) Received: from stoup.. ([2605:ef80:80f6:61fa:9bc2:5095:d612:5e22]) by smtp.gmail.com with ESMTPSA id y23-20020a056870b01700b0010ef8ccde67sm2285220oae.13.2022.08.16.13.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:34:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, iii@linux.ibm.com Subject: [PATCH v2 16/33] accel/tcg: Remove translator_ldsw Date: Tue, 16 Aug 2022 15:33:43 -0500 Message-Id: <20220816203400.161187-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816203400.161187-1-richard.henderson@linaro.org> References: <20220816203400.161187-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The only user can easily use translator_lduw and adjust the type to signed during the return. Signed-off-by: Richard Henderson --- include/exec/translator.h | 1 - target/i386/tcg/translate.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index 0d0bf3a31e..45b9268ca4 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -178,7 +178,6 @@ bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest); #define FOR_EACH_TRANSLATOR_LD(F) \ F(translator_ldub, uint8_t, cpu_ldub_code, /* no swap */) \ - F(translator_ldsw, int16_t, cpu_ldsw_code, bswap16) \ F(translator_lduw, uint16_t, cpu_lduw_code, bswap16) \ F(translator_ldl, uint32_t, cpu_ldl_code, bswap32) \ F(translator_ldq, uint64_t, cpu_ldq_code, bswap64) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index b7972f0ff5..a23417d058 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2033,7 +2033,7 @@ static inline uint8_t x86_ldub_code(CPUX86State *env, DisasContext *s) static inline int16_t x86_ldsw_code(CPUX86State *env, DisasContext *s) { - return translator_ldsw(env, &s->base, advance_pc(env, s, 2)); + return translator_lduw(env, &s->base, advance_pc(env, s, 2)); } static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s)