From patchwork Mon Jul 18 13:59:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591471 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp3066145max; Mon, 18 Jul 2022 07:34:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tkaSoxuxPRg2WFejtdnMWYXkkJZ6xZAfHvT7P+LRgGY53oazHi7EeHjhkKDqcIzVpGQO7Q X-Received: by 2002:a05:620a:2181:b0:6b5:e0a3:21a9 with SMTP id g1-20020a05620a218100b006b5e0a321a9mr5541631qka.388.1658154869666; Mon, 18 Jul 2022 07:34:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658154869; cv=none; d=google.com; s=arc-20160816; b=ZQNVQ8hcKzqQqAm2K7PCyUMI+kclypIEset9pNKhCsSrhKyKIMhF9ql2SEP6FWxl7O yZzb9h12Oj7L+MyziMK11C4eXSMUPk0fRynHVLGdvtW8RtFjE0AAJsTON4IbTWxzpyMr teK0NHjpnhEA9cV8JW6Um5SvOpEHalng8/SqARC+/G/rFyoony7zyCqIzB/aUJIyMixh rPXZVr78Xxnwcr4M7MkR/9+uEvk7GLn0nJQQYUnH0w4IYY4rDMQOC2SyQfbQxrHslB/o a+4ORwRmh7uO2OiNxyxw39XUWHjzOS9Z2U3e8LL9ZBixJmcI3nG9D9Hwqn/YmLrz9kJZ qpjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=WLcuE5tjCtEqKCJRkl1tlMmWsSxVcZNfqF25uGydMws=; b=IxU5G5kqAHfmy5bgBhpd8EB2GfReuay4AZjQN3vnQEPdRjJXuipc8RNgU/lIlEwX+B Yx6gILwkJYtnkwIUN5lUFtrEljKn9ii1VClAm8u+TJ+pMJmaR210Qazum7ubCD+kTFwq T5nMs65c5KnODbM/nGxcQMm/pP5LpMnSZM1+AeTYzxrEKK10hyiDOjUcE4NkEvgNSh1G s8lgt8XSNSBKPCzd3TfN2R/SH4q1uAZTn985zhaDaQepvvHyqv+Ca0L69LRkJX34sOjn h9o9NDlbXdmx8Ee4VyjUma2O0vDRgAjUnsXjr+F+JTMJnMBwGiTAiS1ZfZJIM62jT0q/ OFCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fYKyNHXS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ay13-20020a05620a178d00b006b5f9b7ac84si226701qkb.365.2022.07.18.07.34.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jul 2022 07:34:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fYKyNHXS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDRpN-0008Ke-8R for patch@linaro.org; Mon, 18 Jul 2022 10:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDRHg-0002Aa-2z for qemu-devel@nongnu.org; Mon, 18 Jul 2022 09:59:40 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:46668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDRHc-0003BN-K0 for qemu-devel@nongnu.org; Mon, 18 Jul 2022 09:59:39 -0400 Received: by mail-wm1-x334.google.com with SMTP id h14-20020a1ccc0e000000b0039eff745c53so7383727wmb.5 for ; Mon, 18 Jul 2022 06:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=WLcuE5tjCtEqKCJRkl1tlMmWsSxVcZNfqF25uGydMws=; b=fYKyNHXSBBvyuI4ylw/1BSjyAcT/gtUPYB0/eyxTj4WTnjemB3qyMzif1Ckd8nQQ/S wOItfR1R1Jcyn9RuaFCpqRI0isZpuyvc0nugCgGn5W2wN7dsAJ8vTgcM2lhSrXhOfhJQ +uoo3b7WlJ5npBbnlDtmkYhuoyHjFFetYVijsY+7JFyj+cOEqCPMAQAXTtSI0/ZICROx b9QNd10LIA2fvyZJJTCLuyAEFFvL10MeQoDuSAqwc4w5utrCqIdNcr2iH7bvAK1FwqkE u2e4LuKi6Y28Jc90WOXn6GCj1QPMthin1YdmjCwYKQqUrLAOehn48wMctMlxcRY50NIo idOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WLcuE5tjCtEqKCJRkl1tlMmWsSxVcZNfqF25uGydMws=; b=6pLsrs7NSpE/CP8Ld795DsdGwlN+te22ZAfya+HuQcnMELbimE8ynXDa0T12/zOFjG x8IdIVhY+uWBgGJ0QeQx2f7V214HUFp5BYilGTcwfniNLK31vdGMUeDsCva16Qh3jPwR 7VQnXyMkMPMcrHDDCtzYeCJlVR/NXT8fdcMvRRPCAUERqmRnfnREgTDElDcR3Fe2Klcz ZH6y8AaClG6x+SrfN/Bsic5mIyFaeVYHESz/Ckngf1F7xRg5+g7KW2anh6xpA/tzg7v/ aLiQvmmjZLCPaH8Mdnjw1LvpdAQUvjNT+gB+nhd/nFO/hbvrj5qMJl+KM0A3BqeJpx6Z Tahg== X-Gm-Message-State: AJIora/4RUpXtFOi9tteR/PKDn9Jys9xKHYSBD1S4mcBFPUHWeAod6G+ oPqQ4pwNPcqBnc3EkzTGguGzqdhxSxjG3g== X-Received: by 2002:a05:600c:3786:b0:3a3:19d4:293f with SMTP id o6-20020a05600c378600b003a319d4293fmr5745802wmr.116.1658152773460; Mon, 18 Jul 2022 06:59:33 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id id15-20020a05600ca18f00b003a31f1edfa7sm1805798wmb.41.2022.07.18.06.59.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 06:59:33 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 13/15] hw/adc: Make adci[*] R/W in NPCM7XX ADC Date: Mon, 18 Jul 2022 14:59:18 +0100 Message-Id: <20220718135920.13667-14-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220718135920.13667-1-peter.maydell@linaro.org> References: <20220718135920.13667-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Hao Wu Our sensor test requires both reading and writing from a sensor's QOM property. So we need to make the input of ADC module R/W instead of write only for that to work. Signed-off-by: Hao Wu Reviewed-by: Titus Rwantare Reviewed-by: Peter Maydell Message-id: 20220714182836.89602-5-wuhaotsh@google.com Signed-off-by: Peter Maydell --- hw/adc/npcm7xx_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/adc/npcm7xx_adc.c b/hw/adc/npcm7xx_adc.c index 47fb9e5f74c..bc6f3f55e64 100644 --- a/hw/adc/npcm7xx_adc.c +++ b/hw/adc/npcm7xx_adc.c @@ -242,7 +242,7 @@ static void npcm7xx_adc_init(Object *obj) for (i = 0; i < NPCM7XX_ADC_NUM_INPUTS; ++i) { object_property_add_uint32_ptr(obj, "adci[*]", - &s->adci[i], OBJ_PROP_FLAG_WRITE); + &s->adci[i], OBJ_PROP_FLAG_READWRITE); } object_property_add_uint32_ptr(obj, "vref", &s->vref, OBJ_PROP_FLAG_WRITE);