From patchwork Mon Jul 11 13:57:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 589356 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:bb16:0:0:0:0 with SMTP id jd22csp3280068mab; Mon, 11 Jul 2022 07:08:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tGOnt1rMlITV98LqVijcm45DL9Nc7OZvkfVJFycvYfKDA/WBhqVc2gOIq4NPiroyWk7M42 X-Received: by 2002:a37:9f49:0:b0:6b5:6fcf:778 with SMTP id i70-20020a379f49000000b006b56fcf0778mr8128621qke.322.1657548526028; Mon, 11 Jul 2022 07:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657548526; cv=none; d=google.com; s=arc-20160816; b=RnYdcvgh9U1va2eg9FdidZDwyVE0uE0Ig92V/9uMN+1IUFhvVAW3p03VbV/SJ0lj4O ZVH25iwoVlxMyj2qGU2amxxCzOvK55FtrRIPKm926CnsiMzhpTqKbCBVjfZQcl5TpjGM Yp6B2stYvoSTwcXNxcCk8MGGVGLTbVNMDyIoAIPfk2Y1GYpgAlophrhJ1++YRzxHDuSj Quu6TibQEroKh7I9p9eY9gvDnUBrOsva0JOpnbJlgFuCk96CzTmUJzly80V9Hx+GbL19 qd0tW+c6oxP04lK970XD0TfHsXIT6fwPOcJiOttcE7MRowIrAYaxgX95rJtLs/YLu+F/ buqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=I1g46N7GyifDhLvrgy885389BGvUDqIbWCLHK1RD3mA=; b=gSiwqVqRi+bNURCc1f4DdQDwODNCPXSs8wAqUCwUeUySsbCgYz+/sdthL9O+TkPEaH y9DiuEqRNEqQ0URibtyDbXI+Dui+0fcXM6JPMJnH9DS6H2Vgm+tBbcstgCtxugK+BKKm +pVzKsAyEcU0kErn1DinqUZMJRzkzbWv2v6H436+Y2fzheO3Y9lzW0y7Ko/pY9BFUQKV 3Og2ad/W8O17vbPDGoMx0DQPpn89mFhBHknKx7xMNHNtFdh4QEE18ryuJj8Y2lDcLUcM MDXQAyreZAhb2v6MkZ79olHYGRdqmldkLmKGhAkR4HPBZBsXUs5I9a7V9eEUZ7cvn53r 56gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N23zhAuy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id cn15-20020a05622a248f00b0031ebaaf876fsi297309qtb.711.2022.07.11.07.08.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jul 2022 07:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N23zhAuy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAu5d-0003Lx-HN for patch@linaro.org; Mon, 11 Jul 2022 10:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAtvQ-0006V8-JQ for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:13 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:54928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAtvC-0002o9-Rm for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:02 -0400 Received: by mail-wm1-x330.google.com with SMTP id n185so3088480wmn.4 for ; Mon, 11 Jul 2022 06:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=I1g46N7GyifDhLvrgy885389BGvUDqIbWCLHK1RD3mA=; b=N23zhAuyXsmgoib6tFw8RZLpnxSyNjsKwQG81qPbz3ilmFBiOtfz3nZPUnMYTyYR5l URoU5E4OsLv47qwtsXgNrH6u8lMRvxn73NXxyfcpeUKAp/0hf4Sai9/tjV3BpgxwL7oW LA483TsUKrAoGQ4eyo+NfhArRMgrFwsHybm3WupsVuP7IVobN23S2xxMTxtHRhSBxpRn a+f0bJr79SjZ2kj91H9y0kG4XACdugLkoGAjcmazcDkYF6dyFmkEXZBu0fQ/ms3Mhzhf cAeTXzisPS5ovuzusPTRU693H2AyvAlQ0CK/KVsz0HmXblZTl5UIAOlvpzVMHjV3A59U 3oLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I1g46N7GyifDhLvrgy885389BGvUDqIbWCLHK1RD3mA=; b=oe0AoE/AIe3lzthKvCg8iDUL5Dl20D4QFtjNqvZ8IzBebVEgOIg1zYfMXwGFgcM6sO 5S7b+/giiWjXZYni1Ked8YSMnCSExdW3RaExbg2+L/UNj8xd+gRDEDyvZqWvPYyZpCiU 9D4pzDR6cezcN55nmOCW7b+iURKuGhVyp9Ggpm107Mjf50SmgaDIBgEbcSnMKH/C3vGp H1T1px+tcOGr4nOEjRxjZoiLx3zxl2Afecv/4jfc2Zr75vZ5ji0xXj9bjiO7Q+1ALYBk o0OfgIbYW+YnMWwdOrydtpd6pMcZKo1redipEr1XAC3VhbGRg6O3kEGNpigEDT6+S30I SZ3Q== X-Gm-Message-State: AJIora+b8ZSPtvzvKlv0jTHQpsu+FKqA7m4afbkbmdqhPwcGshjVCWB2 Fte2N2NO8UJ9z582JqSaTCgLtecyRDRpGQ== X-Received: by 2002:a05:600c:3491:b0:3a0:4d4a:2e2d with SMTP id a17-20020a05600c349100b003a04d4a2e2dmr16579351wmq.4.1657547877467; Mon, 11 Jul 2022 06:57:57 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q123-20020a1c4381000000b00397402ae674sm7595596wma.11.2022.07.11.06.57.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 06:57:57 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 06/45] target/arm: Mark BDEP, BEXT, BGRP, COMPACT, FEXPA, FTSSEL as non-streaming Date: Mon, 11 Jul 2022 14:57:11 +0100 Message-Id: <20220711135750.765803-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220711135750.765803-1-peter.maydell@linaro.org> References: <20220711135750.765803-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Mark these as a non-streaming instructions, which should trap if full a64 support is not enabled in streaming mode. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20220708151540.18136-7-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/sme-fa64.decode | 3 --- target/arm/translate-sve.c | 22 ++++++++++++---------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode index fa2b5cbf1a3..4f515939d9c 100644 --- a/target/arm/sme-fa64.decode +++ b/target/arm/sme-fa64.decode @@ -59,9 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS # --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset) # --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm) -FAIL 0000 0100 --1- ---- 1011 -0-- ---- ---- # FTSSEL, FEXPA -FAIL 0000 0101 --10 0001 100- ---- ---- ---- # COMPACT -FAIL 0100 0101 --0- ---- 1011 ---- ---- ---- # BDEP, BEXT, BGRP FAIL 0100 0101 000- ---- 0110 1--- ---- ---- # PMULLB, PMULLT (128b result) FAIL 0110 0100 --1- ---- 1110 01-- ---- ---- # FMMLA, BFMMLA FAIL 0110 0101 --0- ---- 0000 11-- ---- ---- # FTSMUL diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index d6faec15fe9..ae48040aa4c 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -1333,14 +1333,15 @@ static gen_helper_gvec_2 * const fexpa_fns[4] = { NULL, gen_helper_sve_fexpa_h, gen_helper_sve_fexpa_s, gen_helper_sve_fexpa_d, }; -TRANS_FEAT(FEXPA, aa64_sve, gen_gvec_ool_zz, - fexpa_fns[a->esz], a->rd, a->rn, 0) +TRANS_FEAT_NONSTREAMING(FEXPA, aa64_sve, gen_gvec_ool_zz, + fexpa_fns[a->esz], a->rd, a->rn, 0) static gen_helper_gvec_3 * const ftssel_fns[4] = { NULL, gen_helper_sve_ftssel_h, gen_helper_sve_ftssel_s, gen_helper_sve_ftssel_d, }; -TRANS_FEAT(FTSSEL, aa64_sve, gen_gvec_ool_arg_zzz, ftssel_fns[a->esz], a, 0) +TRANS_FEAT_NONSTREAMING(FTSSEL, aa64_sve, gen_gvec_ool_arg_zzz, + ftssel_fns[a->esz], a, 0) /* *** SVE Predicate Logical Operations Group @@ -2536,7 +2537,8 @@ TRANS_FEAT(TRN2_q, aa64_sve_f64mm, gen_gvec_ool_arg_zzz, static gen_helper_gvec_3 * const compact_fns[4] = { NULL, NULL, gen_helper_sve_compact_s, gen_helper_sve_compact_d }; -TRANS_FEAT(COMPACT, aa64_sve, gen_gvec_ool_arg_zpz, compact_fns[a->esz], a, 0) +TRANS_FEAT_NONSTREAMING(COMPACT, aa64_sve, gen_gvec_ool_arg_zpz, + compact_fns[a->esz], a, 0) /* Call the helper that computes the ARM LastActiveElement pseudocode * function, scaled by the element size. This includes the not found @@ -6374,22 +6376,22 @@ static gen_helper_gvec_3 * const bext_fns[4] = { gen_helper_sve2_bext_b, gen_helper_sve2_bext_h, gen_helper_sve2_bext_s, gen_helper_sve2_bext_d, }; -TRANS_FEAT(BEXT, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, - bext_fns[a->esz], a, 0) +TRANS_FEAT_NONSTREAMING(BEXT, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, + bext_fns[a->esz], a, 0) static gen_helper_gvec_3 * const bdep_fns[4] = { gen_helper_sve2_bdep_b, gen_helper_sve2_bdep_h, gen_helper_sve2_bdep_s, gen_helper_sve2_bdep_d, }; -TRANS_FEAT(BDEP, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, - bdep_fns[a->esz], a, 0) +TRANS_FEAT_NONSTREAMING(BDEP, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, + bdep_fns[a->esz], a, 0) static gen_helper_gvec_3 * const bgrp_fns[4] = { gen_helper_sve2_bgrp_b, gen_helper_sve2_bgrp_h, gen_helper_sve2_bgrp_s, gen_helper_sve2_bgrp_d, }; -TRANS_FEAT(BGRP, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, - bgrp_fns[a->esz], a, 0) +TRANS_FEAT_NONSTREAMING(BGRP, aa64_sve2_bitperm, gen_gvec_ool_arg_zzz, + bgrp_fns[a->esz], a, 0) static gen_helper_gvec_3 * const cadd_fns[4] = { gen_helper_sve2_cadd_b, gen_helper_sve2_cadd_h,