From patchwork Wed Jul 6 08:23:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 587713 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1ec:0:0:0:0 with SMTP id 12csp2544039map; Wed, 6 Jul 2022 01:50:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sxdX/QNIo8KQ4jtakVXwRS17uJ22cT0kkrsJuYuZW5GwIAI9atcz5wyKpRJmlZXwPRf+Wq X-Received: by 2002:a05:622a:1884:b0:31d:4bda:e1d3 with SMTP id v4-20020a05622a188400b0031d4bdae1d3mr12037678qtc.296.1657097453680; Wed, 06 Jul 2022 01:50:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657097453; cv=none; d=google.com; s=arc-20160816; b=lzTN4UeiExnoL2b2JyBCjrKLJXyfdx5YKZZPVL3VfCje6nLFlHlOkMWSxgC7C7jCH1 qM2DVaHu1qnvN7XyvBUPHp5iL1PeVLdz7hr29LRu/Tg3/5gE0dF2G6PqLIJFN+tgIYSC hzV6BbXOPbiP5l1KByRzTCGc7i1d+pfERTkm3SubXTa8eB4J3WHnQ06SkR15KdBozZFO Z6F1j56nmNumHNj2bwPTSCdiTV0ONjWwF45nYHSMFxvWo+a4Vnti4Zmr7I6il/Q1gG+a HAI0WlGqk70gRjdjJ9pJ57a4GQSqWCuA4hwm+1/nsa6DEidpaInPAMQ6KyIA++TJzoUv IQQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dcHardhOi3ouG3QD1ZaU/LIrZV5tMarYA0PaEYIlrzQ=; b=ES4wygi0T9zebn6GfboJlyAAO6DzW2buvBxYeQ6dW6S68tUS4r/z1NJ0H+FxvHNq7t OYKQFZ1g6L5aD9HjwOPPPqyxe0YTi4RWaph51IMhtmcp/+wEFa+bBbxm4Cec1nO2/X2B mNKiPXdd1Qp60x3q9MtmAHxk8CIk/lSOzUoLC1QpeL4hkvdlWOp1S7zX955m7hbxZy5j mwrhNqAenqz5rkrFE/9CvBYIshI9f1uxqhpTUSF2NW15rwVaRM7IMiNEAI9fWmA4vwQd u4W3m1zWcZ/F59/H7W4TaxWNL0qjjQK3gBmZKT1j8npwAcVhL7U6ujBrmPQIrpuz9ujN 2bvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="sfK6dHS/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p7-20020a05622a00c700b0031c392743d3si14559084qtw.144.2022.07.06.01.50.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jul 2022 01:50:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="sfK6dHS/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o90kG-0006v9-Qg for patch@linaro.org; Wed, 06 Jul 2022 04:50:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o90Ky-0005qU-J2 for qemu-devel@nongnu.org; Wed, 06 Jul 2022 04:24:45 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:33294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o90Ks-0000Mx-Ls for qemu-devel@nongnu.org; Wed, 06 Jul 2022 04:24:41 -0400 Received: by mail-pl1-x636.google.com with SMTP id n10so13096692plp.0 for ; Wed, 06 Jul 2022 01:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dcHardhOi3ouG3QD1ZaU/LIrZV5tMarYA0PaEYIlrzQ=; b=sfK6dHS/c4Uh2K6uZDXWEv42T0KKqtzo2O2B4E/bMotQJT7MG8HTakgEkGBkXHOrhf ia2DxAsae14E+n9cS3SwD2q7U5Xa4+T3KuS5Jd5p/2jiH+XVA/ENr1hbj3vTUtaySL5I Jum0RQmfQ2hXtm7I18GUqGEGgG46Gq4tI+xHxM5v1UT4p4CF7UN0EJzZm7lKBGMKGjYy nz91GIwOoaUowJPT/gB6sLN0we3yU76iGArwItLWK02Nxvj6yEo7k/1pjw3+17k4LYPA CQQQQdm8PE3bXWrDjs+OT5w5KfmfwHhO07eZBvcPYHqg4G1CSdAjQMBuKrZUMbwifsrH objA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dcHardhOi3ouG3QD1ZaU/LIrZV5tMarYA0PaEYIlrzQ=; b=b7vQmb2eKUOivFvZW2scIFTHmS25z+DPnLQYUWb7O5zrt56bthERImKkhs1KBsH/m9 N3osv+vCHYNmEKhrxWWBlZMhAUMir9iKd/9HyrwJug+w5dDCwBgu1Zs/kVz9gBULRwEK App1FuV0e0zfNXZlSTVf9nIJXvm00HKFcmUgdEdcszUKz5+SnqgTKCRxVux+YtxeM477 bM9k/mx/p246XevusHP31Lr/SGNI045+OacwUUArSR0tTdUYZ90FXMnpo/dDVoCHFJlR Ruy2GiBW7tUY3WP0YlA5Xyhs7MexYem+0Kz5rb1lIozonEX2fOZokNdSD6YjolcCyjz7 lOIA== X-Gm-Message-State: AJIora+dCRYBpf4q6x9i9ATb5iremm8iuDIR//gMsYey1O5io32fxADf xPgk9iU8dQ9SeQuAe7CPvvT1yPotSe72DX1g X-Received: by 2002:a17:902:9046:b0:168:b8ee:8164 with SMTP id w6-20020a170902904600b00168b8ee8164mr45436113plz.159.1657095877368; Wed, 06 Jul 2022 01:24:37 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id t17-20020a170902e85100b00162529828aesm25199256plg.109.2022.07.06.01.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 01:24:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell Subject: [PATCH v5 08/45] target/arm: Mark FTSMUL, FTMAD, FADDA as non-streaming Date: Wed, 6 Jul 2022 13:53:34 +0530 Message-Id: <20220706082411.1664825-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706082411.1664825-1-richard.henderson@linaro.org> References: <20220706082411.1664825-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Mark these as a non-streaming instructions, which should trap if full a64 support is not enabled in streaming mode. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/sme-fa64.decode | 3 --- target/arm/translate-sve.c | 15 +++++++++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode index 4ff2df82e5..b5eaa2d0fa 100644 --- a/target/arm/sme-fa64.decode +++ b/target/arm/sme-fa64.decode @@ -59,9 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS # --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset) # --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm) -FAIL 0110 0101 --0- ---- 0000 11-- ---- ---- # FTSMUL -FAIL 0110 0101 --01 0--- 100- ---- ---- ---- # FTMAD -FAIL 0110 0101 --01 1--- 001- ---- ---- ---- # FADDA FAIL 0100 0101 --0- ---- 1001 10-- ---- ---- # SMMLA, UMMLA, USMMLA FAIL 0100 0101 --1- ---- 1--- ---- ---- ---- # SVE2 string/histo/crypto instructions FAIL 1000 010- -00- ---- 10-- ---- ---- ---- # SVE2 32-bit gather NT load (vector+scalar) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 4ff2102fc8..d5aad53923 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -3861,9 +3861,9 @@ static gen_helper_gvec_3_ptr * const ftmad_fns[4] = { NULL, gen_helper_sve_ftmad_h, gen_helper_sve_ftmad_s, gen_helper_sve_ftmad_d, }; -TRANS_FEAT(FTMAD, aa64_sve, gen_gvec_fpst_zzz, - ftmad_fns[a->esz], a->rd, a->rn, a->rm, a->imm, - a->esz == MO_16 ? FPST_FPCR_F16 : FPST_FPCR) +TRANS_FEAT_NONSTREAMING(FTMAD, aa64_sve, gen_gvec_fpst_zzz, + ftmad_fns[a->esz], a->rd, a->rn, a->rm, a->imm, + a->esz == MO_16 ? FPST_FPCR_F16 : FPST_FPCR) /* *** SVE Floating Point Accumulating Reduction Group @@ -3886,6 +3886,7 @@ static bool trans_FADDA(DisasContext *s, arg_rprr_esz *a) if (a->esz == 0 || !dc_isar_feature(aa64_sve, s)) { return false; } + s->is_nonstreaming = true; if (!sve_access_check(s)) { return true; } @@ -3923,12 +3924,18 @@ static bool trans_FADDA(DisasContext *s, arg_rprr_esz *a) DO_FP3(FADD_zzz, fadd) DO_FP3(FSUB_zzz, fsub) DO_FP3(FMUL_zzz, fmul) -DO_FP3(FTSMUL, ftsmul) DO_FP3(FRECPS, recps) DO_FP3(FRSQRTS, rsqrts) #undef DO_FP3 +static gen_helper_gvec_3_ptr * const ftsmul_fns[4] = { + NULL, gen_helper_gvec_ftsmul_h, + gen_helper_gvec_ftsmul_s, gen_helper_gvec_ftsmul_d +}; +TRANS_FEAT_NONSTREAMING(FTSMUL, aa64_sve, gen_gvec_fpst_arg_zzz, + ftsmul_fns[a->esz], a, 0) + /* *** SVE Floating Point Arithmetic - Predicated Group */