From patchwork Wed Jul 6 08:23:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 587715 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1ec:0:0:0:0 with SMTP id 12csp2544932map; Wed, 6 Jul 2022 01:52:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sz7ppjkPnMYd3RGavGG3NAZvkzbPWrmpj4yAHBmY5cSDGqofC57T5icFEYeyMMMzaa/+6O X-Received: by 2002:a25:2612:0:b0:66e:557c:772e with SMTP id m18-20020a252612000000b0066e557c772emr14672868ybm.256.1657097539411; Wed, 06 Jul 2022 01:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657097539; cv=none; d=google.com; s=arc-20160816; b=Hw2JHjuGgNobyrs6nxmuxRBNQLoCTzXp1r+jS9sYN1XppR5RCJHOhkwa569FIVPBkY gIjoTIYv5AC+XD9OfNapD40/KjkPNicUA4AHqW6h93tOWxt+AAifpO9lxm8UZqvkmB57 FUdYNGYcuqGkJiOSr7TP1iSvgrIgYuOxDD2Z8fXggekXwtRKGtKAgrnUytRuYnxT9tee GTWqii6ggzoToAf5WsXKVHhhd/sCP6N4CNGWmMTCV3+UYg27X+GqIfG6YHiNe4pBAv6L jvgJUvfgJpvwU8MK1FB89X3rC4jsE3pTN/E9jYvI2DTXFklszjk3XP+I1PIlAhYPJQaj E1VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4m+iHIMfbnBsMZ3ri5BagDQ5TJ6WuhbAqlKM6iP5vPw=; b=dKaxnCTpVthBzbTbPwciJRFrITZAhRd8Vo4Gs8nkT95V4bryIcUGhjPz6nhPlH6OwX YEy14ZLUUyGI1sBpvle9JAOaTnq4K8cYwSNN/JwSpkB0WiglEq/VbxKXmXrpR1TT6oJQ 0BWpH4rVOjSHfDwWWtujiQWozWp0F/wMh8ya133VLRgSFXt+2WbquSzy/VadQxIPV//e 9OFgsXLgh1zheC+VbjtrDLfAIthmWuweCEBH41/mE8gHR+cyQ3fh4dyn9DduSmc+lNef WefEXWzwT7HTMkW94F7vf6QyeaOsyfuG072am8CPl89Tgs0HwgiBHfElw6GKNXIEsbMp uI7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gmUGO8lN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 127-20020a251185000000b0066d92aba03bsi26934563ybr.126.2022.07.06.01.52.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jul 2022 01:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gmUGO8lN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:50100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o90le-00007q-UV for patch@linaro.org; Wed, 06 Jul 2022 04:52:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o90Kx-0005qR-IV for qemu-devel@nongnu.org; Wed, 06 Jul 2022 04:24:43 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:38813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o90Ki-0000K7-Pk for qemu-devel@nongnu.org; Wed, 06 Jul 2022 04:24:42 -0400 Received: by mail-pf1-x436.google.com with SMTP id o12so177249pfp.5 for ; Wed, 06 Jul 2022 01:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4m+iHIMfbnBsMZ3ri5BagDQ5TJ6WuhbAqlKM6iP5vPw=; b=gmUGO8lNlUELF1oZuswjvef4QQbNXesY+rsivVKC8J0kOSBmoWyF8dfcYvnJCXKnbs EsK2pANf67PN0wGHFRGqkfKrrq3DzyvAYJNwe790ayNpyjydOcPS7yHXdHa6ybagwj+C I121pXwUUSRchIb0ovQuM6ni4//N2AQG3nP7KOGgX6VAV4VEzHu4XGrUcDCBI9h78SIM pVBTO8ehjrGNr0SR8S3bs5GZDZmZcVcDOlNhNhZmYZXWY/4fY23QhpiFKI2tGOsRta6+ CrTXhakTSdLbsZfWxUIba5q648kyQxzO5rSkuPknT+Kx61K6Yg5GUwSj17+GAiCqC5xH g80A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4m+iHIMfbnBsMZ3ri5BagDQ5TJ6WuhbAqlKM6iP5vPw=; b=xCcxNcKfphvF9ytXngfv/SeQ/TV+L+y2iQzuVVMKBesNqngTQqzI9d3COha1wP8Bji H4c0PZqaMD5XBLf+Ufi51FzXZytykpGwNpSF/o9lUVV0wDantPZfPktnUDqQDAtVCerU h0IZoPGMurWel6wi7UCmcVGm7IY0Pxcrmnxuw3Ki5RGzOemrXYQIufG4wYzVmTtB3ylC JLNGTlYwkU0tOZgY7Kcdibg7ejve/xCyX0HwOvc0NJF4ZqJaHsgvkZW6xD6KYw/pum4c i1yG5BzV9X3MpWI2qzWIBD/2sy6dvGKb9QV5wFqmZzZMwrvRQrZgmPbAzGr4FWFlvfaz lEUw== X-Gm-Message-State: AJIora/vfiYHkiWBD4lCoV7UhPHmRGyRRWPfZlK10pUfPuw3lBZN6//V 2D4SE59hQNkFHzFvqdxjatn8ZzQUMkdkv7+f X-Received: by 2002:a05:6a00:1592:b0:525:52ca:bee6 with SMTP id u18-20020a056a00159200b0052552cabee6mr45403178pfk.38.1657095866531; Wed, 06 Jul 2022 01:24:26 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id t17-20020a170902e85100b00162529828aesm25199256plg.109.2022.07.06.01.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 01:24:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell Subject: [PATCH v5 04/45] target/arm: Mark ADR as non-streaming Date: Wed, 6 Jul 2022 13:53:30 +0530 Message-Id: <20220706082411.1664825-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706082411.1664825-1-richard.henderson@linaro.org> References: <20220706082411.1664825-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Mark ADR as a non-streaming instruction, which should trap if full a64 support is not enabled in streaming mode. Removing entries from sme-fa64.decode is an easy way to see what remains to be done. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 7 +++++++ target/arm/sme-fa64.decode | 1 - target/arm/translate-sve.c | 8 ++++---- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.h b/target/arm/translate.h index cbc907c751..e2e619dab2 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -566,4 +566,11 @@ uint64_t asimd_imm_const(uint32_t imm, int cmode, int op); static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ { return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); } +#define TRANS_FEAT_NONSTREAMING(NAME, FEAT, FUNC, ...) \ + static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ + { \ + s->is_nonstreaming = true; \ + return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); \ + } + #endif /* TARGET_ARM_TRANSLATE_H */ diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode index 3d90837fc7..73c71abc46 100644 --- a/target/arm/sme-fa64.decode +++ b/target/arm/sme-fa64.decode @@ -59,7 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS # --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset) # --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm) -FAIL 0000 0100 --1- ---- 1010 ---- ---- ---- # ADR FAIL 0000 0100 --1- ---- 1011 -0-- ---- ---- # FTSSEL, FEXPA FAIL 0000 0101 --10 0001 100- ---- ---- ---- # COMPACT FAIL 0010 0101 --01 100- 1111 000- ---0 ---- # RDFFR, RDFFRS diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 62b5f3040c..5d1db0d3ff 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -1320,10 +1320,10 @@ static bool do_adr(DisasContext *s, arg_rrri *a, gen_helper_gvec_3 *fn) return gen_gvec_ool_zzz(s, fn, a->rd, a->rn, a->rm, a->imm); } -TRANS_FEAT(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32) -TRANS_FEAT(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64) -TRANS_FEAT(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32) -TRANS_FEAT(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32) +TRANS_FEAT_NONSTREAMING(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32) +TRANS_FEAT_NONSTREAMING(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64) +TRANS_FEAT_NONSTREAMING(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32) +TRANS_FEAT_NONSTREAMING(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32) /* *** SVE Integer Misc - Unpredicated Group