From patchwork Mon Jul 4 09:33:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 587114 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1ec:0:0:0:0 with SMTP id 12csp648757map; Mon, 4 Jul 2022 02:42:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vGfscL+zOpS3ez0o3/SxTLZHo3uZ+604boqM+dmTUa8CgwEUJwg9woymvYNMVfOcNrGcYR X-Received: by 2002:a25:248:0:b0:66e:2a2b:4a5c with SMTP id 69-20020a250248000000b0066e2a2b4a5cmr11318352ybc.109.1656927746085; Mon, 04 Jul 2022 02:42:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656927746; cv=none; d=google.com; s=arc-20160816; b=vm/q7rMFnd4fILNfV6Ioqs7fxAnlEvMHBiV2AZlPcaFhV/ODbgFi5B9kN8PZ1IJObJ i00Ly7VW3CVRjAEZEr4pe/bcksHrSGObcwRvlrzQqS2CVG06KfbR4DVPSP0c4gBbF7FO GUF3aF7lzVlqAJHXK6fs7FSOPsJu5UHfReuFnrUGUdV9XWMN4R59arDbBisTLPAPPSH3 lhQhlbWwoWJdwYQD9Wcub+rQjtfEizbejY+M9SBaMwzfsrLGfkAZL/0xwByk8XAINcbC Rn8CVXzcB+y2iqyHBGh6QJPfVe1gQy+0JLIBmCBHmrgstQQTtn9gZ9sHPFqa/GElL0Wd JSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DK+o36Kb2qI9WXT+tA4Mnr7sNiWthsvqHNWaprqXJrY=; b=KEwmWh/PAF2zVuIuNYkFvvAG0iGcuocPtF8LYYOhOnKaJ6NH2FmtSRg9jx7MFFUdIN jwdrz85xkZIKgc9+uEVJhuXjpUP9tqd9yxs0y8X5mPMD02QE9u8srA+jVySdUm1SJuMf 9K/x1Ma+c/h3W/AyDBZJIVDUglpKmamssRNNLTPbncN5PKvSy1yJD2EfZt7ILnmrvWPn 74meDOWbzzkJQnuMk6JDmJ5RDyOQ0SHgj+TY1Flvk2kymJ7bg7vQsTaHeaH5hg4FyhMG Ut+kAF0Tf3hhMEv8seoFv3hpQp2tcY6Dz5UqxcTOIdiZYBZ56eaxo2X/aVHZRuu/Qy5M I+RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xz+lRHRz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h127-20020a813a85000000b0031c7225ab98si10844064ywa.472.2022.07.04.02.42.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jul 2022 02:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xz+lRHRz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Ib3-0003Hg-E4 for patch@linaro.org; Mon, 04 Jul 2022 05:42:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8ITi-0000yC-Tj for qemu-devel@nongnu.org; Mon, 04 Jul 2022 05:34:50 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:40555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8ITg-0004zX-Gk for qemu-devel@nongnu.org; Mon, 04 Jul 2022 05:34:50 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 9so8441175pgd.7 for ; Mon, 04 Jul 2022 02:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DK+o36Kb2qI9WXT+tA4Mnr7sNiWthsvqHNWaprqXJrY=; b=xz+lRHRzVw3nsEdp2BMdCv0SlEaF53WHj/gSEc3giXJkAjs5fw94wofm/zKp7z3QKZ qnjERsowGhY/zoEf9AubwYHtdGsHSgFgsuy1KstTj6iEQnPc86C8EwU3QjDtKB5T9JqN DAp4sPXSgOETzhp8h6uKNdNKFujmLksqyhZEv/wUtdofpkAcysqXmdPxdPmGMzRcK0Zv p6kDVm1vHK3Boy0CoaqhptE2sWvpNgWIpHbodGK4/8xRbl2M8UcYsPRjw4UCG6/JX7U0 +NAF5pechy3pEgOt1GmkqNkh69WQtmpZDAZ9DDB1FqyR86BLokwy3TvsZh5rhdz1wp0Q /OeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DK+o36Kb2qI9WXT+tA4Mnr7sNiWthsvqHNWaprqXJrY=; b=1ye+9zRUG1mqCJON22Rf/0j6VVE8W0nh7RAfy2BH0atAMeJOq03DNn41KG9WlJfZnu jndIpIlPKGl94kyxWd4Fw1crtpU/RslNbeif3EvEvcx0sudMxuVv4U4SDr4rUSN6cJpf 3kOxZztpwQDynNjv3lVYhyCVOwiWhmxzOn28NncUGxLvKMkwfCWm1VNAouMW3W6bOd3Q Iny1At3YxP9jSwtsh5Wtep+ghH2RE1IPqlfjfWbL5FPZMJQpdvx9aPkXm3muyOxFucgh z5VSmzqtoZHvrkSdWaZO7rj2UDvmNc4IJUygrwVwT+CkK66d6WwzRKiPXpKk7Zx+s4lV lFMA== X-Gm-Message-State: AJIora/hYTIOjl8DlejxlXdsFSXI3nYjhUtGgBiDfEtoDdrsJbydeXPg Kua/1m6UthOqhKuhlusYBkuyi+fEYah3SeXI X-Received: by 2002:aa7:910b:0:b0:524:f8d9:a4c4 with SMTP id 11-20020aa7910b000000b00524f8d9a4c4mr36336103pfh.5.1656927287219; Mon, 04 Jul 2022 02:34:47 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id z5-20020aa79e45000000b00525b7f3e906sm15353355pfq.27.2022.07.04.02.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 02:34:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Xiaojuan Yang Subject: [PULL 16/23] hw/rtc/ls7a_rtc: Fix timer call back function Date: Mon, 4 Jul 2022 15:03:50 +0530 Message-Id: <20220704093357.983255-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220704093357.983255-1-richard.henderson@linaro.org> References: <20220704093357.983255-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Xiaojuan Yang Replace qemu_irq_pulse with qemu_irq_raise in ls7a_timer_cb function to keep consistent with hardware behavior when raise irq. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-3-yangxiaojuan@loongson.cn> Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index b88a90de8b..780144b9da 100644 --- a/hw/rtc/ls7a_rtc.c +++ b/hw/rtc/ls7a_rtc.c @@ -425,7 +425,7 @@ static void toy_timer_cb(void *opaque) LS7ARtcState *s = opaque; if (toy_enabled(s)) { - qemu_irq_pulse(s->irq); + qemu_irq_raise(s->irq); } } @@ -434,7 +434,7 @@ static void rtc_timer_cb(void *opaque) LS7ARtcState *s = opaque; if (rtc_enabled(s)) { - qemu_irq_pulse(s->irq); + qemu_irq_raise(s->irq); } }