From patchwork Sun Jul 3 08:23:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 586801 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp2914035mab; Sun, 3 Jul 2022 01:34:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tmShDAXvth1bwpFyGrNrREIHOqNkztNJnPQRZapMyKgn5MV9QUXkhOc/3VjguDnHD9nkBj X-Received: by 2002:a05:6902:1027:b0:66d:136e:8f with SMTP id x7-20020a056902102700b0066d136e008fmr24642175ybt.25.1656837244698; Sun, 03 Jul 2022 01:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656837244; cv=none; d=google.com; s=arc-20160816; b=mI2/bD5ynTRN2fNIwz2KjcaGUY5iPZ7bf2AXM64ESkacQt/7hrEm3Kx3Ek0x6xxzJl amTVipKvsunWYQsoJ1KcXv+fnOah/4m5r86J8uLO+9aX9qrbvtl9lb0kDKeAXME31F3q u2hDJ9Z4BeQwv+Nqwq/so44MuuI8rKpx23fGorSxLfdBlcixEx+0E8L8yHBiVQNiUvlL d2wF2mHBt7drNn4j+JUmAP8Notb1l1ylDh/cqj7GZ/C7AAKX+Uu9U6ZVI71VEugsViwN bv6pHwClGeJmYz72pbuB4C4C+AKW959NaEF2OMs93A/qTD2Kb6FTiP+86By+9GrqMhvk 5ydQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=luVPKzasukavgin4n19Q4taZFn3j+af3jyeUe3XIhz4=; b=XIIiPl0e7Vj9Vc6ygCk0A68S5+RKRZYma27IS4DpZgxPzop4brtcG1Uh4CRY6sM3Uu 3E0ZFQd4wEIlWOnWNXRA14ymXRyWlh2et1R39pWlGWG/ZixYeVIYKxzO6YZwkdlC+6Gm Xe+HrphcDOgAsikcoZabtDLr7Qx8fA256GCHz3JfsTMliip5OB1sGzi5lmyxDAFXTrCj fl7dpSs7CUk57JB+xzaXUCywemFq95bMkMzlXBqJ8ycsj4G98TCzs6b8FpfyktDYjSuU ryiTMpQB2/Kf7+c85XJBsOutOqXZaKiUd0zgwxTTcMH2gr+J/fA/86zG9lBnpeS9qi9z C34Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="C/eAemyz"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b10-20020a25340a000000b00668e9a0bfd8si34729725yba.593.2022.07.03.01.34.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jul 2022 01:34:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="C/eAemyz"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7v3M-0004Sh-6R for patch@linaro.org; Sun, 03 Jul 2022 04:34:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7uuD-0006Mc-8c for qemu-devel@nongnu.org; Sun, 03 Jul 2022 04:24:37 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:38793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7uuB-0005oc-PQ for qemu-devel@nongnu.org; Sun, 03 Jul 2022 04:24:36 -0400 Received: by mail-pl1-x634.google.com with SMTP id m14so6029168plg.5 for ; Sun, 03 Jul 2022 01:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=luVPKzasukavgin4n19Q4taZFn3j+af3jyeUe3XIhz4=; b=C/eAemyzfdi7SQ0wNM8HnbS8K5cYr/V8RLlK8oA7aseRCfA6h2r0CdTIGVU7sQsbiZ 0pt3IzlkjjELsfxaburKXJVVIMWLmnx3UmTZZY+SWAi+OoA7VhhOSmnFEVUE2WTEdz8j jqr0FO8aZJt29kYXVgk6lvLB2OCdMVpi5xQ+5TdjMgHrfa2p43HBChjWE83geyUSKQ/u 1vO3lmokVpcmNzrYfkifzjOK+iYlvj4lyX3l3reGgbUJr9dV3y5Vdg8GoL8woxco0iYP MCfkD9sIe9+2o9T1mg83upZ0/RWXYVsxAuZEpv7rLeBgQ0RT62ip28AyGeSbsXdzRin7 7BJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=luVPKzasukavgin4n19Q4taZFn3j+af3jyeUe3XIhz4=; b=eu8Q2NJWe0OsKlx1CugREkNnCHIW45MjcCKAdsbilWXXHpmms2YA6vwoD5EfTjFn5d zftePgtFS3l2GyE1A4K1RCAD2XUclxqifNHYM3TMsPncJt0Wj1il07FMMGfe3HXhlkM6 JXD0DBqFzAo4WRknUq0zlvKObCTl3ydreQYPnoq7jiOGTTC3kGF5ySOSuf4q/YJqxLpS HGWmhkBV9aExZn6hD8I2UXxuw95vL/evn/Xamj3xF+sUHYeJB051ma2Ln+x2TQotXW+J qySZylRHGIxTnoxGTfH/ytt5rJ2GjJT7R1C3WP+IS+jtIG+7Zllwpjmym+ehg94TuH0b 4+GA== X-Gm-Message-State: AJIora+lv6lAbYIGrn0wr6konGOdkgItfKnrnAgJSDgoHB2q+jWeco0n h/nzMTmshThb0ZvOHGmc3TDnhqyLTKLIzlPI X-Received: by 2002:a17:902:7204:b0:16a:22f1:f87 with SMTP id ba4-20020a170902720400b0016a22f10f87mr29561512plb.3.1656836674424; Sun, 03 Jul 2022 01:24:34 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id im22-20020a170902bb1600b0016a3f9e528asm13569112plb.57.2022.07.03.01.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 01:24:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH 03/62] target/arm: Fix MTE check in sve_ldnfff1_r Date: Sun, 3 Jul 2022 13:53:20 +0530 Message-Id: <20220703082419.770989-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220703082419.770989-1-richard.henderson@linaro.org> References: <20220703082419.770989-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The comment was correct, but the test was not: disable mte if tagged is *not* set. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/sve_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index 1654c0bbf9..db15d03ded 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -5986,7 +5986,7 @@ void sve_ldnfff1_r(CPUARMState *env, void *vg, const target_ulong addr, * Disable MTE checking if the Tagged bit is not set. Since TBI must * be set within MTEDESC for MTE, !mtedesc => !mte_active. */ - if (arm_tlb_mte_tagged(&info.page[0].attrs)) { + if (!arm_tlb_mte_tagged(&info.page[0].attrs)) { mtedesc = 0; }