From patchwork Tue Jun 28 04:53:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 585547 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp510137mab; Tue, 28 Jun 2022 00:29:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vgieUabtkWVtJ7KAm5nvp93siMJkvNs4wkrel34SS3RSXY6eEMNrkizD1RnGRyabLUanOZ X-Received: by 2002:a05:6214:4003:b0:470:509a:290a with SMTP id kd3-20020a056214400300b00470509a290amr2620397qvb.24.1656401385931; Tue, 28 Jun 2022 00:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656401385; cv=none; d=google.com; s=arc-20160816; b=MQ8WTA7zNNJEJxdiD51SRDRrQiYGdfx/jbwzG8KkHrAM7JWGOwGhNAlPt9CbmzZkzu gtMZiqCFuNVZIBSz2ESLIxMWo4uyudflTU1L9EOGrExs8ujLbkY4nVuqAB9F3w1X1dBG jh4h3pVWBM+S/OhWmCkfSCL4JZU9b591i9Tm1B9NZ8NmCdXkEgUINbKMHbdN4SK12QRA 8yf8hklsQuAyqqS0MOY2nwCMWThgOVsCkqI1mXP2ATqIGAJdRrfMLBpScGIey/rn1fD0 2xIdvF8oLBwY8Tnc6Si7HOfMuO/fhjGmNWwiJFOvOyPUbC3vZnz0MxwrfhjTKCDe7QmQ PDEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0Xz6wzUwopMbPAdNCjdjT86fVDAwIGV9xu3XdWWd8EM=; b=VNa3CTsK23Qs+xCm3j7rnmQzEzMmCPQTmfiHIoO0rBNsE8UdQJgAgFk+qc5ZhHk5uW mMLdP1m1kuB14T2HlSsjufPPd07FXl/pwS6YfTK7r1+/GJ3UjkFh8pWCm8VlkWUcANYe R6cIPhnRBKzwTcmUrIRvJDKkq7yJ1aBwenn8B7mfrr90Vp/eI/VFHoC8A+THSQx9iZkD AsJERyIlPaCAG7IDHBgB+Laibr0KhZ0k6/xXDSKHwFG980O2jheHNLDpqt6s540BMmNz DStZTBnk6WmpPD43C4wIjwwVbqQCJFFID8vCLIEtUwMTilxvpFGo15L2kgd+/9hq4NVA lkdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UL6ebudZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x12-20020ac85f0c000000b00305168db4b9si7236358qta.199.2022.06.28.00.29.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jun 2022 00:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UL6ebudZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o65fN-0006mS-ED for patch@linaro.org; Tue, 28 Jun 2022 03:29:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63FS-0003BF-6h for qemu-devel@nongnu.org; Tue, 28 Jun 2022 00:54:50 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:43737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o63FQ-0008Km-Gd for qemu-devel@nongnu.org; Tue, 28 Jun 2022 00:54:49 -0400 Received: by mail-pl1-x634.google.com with SMTP id r1so10016460plo.10 for ; Mon, 27 Jun 2022 21:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0Xz6wzUwopMbPAdNCjdjT86fVDAwIGV9xu3XdWWd8EM=; b=UL6ebudZa+CwFmlFs6UTQiOWt7qDttWtQkbTBs8kXxSot0mS/5GV1xkSIelsL7Cd+O KIXY/dDzoITqabyRnFknjGLt3TVAzIoKIKblinqCHgevviwh9wlnS1jo2kUSAoCmMtXq x0up7hZT/FrDM8GpteKIOgAlJdb84rwaM6WunADpMbQdN0guGrmWufjVlEfNO3jDZs+k ZF3BygtKqviTfhlFwqAUpd5r3ZMLT25GrxBx5pjhHypm2QcG/G0q7PhKPdUOppksPuZ3 I53YdLjezDwjrP6AnYxBToDLu37uQ9jjy8cOkdwkuK1Sv5fLpNF3mJ1ZKTNtZlldjohc Bi3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Xz6wzUwopMbPAdNCjdjT86fVDAwIGV9xu3XdWWd8EM=; b=FuW7Qr6hsb7Czk6SexfLD22SRxp0HUbChbMGS9LgLqViuCWaY4LWzQvT/f0aR73L0/ j+RHYxEsErwrdjew5U/pLzeH1adRv9uNRRSysxhWbyXLyEcmcOB8mqEZYXl4+5AIFY0j mtD/GHZXDFczohjxMN4gEJz+RGkNC0h58a6iMPNsxgsReJPTJQs4oVSGV3WBT1SEtPFL iPVE2+MyTlitEef/vCtfX63Tfpasa3JfcFQs6c+4u6i7sSIp2q7hKrgY54rcrIkMjKi6 Z0qq+nEUlV5Htfy3wSe1COadYfZdCNUCdp46LwNtdEtX3407wu7CFn7u8Dq1l0UD0JNh VJ+g== X-Gm-Message-State: AJIora86F+QZTS42HJ8weboAiAnivPzLOXxWz7XjfF7fS3ki7AmgDdD7 ZdBwrDeABoxgnUKK30FHhcU/WC3VoOKHOw== X-Received: by 2002:a17:902:9004:b0:16a:6808:e602 with SMTP id a4-20020a170902900400b0016a6808e602mr1825205plp.94.1656392086466; Mon, 27 Jun 2022 21:54:46 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id w8-20020a1709026f0800b00168c523032fsm8073735plk.269.2022.06.27.21.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 21:54:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell Subject: [PULL 16/60] include/exec: Move gdb open flags to gdbstub.h Date: Tue, 28 Jun 2022 10:23:19 +0530 Message-Id: <20220628045403.508716-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220628045403.508716-1-richard.henderson@linaro.org> References: <20220628045403.508716-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There were 3 copies of these flags. Place them in the file with gdb_do_syscall, with which they belong. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/gdbstub.h | 9 +++++++++ semihosting/arm-compat-semi.c | 7 ------- target/m68k/m68k-semi.c | 8 -------- target/nios2/nios2-semi.c | 8 -------- 4 files changed, 9 insertions(+), 23 deletions(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index c35d7334b4..603e22ae80 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -10,6 +10,15 @@ #define GDB_WATCHPOINT_READ 3 #define GDB_WATCHPOINT_ACCESS 4 +/* For gdb file i/o remote protocol open flags. */ +#define GDB_O_RDONLY 0 +#define GDB_O_WRONLY 1 +#define GDB_O_RDWR 2 +#define GDB_O_APPEND 8 +#define GDB_O_CREAT 0x200 +#define GDB_O_TRUNC 0x400 +#define GDB_O_EXCL 0x800 + #ifdef NEED_CPU_H #include "cpu.h" diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index 92c1375b15..abf543ce91 100644 --- a/semihosting/arm-compat-semi.c +++ b/semihosting/arm-compat-semi.c @@ -86,13 +86,6 @@ #define O_BINARY 0 #endif -#define GDB_O_RDONLY 0x000 -#define GDB_O_WRONLY 0x001 -#define GDB_O_RDWR 0x002 -#define GDB_O_APPEND 0x008 -#define GDB_O_CREAT 0x200 -#define GDB_O_TRUNC 0x400 - static int gdb_open_modeflags[12] = { GDB_O_RDONLY, GDB_O_RDONLY, diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index a31db38fc3..475a6b13b7 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -69,14 +69,6 @@ struct gdb_timeval { uint64_t tv_usec; /* microsecond */ } QEMU_PACKED; -#define GDB_O_RDONLY 0x0 -#define GDB_O_WRONLY 0x1 -#define GDB_O_RDWR 0x2 -#define GDB_O_APPEND 0x8 -#define GDB_O_CREAT 0x200 -#define GDB_O_TRUNC 0x400 -#define GDB_O_EXCL 0x800 - static int translate_openflags(int flags) { int hf; diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi.c index 373e6b9436..0eec1f9a1c 100644 --- a/target/nios2/nios2-semi.c +++ b/target/nios2/nios2-semi.c @@ -71,14 +71,6 @@ struct gdb_timeval { uint64_t tv_usec; /* microsecond */ } QEMU_PACKED; -#define GDB_O_RDONLY 0x0 -#define GDB_O_WRONLY 0x1 -#define GDB_O_RDWR 0x2 -#define GDB_O_APPEND 0x8 -#define GDB_O_CREAT 0x200 -#define GDB_O_TRUNC 0x400 -#define GDB_O_EXCL 0x800 - static int translate_openflags(int flags) { int hf;