From patchwork Tue Jun 21 20:46:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 583616 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp2041099mab; Tue, 21 Jun 2022 13:49:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1usg8AYBm1uJRF8rmc/eB2DMbs9Lm92TzIPxJPtOQWuP+1b6Q3bv+GP+3o+9vLxPjxjWegW X-Received: by 2002:a05:620a:150b:b0:6a6:b079:4e40 with SMTP id i11-20020a05620a150b00b006a6b0794e40mr21605633qkk.184.1655844546629; Tue, 21 Jun 2022 13:49:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655844546; cv=none; d=google.com; s=arc-20160816; b=PlAitCaq0e+PXepTKh5p5mSQ+b/9qqkh7jK6cnbm4/pmm1vH7au9LAyQ92/HX7DGbZ agiuVlkymSJdOVKCtOFbc1zum5O1aTtuic2a/SBVL2NV1VO8fHN8eU0hKrqkn91sPCsx G6FKwNR+NMiuRKMeoyFzflQQwfwJseSVZEn8+z9VN7vNpKVrmMw7l4fQ1gG6nR6AFprL q9ni1kMyUUEGZJxeSvsscTAzDoofEV2tHmmo3Q46ZHiWTkl2pogwuSYEo+uYEojc/Z86 I0NvgvdMAXJ13YTPpL79OAwYo7Zhz0v3lMziABCrklo/TNXIp0YzV2qTrRhd7vn1LpxH rZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7zQvLkFRfY6uiQ/phm8O3aPlVxdTqBvkghprkVFaI2Y=; b=XZbGOdUFG2WkdlwEqohHo9RLd0KQ58U3A8kukaGgzdt/9eZDoCdfkjN1ngY5qrUQ58 5PRpNUT7TMm3zr1TdmU7fDHvqFixmbc0GMHUU0ZOR/U5HOUcgqSDDji9wXeiUi+sLyXH XQGRWjQpDmqmGUgr4T51L522xII4rrT4LE9LmoaedXoTqhMSRNW7idag4G20FepSTnmY sPmOmttGpsDVY3mmZ7zTcoHDTgn4UKFU+m48hjD1mKyZL411xLeutIaetp/gG+xTnkjj FCKNy+PbcCatZEDXk99Yl1VUj5PQwglKiFzCeiE1kbLp846Ip/HB1pwksRvRPmz1uA8g zN/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j6otmGLb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j7-20020ae9c207000000b006a6d257a17csi9761930qkg.250.2022.06.21.13.49.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jun 2022 13:49:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j6otmGLb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3ko6-0006dz-7k for patch@linaro.org; Tue, 21 Jun 2022 16:49:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3kly-0006by-Va for qemu-devel@nongnu.org; Tue, 21 Jun 2022 16:46:57 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:34405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3klv-00015n-NG for qemu-devel@nongnu.org; Tue, 21 Jun 2022 16:46:54 -0400 Received: by mail-pl1-x631.google.com with SMTP id i15so13559627plr.1 for ; Tue, 21 Jun 2022 13:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7zQvLkFRfY6uiQ/phm8O3aPlVxdTqBvkghprkVFaI2Y=; b=j6otmGLb/Cw/NVe5L0hwIqVgRGo7+/vJxPZkR/qBGgb4zUS0JxKJZ9nvc47X709CNU uTDchIlSWw233GE+QdK5+uO+6kGpnmuzbpLPdZVnGAIM2N/lnZphNirUCDwpRBeszclY 2aazHLeI3LbgRm/CeksuzNTgdEHklmReppPyFW/YXmoL9gz2pmRnq7khKuGpptI8yQWz 7MbzohW/UPq3/MhjJTxRO6/AMPLygRn4QZcq9f0DbandABDBoPdGi4kojQOWTSuA/aQv owluUDE1tsm+KiCZskm/8yk7KV4VxYfdClHNWUlROJ+g4EYrCFIQVeTEMnGd5XrugrRt +zDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7zQvLkFRfY6uiQ/phm8O3aPlVxdTqBvkghprkVFaI2Y=; b=R8XpphgTvOCxIYMpmjkh44Meoe1xbGSAoIuDZSlI3xa/v/YkFaoP7fd5fkanARgzRh UTvCd0E0rNZqo2RphDIOM+z8cxJuFhQpX6qTXDJbxWhJU7ENPLcvvPSSQgnws42RUGEP ap7NxWN7AB2IO9Dyr+C6IoTja3xOICeRsvBOC/oOeNgdZUw76Xf5UGDLK6kyXLsHxBZG YdKsLefXwfua8yk3U5XEsWsorSRKq5nvdJBJPOdq7D0n8NhsKO0OkEFlHRVCelGRheqi tEgQJLDtWnulx+idnu6RJIjXtfp1NW0eLppxvuYa6Q0n8lJmto5zmwXT0/yJrmWGHCos Dl3g== X-Gm-Message-State: AJIora+FRZKPhkis/wa0ukeYKV76T3IPAQfNkM9jQkfpB8TgNJTr0kFh oEre0yCwDgRJBGSSlNjqyZUQscb8TIuqfw== X-Received: by 2002:a17:903:22c6:b0:167:5991:fb63 with SMTP id y6-20020a17090322c600b001675991fb63mr30862376plg.37.1655844409201; Tue, 21 Jun 2022 13:46:49 -0700 (PDT) Received: from stoup.. ([2602:47:d49e:3c01:8adc:a144:6ec2:4d71]) by smtp.gmail.com with ESMTPSA id p66-20020a625b45000000b005252defb016sm3649674pfb.122.2022.06.21.13.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 13:46:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Idan Horowitz Subject: [PULL 5/9] qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all Date: Tue, 21 Jun 2022 13:46:39 -0700 Message-Id: <20220621204643.371397-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220621204643.371397-1-richard.henderson@linaro.org> References: <20220621204643.371397-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Idan Horowitz This decreases qemu_clock_deadline_ns_all's share from 23.2% to 13% in a profile of icount-enabled aarch64-softmmu. Signed-off-by: Idan Horowitz Reviewed-by: Richard Henderson Message-Id: <20220114004358.299534-2-idan.horowitz@gmail.com> Signed-off-by: Richard Henderson --- util/qemu-timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index a670a57881..6a0de33dd2 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -261,6 +261,9 @@ int64_t qemu_clock_deadline_ns_all(QEMUClockType type, int attr_mask) } QLIST_FOREACH(timer_list, &clock->timerlists, list) { + if (!qatomic_read(&timer_list->active_timers)) { + continue; + } qemu_mutex_lock(&timer_list->active_timers_lock); ts = timer_list->active_timers; /* Skip all external timers */