From patchwork Mon Jun 20 17:52:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 583194 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp933911mab; Mon, 20 Jun 2022 11:20:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uSBhgYDtRA4LaVfvb4Gkk7Ff+r+b+uEkkftPVWTWNcDSvkltIH00ieOjo7C5iCrohKwdyu X-Received: by 2002:a05:620a:a9c:b0:6ab:95ba:2b66 with SMTP id v28-20020a05620a0a9c00b006ab95ba2b66mr11166473qkg.712.1655749208634; Mon, 20 Jun 2022 11:20:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655749208; cv=none; d=google.com; s=arc-20160816; b=liNhNLqxf+HcPGsTQC3lMiPNcVHLKeAHY3iNvya54VYKHjkrl4v2CThh/Ikm+id6ou sE4WUR+/xh0yR30MCn/W/APR5aZ9k+S65D331nEygwcIc7LljXmyXwHbsVrSNo3k7LCV aHocy7s9D7uUaezQBbQpP7zFImvm5yoAhCrlEiVbvnFsD93KjoEuJeO7oKaEYro2kCjG GBvBmaVPz49ZFAa4XeQ50+eJPOLAkjsH9LlDpR8xxyHs4dVyy3bIPbr5gpmtcCVpENXL GJE5fDMF+XLgIslGW/wI8wE5/KRpSbvSKUvZ1QtfZ3Zi1/NMMyVkoFs+zS5G1mmM0dkF 8xcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Khgw4zesO+K18d95Nf0OQk5x631DSo+q5LDKVsiqTz0=; b=JNmW4kx0QlM2eU3zGKF9Qcp0qJFovlftLDf3wLeqFCUEgoQC5ZNkSIl6TcMHQdBhOg rmI2fTv6QFa5Kcew/TqcPPRoXBpSWlu2ME4/erRnIbreYcBYe8Di8FYi5DybMw0+5L7n LE0mF8yBvZyPlJ6rwbsOI/Kt7ygRUH8EDPXD1qQyysGvZah7Sm6e2ilag+IoXokD/jcU pkUuhvAXoBPvCjtI//KP1ELV8771ef+o++1WjRt5l6+M3Qt3FiuoAPsu7cLmrrRF+68v Wo/5IsSCkQcvTnIjIwcoKDAa8lxX7GRKMJ1RzG36SgqF8lJiwzxXBpZMslgZJmmTXoCp W8zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=phNaTt0F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h15-20020ac85e0f000000b0030503115a33si7871286qtx.423.2022.06.20.11.20.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Jun 2022 11:20:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=phNaTt0F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3M0O-0003rw-7E for patch@linaro.org; Mon, 20 Jun 2022 14:20:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3LdJ-0002s2-5J for qemu-devel@nongnu.org; Mon, 20 Jun 2022 13:56:18 -0400 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:44668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3LdH-00022U-BT for qemu-devel@nongnu.org; Mon, 20 Jun 2022 13:56:16 -0400 Received: by mail-pg1-x531.google.com with SMTP id a14so1290245pgh.11 for ; Mon, 20 Jun 2022 10:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Khgw4zesO+K18d95Nf0OQk5x631DSo+q5LDKVsiqTz0=; b=phNaTt0FT1JCXz9Ao0ivgD0b4uUncrAq8aIV43cwIOScdPt1U7soMr8TMy5LrxkX4D HyHF5VqI7EbyoyM1Y+MkihpDfQZx14PbnXU0KTiQZIkN67rVgtBk+hakE97FgOK+EysK lm/ulk0jBuwxuv1/mbBgxGgj1PByJT8THXgLUFGp4OG5H/0k75tqYg47xGdE4KaFa33t 8oUW6l4s48jzk+8Fx+C7OxQTTS/pOchXJpNP2EEiLdk9e0hnk9pyLIWK/XYbTeKhT+0S xmT2Cz6EH7dRdvhCwj8OoiYBL+Pc/cFQCHippndhkrV4dV6wHFft//SOlN1h93PeEZ20 rmHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Khgw4zesO+K18d95Nf0OQk5x631DSo+q5LDKVsiqTz0=; b=sU4Nk5UXD1A9Cr+9kyYptxPiiMYrNEJ1REXYp7IHhdAufehrLTuFZTCXn1WFLEO8uT InujWjM/jmHdvCBdn9JXx2JE9XrmhBQavxV0iN44Xd1azWpWyAGBOqesV93MUk6gfDO3 5LwkW6zxpmSCFSA7sDiuTKYw5Z/SLSdsAzRx0spVxIbw5qW2ME2IP6uRV80fLKZW76Dc k4Rbq7G9kr36iAkLfcdvieve2WCYSGy9U3r85bwTMcSfVMFsuSRKx40HIBVf0Qov28Nn npC/KYDu3ERQ8L9lBVSKS/XG7vbcq/V1v/gNJMsaLuzGbEZc1jQ728yC4GeYjzfCbpPI lGrg== X-Gm-Message-State: AJIora+SqUBOrZgXaieeKm5QxznOIM5Y9lN2kUu+AirTWRBGuiLgU7am D0RBy3V4gSD0aLaj0qxepunZnXxysQLoBQ== X-Received: by 2002:a63:ab01:0:b0:408:c856:f70a with SMTP id p1-20020a63ab01000000b00408c856f70amr22726557pgf.109.1655747774070; Mon, 20 Jun 2022 10:56:14 -0700 (PDT) Received: from stoup.. ([2602:47:d49e:3c01:a3e0:8a80:7b85:aea6]) by smtp.gmail.com with ESMTPSA id z14-20020aa7990e000000b00525184bad54sm3850474pff.126.2022.06.20.10.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 10:56:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH v3 43/51] linux-user/aarch64: Do not allow duplicate or short sve records Date: Mon, 20 Jun 2022 10:52:27 -0700 Message-Id: <20220620175235.60881-44-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220620175235.60881-1-richard.henderson@linaro.org> References: <20220620175235.60881-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In parse_user_sigframe, the kernel rejects duplicate sve records, or records that are smaller than the header. We were silently allowing these cases to pass, dropping the record. Signed-off-by: Richard Henderson --- linux-user/aarch64/signal.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c index 8b352abb97..8fbe98d72f 100644 --- a/linux-user/aarch64/signal.c +++ b/linux-user/aarch64/signal.c @@ -318,10 +318,13 @@ static int target_restore_sigframe(CPUARMState *env, break; case TARGET_SVE_MAGIC: + if (sve || size < sizeof(struct target_sve_context)) { + goto err; + } if (cpu_isar_feature(aa64_sve, env_archcpu(env))) { vq = sve_vq(env); sve_size = QEMU_ALIGN_UP(TARGET_SVE_SIG_CONTEXT_SIZE(vq), 16); - if (!sve && size == sve_size) { + if (size == sve_size) { sve = (struct target_sve_context *)ctx; break; }