From patchwork Tue Jun 7 20:45:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 579394 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5806:0:0:0:0 with SMTP id j6csp5550552max; Tue, 7 Jun 2022 15:03:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx3dIaFoNSVoB79MJBVtgOJm3UCqKtc8tqnISOHPA+x1PB2tR7c6vU7mKNTBqcpZnVGatj X-Received: by 2002:a37:a64c:0:b0:6a6:c320:bb3f with SMTP id p73-20020a37a64c000000b006a6c320bb3fmr7830329qke.12.1654639439089; Tue, 07 Jun 2022 15:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654639439; cv=none; d=google.com; s=arc-20160816; b=nSPr0ApuL1ZUDiKvRvvkKQ9akY7efK673KCQuxiWNPi9tC6ngcNEKikYlK9JDvsJR+ fnr0sh3xz3ptrTMK3PcKThIi7nV9uhPHuR2GruuhilAxnNF28bzuutuGmauE6P09+G5B ETdlNZ3egI13oal5NNZvngWykb6sQulibjwnPEnmxVLk+7lqFY956RhthYi0AUHdT1uV d79GmW+jPgNFFmk4KE7jfKvnfukDESXF1A4qnmvzHfPKZJEDoAvWjJsz+9godqarvYHQ sTDbn25o2dYJ4LJ5XSqo3yJ8VFkKgcfVAQEacnPWaihZ+LfpE3ByuJFoNOk5LO9GYV0U WcOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=iN+ZQSw54uXkjIjlKW1pFe1Mm40xsm8fxs3pFQz2QI0=; b=CmhV+OmEmHB8psML+ppFuxXg2nNcsekvDSC5gmkiNOaGgyIl4qkEVoqkJxySfpwyed l7Xenz2nERjrzK32HXMqkzXol93xTdQlN0Pv5qSsN2Pu3B0vIJTIIQy7v3tCUAZRA8iA d7sjDZVBImusdJRfN/krz4HwduDnd2BwV80iIyVTqEsuvqgbOr1lWiE/wUTDgiqm+EOo Q9dGWa2rdDA9i2pQv6ZzZM772FP+oaZDN8w132jRA/Una0EF00si8C8dpvrVCF85nBhv gfyVzmANV8v96V1nS64G58e2unf/z+cZPFtqCUspxp/iFIN/j1JTQsnc7TA1xndi7cjQ s41A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vicYudqv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v18-20020a05622a015200b002f9175beab3si9250231qtw.208.2022.06.07.15.03.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Jun 2022 15:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vicYudqv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyhIr-0003xq-LQ for patch@linaro.org; Tue, 07 Jun 2022 18:03:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyg5g-0007FV-90 for qemu-devel@nongnu.org; Tue, 07 Jun 2022 16:46:17 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:40890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyg5d-0001JY-MY for qemu-devel@nongnu.org; Tue, 07 Jun 2022 16:46:16 -0400 Received: by mail-pg1-x52c.google.com with SMTP id f65so6779229pgc.7 for ; Tue, 07 Jun 2022 13:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=iN+ZQSw54uXkjIjlKW1pFe1Mm40xsm8fxs3pFQz2QI0=; b=vicYudqvcclxAoOqhlETQImNvV4SEX43HVC9LQhd4A+ubPugNW3ke7QwdDZhdwKKu+ anV6wXdhT4tQmEePESyaCA+cpPu2SFHxms4bGDoKnvgIOHAupKo/5hJqFB5uMFVqJF4S PzIx657g6m+QYMldnfO0I0m5MpjdN/QxLKPceUvj9muUxZ+SES6sHm7/yQ4Luni7BHRF 22ZFBetSe575uPXBVNZQL709ISV/BgAPUtLQiNIIZJ3SrrDw++wjh7FmvmwDISjeU0IP ekFkyW/lwk0cA8hsBso80eUilDbtoiSOnjxOj10r8EdiP+6nVv5yJllMQJsSQznefT/b sv6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iN+ZQSw54uXkjIjlKW1pFe1Mm40xsm8fxs3pFQz2QI0=; b=f+P9ogxx1kc/cG4+Sa+AC28njR7WRCoZnYjsy62MFMoi3PmNleby5DQhRo4xl1dZC1 cEz9D4MNt8aB3/XYjSZ0sfrOr8b8ms/Et+u8jlAWkwXVDjKWrDzT4sFHUyf3FJVtr7Im qVghBk42CQOnIFaOdSaCQ5mkUZFZTi+HKstRWiYsJTzIyVUUK4PXgT+xb4lR9cVuHAyo ml5lyRFiDhTp8vJEUfWYaDBqxmjyNu5Fj21C36JaxiUN/K9KA0VWHcPHU4FBuAArvAVg +EY8dk79P1bcflrYCBj4ivN5IqdCGATYYPJlaVUysodzswWJziCVKvs3cVMLc5UkW82e 3SGw== X-Gm-Message-State: AOAM530/plrt701JRLRNcX+8WQeUse76uxDt2b2IyIO9mX1PQhgJpeib m+XUmzeBLGOpEEGALkaWYFzGyyn6xCqlPw== X-Received: by 2002:a63:90c9:0:b0:3fc:f0c9:d0f with SMTP id a192-20020a6390c9000000b003fcf0c90d0fmr24091360pge.608.1654634772915; Tue, 07 Jun 2022 13:46:12 -0700 (PDT) Received: from stoup.. ([2602:ae:1547:e101:3cf2:c634:5b19:25f6]) by smtp.gmail.com with ESMTPSA id r6-20020a170902be0600b00162037fbacdsm12971279pls.187.2022.06.07.13.46.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 13:46:12 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 15/53] semihosting: Remove GDB_O_BINARY Date: Tue, 7 Jun 2022 13:45:19 -0700 Message-Id: <20220607204557.658541-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220607204557.658541-1-richard.henderson@linaro.org> References: <20220607204557.658541-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UPPERCASE_50_75=0.008 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The value is zero, and gdb always opens files in binary mode. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- semihosting/arm-compat-semi.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index cebbad2355..92c1375b15 100644 --- a/semihosting/arm-compat-semi.c +++ b/semihosting/arm-compat-semi.c @@ -92,21 +92,20 @@ #define GDB_O_APPEND 0x008 #define GDB_O_CREAT 0x200 #define GDB_O_TRUNC 0x400 -#define GDB_O_BINARY 0 static int gdb_open_modeflags[12] = { GDB_O_RDONLY, - GDB_O_RDONLY | GDB_O_BINARY, + GDB_O_RDONLY, + GDB_O_RDWR, GDB_O_RDWR, - GDB_O_RDWR | GDB_O_BINARY, GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC, - GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC | GDB_O_BINARY, + GDB_O_WRONLY | GDB_O_CREAT | GDB_O_TRUNC, + GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC, GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC, - GDB_O_RDWR | GDB_O_CREAT | GDB_O_TRUNC | GDB_O_BINARY, GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND, - GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND | GDB_O_BINARY, + GDB_O_WRONLY | GDB_O_CREAT | GDB_O_APPEND, + GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND, GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND, - GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND | GDB_O_BINARY }; static int open_modeflags[12] = {