From patchwork Thu Jun 2 11:58:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 578111 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5806:0:0:0:0 with SMTP id j6csp501038max; Thu, 2 Jun 2022 05:40:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMiQ74xsTk7wq9vrClgi6nDflocVt2I0y9FPxUD0+emLInM84zcAXd3p2v0IMOrpF2FYXS X-Received: by 2002:a05:6214:301b:b0:462:5d73:3e6d with SMTP id ke27-20020a056214301b00b004625d733e6dmr38949090qvb.114.1654173615748; Thu, 02 Jun 2022 05:40:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654173615; cv=none; d=google.com; s=arc-20160816; b=WDXm03Cuq7hYOANcm0CbbrIC+z+Edoq2KoTZtnuzxUpIe90bhVQT4hYkMvRS1jNVq8 AAjLhxEgnQqz4bGZuGtF7d5dWnoNkhOgy1raNpOZltjbYI5DBEmKl7PoLorKkGtA42es kzn5uhxlJfE8mlwEE6tuKIG18cX89vC5pNb7WFRjjtvKW/jIeTcVn5uPGpQ1hBZdLHO1 zb0A3LbqWGl8iR1uu/7b8f3m4nBo3Vf3UY/sjD3HHf6u8BY8gNhPB2UuEaq4trwIMaN7 Z/pClra+dpWeD3tc5eV44js89MgwVLGSqnhdsiCdRvH1n8DJnaW9LIDC2/9Iztu2BV6S bbTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=YXGeSST9Ofa/LUdyDFbNMXWsoXNI/iBkynvqPZH9cCQ=; b=CE6/y/flq6k+eDhhEc+N6oLOANValLT6U53AbQrTUvhGaFDQ3PPn5qO3VI38/PV6q6 LqbGhNF5Tn8xzzQuxaiPlKLqEIe8r0a8wOM8BqaAgrMOzSSV5WVyidLq3C78S5kqXsYA kRnBOrIwL/FsL6fJCdyH4S6MQHhjtx/Zyc8kcAErXEqAj9OKYmJNs/8WPgK3gSV+Krih yp2bcmtVU6zGOWN7FJUerKXYYLocaxwE7bdmxz3jISso+HxglojnpgeqL19PxT5JlbGU Grs3+PX1xq8suCkwgU+lAWzAfcWSnPxQ2dyszzxLeuhZ4zfBHlZaTphUIe4n1Z9NDwkn zNpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q18-20020a05622a04d200b00301b64dc7dasi2278467qtx.674.2022.06.02.05.40.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Jun 2022 05:40:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:56714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwk7b-0005fr-BV for patch@linaro.org; Thu, 02 Jun 2022 08:40:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTZ-0000or-61 for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:53 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTX-0001GW-Ja for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:52 -0400 Received: from quad ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MC2wN-1o4fxE2OSL-00COGj; Thu, 02 Jun 2022 13:58:41 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= Subject: [PULL 05/19] target/m68k: Fix coding style in m68k_interrupt_all Date: Thu, 2 Jun 2022 13:58:23 +0200 Message-Id: <20220602115837.2013918-6-laurent@vivier.eu> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220602115837.2013918-1-laurent@vivier.eu> References: <20220602115837.2013918-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:S55jd4+FUU0Vu9TAGkeOUB3CV1u0XwpWiXYOfZy19ai6P5wpb/P MMJiq2Nj0Tl5E6JUMAmBo4CKNxZRLUqTXA23fJ5ZwWKtESsT5PJVxLhlvHWTEh8Lb5Vx50W vhszdFW+seo9bnYmTAejVGvOCkWyRWZOng6663MQQDqnDBmD6csGDpvHYDySVGaRxxsCbYa XM+92adDTGzr71F+0eSmA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Gjdxg35eqg0=:bsLqbKjB79LAKo5EXwgCmH xeovS/c19ZxfIO9tcyz7SlSs4a5v4ldj8QnVcM8KKqTw8+7IVFR2P4u9wJQvErZudQtzbL4zo TupvDjCa2VfSKqHoExvwOWiKQDX68opFxbAiAnP148gcurOA8NZvhMUZZPfcqgrTUxe0PTXqq cbv/LJZal9b9S1NUndXfAsitJ0m1/YcL2PiOHYnhZtTu+n4Slr4vb7YaqnFCI1YDF9+/PmLpJ fu/PkrZOPYbAzlry8zillZXGC22RXEVsro5wCJE2Aeem9MP+JSikZRl6VwO4mXor/cp/KaBlT Drpw8w+I0NUWvbwfpSHs4dKmc0SGSjVKn3Ju0gt1qGOpDA1+nMm9hOAnc88yFjEEr2wg79vne xogyUbIHjCg1GfSfq4fdCKo3haJyEh9aqOKcQ47qU9kqfkBTocMEx7pTYUqE4Dcjg7k1JOoc5 twfBhUujH2lE+2TdeuHpiXTVgsZccmRZV93w9mj7GcAHJlyTqKqp4IHvNT7sMCwQyN4HtEkig LaW9poppH7jr1EbFUqLZvO9+9xAkY/Pgm41ZI85wjg40Xb3xdEKfvlz8hrTeNLcd67VAvuKne 7HatHPig6QZsdn0L/y9CmTkbnnrGB9oxffrJl9GjEh+dhEB4xgHfU8uK5PDNtyPunpC/3iq0x Rjn2xovpQ1sKS8VFy0eEgpSag8IZ4ONdGnk+NMrPiKJRtVN2HCQPR9TkHoGpw5pDSXv34mlsd SohIsdJi0AjNcd+hHPOKs8Wxab1u/ldJowYOqw== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Add parenthesis around & vs &&. Remove assignment to sr in function call argument -- note that sr is unused after the call, so the assignment was never needed, only the result of the & expression. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Message-Id: <20220602013401.303699-4-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- target/m68k/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 2b94a6ec84de..0f41c2dce3cc 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw) break; case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7: - if (is_hw && oldsr & SR_M) { + if (is_hw && (oldsr & SR_M)) { do_stack_frame(env, &sp, 0, oldsr, 0, retaddr); oldsr = sr; env->aregs[7] = sp; - cpu_m68k_set_sr(env, sr &= ~SR_M); + cpu_m68k_set_sr(env, sr & ~SR_M); sp = env->aregs[7]; if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) { sp &= ~1;