From patchwork Thu Jun 2 11:58:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 578104 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5806:0:0:0:0 with SMTP id j6csp487160max; Thu, 2 Jun 2022 05:21:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR22bRJctKFLax9tv1JhRJ6+YzAuwLRki4M7bI+gbtPNN2qXZyk8Wsg+NeszuBY7gtKp2a X-Received: by 2002:ac8:7d4b:0:b0:2f3:e185:efd4 with SMTP id h11-20020ac87d4b000000b002f3e185efd4mr3342354qtb.392.1654172506360; Thu, 02 Jun 2022 05:21:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654172506; cv=none; d=google.com; s=arc-20160816; b=fA7UEZ2V40pmFgEs7t5t1ulbxrL6K6oxEGMUqtRbfOyl0h9mp9VaomtQHHfYAsfaID VqEK3QMoeUK37ysNUR5nB0DCs+Y01rFRe/xSRRQofLCEGMiqPLE7bXEBeFdPSOvOxdno JVvzsbyAkjdxU5rxna2iHcq1opGWL4FemolY/zSMUCQ8QBT3mwmUSsqFhycZP25dQUul QbXpysMG0KEFTe8jpDrFV/ZiaM1XrgV1is6iY3Jk/fi/q7+qIcks89YBc8o8VldDdWXI QyaMO0wFnmaXoLWNwETs/X+7J62D8j5raIIlzO5GXZ2hyyy6yn/W+Y4o3bK2xaR6Csji C6Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=bcBu54h7+tbDtklrFWfENIqWH47Ct57YyirVnw34q7U=; b=T8peFWkkgBxLnGRrsRwbI+VjYKKjgecD5tc2mSBHhuHNFqvpaBOYxVNbV4E1KnkXlw CQZVogf3JV8i4Lh+zbS5xDVOmF56hY9DKWwAvOYvu4g7ILRb6RNadxaCt0hxCo1h1mTd GDCLrjeC7nRhR++0m1s+AKVEoEZb7I8XusHGiUFCCAj+58E+4LNRhb5YeXA3o2D52WME lo386H+O6S1HN8O5i6/01jmmtvaV848/Ws57K7cy0bYxGMgW8VAM4pxOM8cMCnBLyThr 1HCbgdnP+bi2A4TGd3J/9+SllUFe1kZv21+Yh47M5ajP/CDKRnZO3X+sFQmqrLsh3Aen 1+RQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s13-20020a05620a0bcd00b006a57a0a0143si2255118qki.303.2022.06.02.05.21.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Jun 2022 05:21:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:54930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwjph-0002Fs-Uc for patch@linaro.org; Thu, 02 Jun 2022 08:21:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTe-00012y-Jb for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:58 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:39111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTd-0001HA-2E for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:58 -0400 Received: from quad ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MDykM-1o6apP0V6q-009vQS; Thu, 02 Jun 2022 13:58:47 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= Subject: [PULL 17/19] linux-user/strace: Use is_error in print_syscall_err Date: Thu, 2 Jun 2022 13:58:35 +0200 Message-Id: <20220602115837.2013918-18-laurent@vivier.eu> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220602115837.2013918-1-laurent@vivier.eu> References: <20220602115837.2013918-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:XWErTcrZ6W5JxPdOk3q0B2fTn1s115yHePcBVlGBw46nDI3KZJw JQIQy/SIJwh3UqaapA8CPrCDw9Yrp9XcUsWIoePE6cjqwZ6T6uzA6FCjpCu8aJYp7AykLbJ VlXfd4NgmXg6OCRpaFfPklD77p8u2DEIbaIk9qrCpo1j5/n8AWufHGVJvjYarDunAk+nsyE TGIAE8hhatX8npu+GgCIw== X-UI-Out-Filterresults: notjunk:1;V03:K0:EM9Dr8HJ7BY=:/TYFpVVxoDDSBa3VMK7+HH gTASeUxFvDLe+YvyXJKWdqjFzUjJBOyiAEf1nS4RQ+/ahem/PYYZuX+APOnjf3fQC9O4U3Qmq 9j9SHmRwFzICUmuLbdmevg7UMF6RTkdASUzvGCfKS98LQO/inOPl4zQSLJ/1VmyblLIspvdNI nxahldfng0CNVgYkX81C0w7bpul71PNhgMwBLzGSvl1UZ0M2AIzthX92l9GIDhA2/0NKL/oXe P3VDfYfQpvV7qQsmc71Z3fy486yo2NxSccVN5zVgBeaRM1S1Z+wOsVXTNuzBekb+nMnXDNJT7 IV6tPBq2Z61xJH8AX6zIkGs+ZRo8tI3LdeCmc2HAZNgUvVrdvRHrdtyszSKPW4+WBQKAsEvjk 2ESVoYZcR2VviA72HiIngGHOUnyo/meOZM+ezySvuwhfWbNG39NaT6VtZ1nuvMIbVuOZvDBxb dwRjBaaju0/Kmz+YW5OZwXdcUZUGr4qdRtAOk4HY+dgJXsQlPgtUfbCnfi4OZ8xr1g6gX/ieC s5VnkljkFrVeealawdUcN0aQKXk8dYR6VyCvD/V+xMln7MezKsfrQzegnKE67k/Osx4qFbF/5 RSPkI8sTlf4kd3TkuGd2NiC5lUaWoG0Iy/EPgeARF9fFi6Q79ErYgcKP5xHxlWOFxbBaDlb0g Ph4ovwF4XZnOE3miC6iOvqj3VYvqYFfV75S0FYZ4D2/pfLfkJdI+Asy/BZV2Yfn8HEUuaIh0H MHPcczzkHgEvVWMOsGrC08XRhMWpzOhqeTdaiw== Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Errors are not all negative numbers: use is_error. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220602013401.303699-16-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 9fa681dea9bb..7d882526da03 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -689,7 +689,7 @@ print_syscall_err(abi_long ret) const char *errstr; qemu_log(" = "); - if (ret < 0) { + if (is_error(ret)) { errstr = target_strerror(-ret); if (errstr) { qemu_log("-1 errno=%d (%s)", (int)-ret, errstr);