From patchwork Thu Jun 2 01:34:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 578077 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5806:0:0:0:0 with SMTP id j6csp104079max; Wed, 1 Jun 2022 18:36:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgXA+G1eVNfd3pAREbdz9YwgWgZiC8Mv3UpprKoua8cEV2IdPMw5wIrGQ8o4P54HbEx1ob X-Received: by 2002:ac8:7d82:0:b0:304:b091:e44 with SMTP id c2-20020ac87d82000000b00304b0910e44mr2123224qtd.44.1654133798222; Wed, 01 Jun 2022 18:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654133798; cv=none; d=google.com; s=arc-20160816; b=S9bZymRvqzARSy4X6t1hNMfd02n/OYmQOT43lFNZl/Ai7zugDNsIeM7jFNgldC7lUg ICIZFOflOQM7GlPp5Xf1pN1OaPdMIFsYanGl5kJtu+0IMSxPEMzQ0V8T90XtPB5abvJx mmZMjv19R22wKtRyRG4acKqCL1gUbhm0QaMo/uEWM5mRr9gFNOesbUNxzJk6mD8kmKMR /cMk/oYtIoP93JXugVzRN7eWJQPSZDN7HRfADicA9wrBYuRaYudLKVxSRiRFDKve8dti J4Qy4vzNJFmp0zka+rcO5USwz02h94HHugNS/kEOuRIFojQHf3298BWh/6iI4+y7wZbJ mbpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IPe9v04jpSOnM1YqKXysVjOVagzaKcyYJ8pPspoxKJ4=; b=AsDbuYn4j7oME1Rv5GhiMpBsFLvoMAHGy4JfZnpno2y/DKGRTwznMFIOlFcoacWWR8 brfYE0IhSb9auo5+07TIgOSgAdcdnD6+fIWUd1JCZ17vTbAup6jGQTSRA41a0uAUsWun 2CkNfKGdU6bmurrhTff8w4PdU7iLWlolJU9uX1Hfh4BUboETzXp47tqgwMU6yEa8K3Nu A2II3Q+ijvCZl1sSt8zWd6AJ8JuPyBBPsPu7EJrKIXfqw6dCmweJ8+J6G52FjeVSn8Vo p3Q6e4bv3SwE4OkgbdUoNfjp5LR8Lkf9293CpZf+gmKTxixeLIvI+BP2Hudrr/jk6dKD lIOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KLGBU8ui; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k8-20020ae9f108000000b006a3aa17d5c5si1680153qkg.603.2022.06.01.18.36.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Jun 2022 18:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KLGBU8ui; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwZlN-0002s3-RC for patch@linaro.org; Wed, 01 Jun 2022 21:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwZjM-0002jM-Si for qemu-devel@nongnu.org; Wed, 01 Jun 2022 21:34:32 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:36663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwZjJ-0005IU-S3 for qemu-devel@nongnu.org; Wed, 01 Jun 2022 21:34:32 -0400 Received: by mail-pf1-x434.google.com with SMTP id 15so3479152pfy.3 for ; Wed, 01 Jun 2022 18:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IPe9v04jpSOnM1YqKXysVjOVagzaKcyYJ8pPspoxKJ4=; b=KLGBU8uibNZIo+WGaor6RMr1kjNUFZUCv7ItcJT01nBneqfG6A0yC/10tT1cMDwrDH pmA/KWgEdiapfuy5AGRdUub5XGGGj3Rcqp76d28SIAuB244ClQSTQR+mjSYlldqWCeVZ WeqcFmU6mG/atr4gF5rpvP1ahAj3LzcSX5pWulM1/4AQjP/WeUpnDbiXjkWNBPYSJ2/N Zp3akOan5ZckcY4MM8ep0Oyg4fGt7Iy/jax0i1tCse4g7tftLP2HmPoFOeq+K3vuqIea 2xAxdEJSy+1V1GxAlnp10lA6qk+OjmIcobLFqJ9pTgiomOgaJneGl1tqYqwLtaMf0GMx Sh7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IPe9v04jpSOnM1YqKXysVjOVagzaKcyYJ8pPspoxKJ4=; b=rVin2d0N9ieSgr53WDMFYZk52eC7zU1p0Hx+rnj1uS2QSyVW+ywz/dXBLiNCbGAime wcsocazsrpskzAs6M0YkfhlaeMPIV+DU5RHwnzgIOCgHm3xG2jy7M5IOuK4kmnqRpVSQ ROoeyL39JULtFzO9wLdpwICFG/Bqyy2Ncxh42oxpSxfGqBCZvVAVVKCwBntdvv70V9fH R34kk51v3zEpnlq6hFzMkTj5H8B9NWH/caLEp8QAlW4XpuDrdN7X7DQzb08hhowqk9EU 0FJ4aSUiS+L64KdI3QmeT60TS2L7a7ndHhCcXpfbRGjqZepaUWqTyBn8KRE5dWbXicax 0yWQ== X-Gm-Message-State: AOAM532tcoArwnllVHMZiahBCSC37bpMOD1FdcBSQ+2/AvHPJ38MBWis OrGrGJY3d7840JY6s9IFhOPMJSodqDlqzw== X-Received: by 2002:a63:8842:0:b0:3fc:64b0:cacd with SMTP id l63-20020a638842000000b003fc64b0cacdmr2009607pgd.490.1654133664380; Wed, 01 Jun 2022 18:34:24 -0700 (PDT) Received: from stoup.. ([2602:ae:1547:e101:1eca:8ee3:9269:e00c]) by smtp.gmail.com with ESMTPSA id l191-20020a6391c8000000b003fc5b1db26fsm1962875pge.52.2022.06.01.18.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 18:34:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v6 17/17] target/m68k: Mark helper_raise_exception as noreturn Date: Wed, 1 Jun 2022 18:34:01 -0700 Message-Id: <20220602013401.303699-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220602013401.303699-1-richard.henderson@linaro.org> References: <20220602013401.303699-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Also mark raise_exception_ra and raise_exception, lest we generate a warning about helper_raise_exception returning. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/helper.h | 2 +- target/m68k/op_helper.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/helper.h b/target/m68k/helper.h index f016c4c1c2..c9bed2b884 100644 --- a/target/m68k/helper.h +++ b/target/m68k/helper.h @@ -109,7 +109,7 @@ DEF_HELPER_3(set_mac_extu, void, env, i32, i32) DEF_HELPER_2(flush_flags, void, env, i32) DEF_HELPER_2(set_ccr, void, env, i32) DEF_HELPER_FLAGS_1(get_ccr, TCG_CALL_NO_WG_SE, i32, env) -DEF_HELPER_2(raise_exception, void, env, i32) +DEF_HELPER_2(raise_exception, noreturn, env, i32) DEF_HELPER_FLAGS_3(bfffo_reg, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 61948d92bb..d9937ca8dc 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -532,7 +532,8 @@ bool m68k_cpu_exec_interrupt(CPUState *cs, int interrupt_request) #endif /* !CONFIG_USER_ONLY */ -static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) +G_NORETURN static void +raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) { CPUState *cs = env_cpu(env); @@ -540,7 +541,7 @@ static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) cpu_loop_exit_restore(cs, raddr); } -static void raise_exception(CPUM68KState *env, int tt) +G_NORETURN static void raise_exception(CPUM68KState *env, int tt) { raise_exception_ra(env, tt, 0); }