From patchwork Mon May 30 16:06:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 577283 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:330b:0:0:0:0 with SMTP id f11csp449103mag; Mon, 30 May 2022 10:46:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi87zhzdY3JBgqAWDydgBmi/JWIz/kMb+0gAAc/LnWEV1Ha4xMgTV/Ls2Bu7W+g10pdG65 X-Received: by 2002:a05:6214:242e:b0:464:5c29:ac8f with SMTP id gy14-20020a056214242e00b004645c29ac8fmr1174214qvb.121.1653932777954; Mon, 30 May 2022 10:46:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653932777; cv=none; d=google.com; s=arc-20160816; b=eCaS1V39P5Wsl1tB6i+nUoEK9JJkiPY3axi8JtB2Jx0JwzmQ7KNl+mnTyPlpgV8E5m aNYw4tQBtSJD0EGM2xDS+A5zOV+z0yb7WzI2KcMBSTCvPkyDGMLesVM2sWQ72M38zPop e0P4B/WqNViamUyvZYGt5dyu2iHxuQXYXWTwu6AaOFnBzM36455snPXREifW30H8/Twm I2jYRd4BlX7pm1y+JlixpouZBkVGrhOIfEOBnTZw2UBberkMOagu1jPD8iLjMi2inM58 oS7iFnK2aUfOUjFXwSx9f8O/A+AtM+fPXkq8M6NrLvll14zTrb1LDqEHJDIM4xs66ois 3Ukw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=U5MdDTiCJ0I6T7wLRHuDD2GNLTYgYp2l3D7QRQQkOXg=; b=0tfMef+YtW8rw24ZOfQ155OxFBR7fo2TI79yqX+8FM3QBMkzXSKL+dy2iameoCxT2n JFnYHghx6jlDeXdGTmnFG1G2k8wO586IGS2N7vxZJJHZKkkSL575OCMXWCx9j09l9Hjs irjPPnWKYsvNmzJIeKIaMxo6EaNK6ozvoSC1vz2pKT6bTbAtc7qE5aEFsp6ml8uzp4Z/ NyqtbL7r3QPi8Ey7eHHpRmstx5NR4cEEqSEBww5+5lesNe4o0dEWc9fLpQRkJj2TL0/C 0TZBDYz4Am00gIPOWGbOTI1oNvtl+tTUFYl+irdPKohPa29twOsbprMFm3BKbVGH0vTS mSaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sCjsZod8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q10-20020ad45caa000000b0046235bdc492si2588033qvh.288.2022.05.30.10.46.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 May 2022 10:46:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sCjsZod8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvjT7-0001Vd-GC for patch@linaro.org; Mon, 30 May 2022 13:46:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvhwb-00043w-Pl for qemu-devel@nongnu.org; Mon, 30 May 2022 12:08:37 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:35748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvhwa-0007MD-1Z for qemu-devel@nongnu.org; Mon, 30 May 2022 12:08:37 -0400 Received: by mail-wr1-x434.google.com with SMTP id q21so4089541wra.2 for ; Mon, 30 May 2022 09:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=U5MdDTiCJ0I6T7wLRHuDD2GNLTYgYp2l3D7QRQQkOXg=; b=sCjsZod86v6hm7SE6ou4H5sOra37jbEOEu3aamV//yTzNLQ/4C9HtmSUlTXF+DoDST haz8yBTjg1lKEvfPZcPY6CdRZS2wwLRLnGP7gnyxkhDRdjQqfKXpxZAyK2Ib4jjS5P3c KbN1sJhJ3iTcqPF3/hXfOWcchiFxnKCB/OhMALu1V2L5lbz9EV/6UwStY1/GjrCfBuDH eAcf721kDow4mKmDgdIdiahznEVVIni6z8TkKhnmmFbWXBI9Hc6mz54QeWy4oej1/pEE G4L+UHbeT90Th593Dt0SS8PvUPHVthIWbLzOjVkTyC8xQVjTWQkL0tmMPkgh7n2iRgEj nu4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U5MdDTiCJ0I6T7wLRHuDD2GNLTYgYp2l3D7QRQQkOXg=; b=i84vdvpyCNFDuTnH/bbnJ4xx11NWsHUteYNoIAJXYXi2/3/00LsCdr18kxjU1cchCa wwLs0iJ5Hd3CqGr4mE7oQbq2URAlPTFMDcTy4W9qaEHrVqEaZJrGIFEaMDhUlVIaFevK 1TPfhVZqVE5VhAZe6HL7MyfHIAo6hJ7WawBSw9XKo7EX2xWjoryP0w+ogVFIt406jObv SUB29I9yRkDx0w04mf6mCmG604oxS3n4/BVyuUAZAvTQ9EcgUBgmf36/AKnkN8eutoWY 0snAixh1ExrdSYmD6z533vVG+Mm4uqd7OZAVnZRygL9b+AIWu4Nr8xPv1Xqf4MWL4Plv lEHg== X-Gm-Message-State: AOAM530wwg8H/mZ28tAsDVKj8S0g4aDtTPgsvjrm0gJ3aPFfBdUSXPdS 3wH8XHlpYCUbuy/LQefoj+crRIrhfZxfsg== X-Received: by 2002:a05:6000:16ca:b0:210:3d2:9bae with SMTP id h10-20020a05600016ca00b0021003d29baemr20318394wrf.311.1653926912955; Mon, 30 May 2022 09:08:32 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi12-20020a05600c3d8c00b003974b95d897sm10232152wmb.37.2022.05.30.09.08.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 09:08:32 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 092/117] target/arm: Move null function and sve check into do_reduce Date: Mon, 30 May 2022 17:06:43 +0100 Message-Id: <20220530160708.726466-93-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220530160708.726466-1-peter.maydell@linaro.org> References: <20220530160708.726466-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20220527181907.189259-90-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 11e4b4e1e4a..0d71072f837 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -3572,15 +3572,24 @@ TRANS_FEAT(FMUL_zzx, aa64_sve, gen_gvec_fpst_zzz, typedef void gen_helper_fp_reduce(TCGv_i64, TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_i32); -static void do_reduce(DisasContext *s, arg_rpr_esz *a, +static bool do_reduce(DisasContext *s, arg_rpr_esz *a, gen_helper_fp_reduce *fn) { - unsigned vsz = vec_full_reg_size(s); - unsigned p2vsz = pow2ceil(vsz); - TCGv_i32 t_desc = tcg_constant_i32(simd_desc(vsz, vsz, p2vsz)); + unsigned vsz, p2vsz; + TCGv_i32 t_desc; TCGv_ptr t_zn, t_pg, status; TCGv_i64 temp; + if (fn == NULL) { + return false; + } + if (!sve_access_check(s)) { + return true; + } + + vsz = vec_full_reg_size(s); + p2vsz = pow2ceil(vsz); + t_desc = tcg_constant_i32(simd_desc(vsz, vsz, p2vsz)); temp = tcg_temp_new_i64(); t_zn = tcg_temp_new_ptr(); t_pg = tcg_temp_new_ptr(); @@ -3596,23 +3605,18 @@ static void do_reduce(DisasContext *s, arg_rpr_esz *a, write_fp_dreg(s, a->rd, temp); tcg_temp_free_i64(temp); + return true; } #define DO_VPZ(NAME, name) \ static bool trans_##NAME(DisasContext *s, arg_rpr_esz *a) \ { \ - static gen_helper_fp_reduce * const fns[3] = { \ - gen_helper_sve_##name##_h, \ + static gen_helper_fp_reduce * const fns[4] = { \ + NULL, gen_helper_sve_##name##_h, \ gen_helper_sve_##name##_s, \ gen_helper_sve_##name##_d, \ }; \ - if (a->esz == 0) { \ - return false; \ - } \ - if (sve_access_check(s)) { \ - do_reduce(s, a, fns[a->esz - 1]); \ - } \ - return true; \ + return do_reduce(s, a, fns[a->esz]); \ } DO_VPZ(FADDV, faddv)