From patchwork Mon May 30 16:05:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 577234 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:330b:0:0:0:0 with SMTP id f11csp409504mag; Mon, 30 May 2022 09:55:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxX4KL2cM0tAI8gEwGVhVjHuewCKaQdbTACmh1GeTjgzzsd9Hk6p2xepfj0eQsQvFeiFnvj X-Received: by 2002:a05:620a:91b:b0:6a3:7c85:75f3 with SMTP id v27-20020a05620a091b00b006a37c8575f3mr28289601qkv.583.1653929704412; Mon, 30 May 2022 09:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653929704; cv=none; d=google.com; s=arc-20160816; b=d9cL0LyYPsaELDrwgoBtCNlq9yIrSJujnGOHg6xKJTqwRZezgPHGVCcvjLtKChhojD Xo7d5nnvrn97B9wCdBK3RVGf5d6hrsbi+AjG+jN8Slm+97sY7CWEEDlq0ILTMqU17o52 Ss8f/2x7fpDXLVsimfJ+zKplPE7gJ0jeYRThrN5/ve7BdBhOCBc8HgwwB6+X1d5yRp9v F8TL+psT8Mgf40kDq5W9ElrF4uyHIfw0gAeEr7oAd6zBwKdCYOdbqxVBPiVLZ2aY3cuH jG5kUIWYio6HWcKTHQmiMMlKmVQ435/xqlUh+I3dipfAkS2yVZ7fh7lYTJaAyGxSOw79 tiYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=r5qhhsn0mn03eMfaTsnMqO5VRQUM6D3Dyd4VEozedA8=; b=NjwbE+9usL+J+4h/EWw1S1bft7jNe0aeEPXnFH6HIfXNQX0fuD4MJ3YMgqh7Kwq8+H izUAlMZj87dZujTmY9Q2FR3Ik05g4sV3EWTSkL/eT+M2ycJBWBd9yBze7QED0ZsmsTve mlt9Ote0joMOm19H52ZXLM3Wo5ZGj5rLd+ACrH7fPPm5QylFKYRyHNMJ4AKr5xaJeRdj FHtFed5wwpEQodcSNvO7d8TTr/stso/6czkQ/Kbu7trzj2N9fyqD70BHn3NB1526HycQ Rc0uFw/KmWapzZhIEF3dFr72ZF4kMrr7GKtOoM6yZttuLHFmrpXDkpXrtvDwVNuPUGCH ruSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yi2uUxwy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d20-20020a05622a05d400b00304b50c8e97si1270571qtb.364.2022.05.30.09.55.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 May 2022 09:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yi2uUxwy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvifY-00047s-02 for patch@linaro.org; Mon, 30 May 2022 12:55:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvhvl-0003Pe-Pr for qemu-devel@nongnu.org; Mon, 30 May 2022 12:07:45 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:34543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvhvj-0007By-Mo for qemu-devel@nongnu.org; Mon, 30 May 2022 12:07:45 -0400 Received: by mail-wr1-x42f.google.com with SMTP id e2so15315033wrc.1 for ; Mon, 30 May 2022 09:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=r5qhhsn0mn03eMfaTsnMqO5VRQUM6D3Dyd4VEozedA8=; b=Yi2uUxwy9UrQNKP/Gcbnq1MAmUKXlQlPxbmU2IMT60bzNM+NXcXO4q8YP1t1ac6XGz oDM/NOhZGMhcHHSIw020SylhoU0Le9vI+DqqhKo9DfxkPBdchym5m15c8/Z171UqZX+C tzTKxgCpUIPVqCvClpVbab/AMvLa37D9Ly/o3TC6/03Y335lYsEIbae3to8pT3neGsjk Nv5WyeINGgiK4UaRrVqBiSSHNFB4so2b0aEvknqqR5T39eJ2ScyBBhdZa/gYUtAg2OtE bEIOt6S4wBIsfvCmlXyDSotK8k7Mb/kQbhnWq5Dmg8VNXJpYSpZIvV6bJLZWH3XfZgwY /fTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r5qhhsn0mn03eMfaTsnMqO5VRQUM6D3Dyd4VEozedA8=; b=6MS86CGUnLhInaWjX651PhqGLf794Axei78N3TFX+pvh8Uk0iPamAMDVBEnPOrzbW7 Pqs28MYqWSNHY8sKVGORgb2Tza1nRhn5mOKnCiVvwx2/x8Uyv7YyoCEEFRHay6LOtD4O hFbcmo/3BtVmeVw8ySG6iJFER6YDa9mbZm6rGb6oAepcwRXt1mBmoHONZgB5Je/j8xv+ Y0dSO2thlkZbWvzvSzFppF+hEm4Ao0cm3BlZnUrcEDrJPiT3OIIwJf/v6B+Xx7nQc/Kp WWNX7t0g6fSTFmRBnWoH22EN3+O/E8vLK5LWFUle+wuD66xg2YVna8dbD8HcynzQgsaX i/UA== X-Gm-Message-State: AOAM531Cjw16TjZjXA38IfweXdKHs44ShsW8ChfJj4vqVZSb4Mpoaqc4 pklChOLaVCjZ2Z3G6FR1c845VUGTaiMwog== X-Received: by 2002:a5d:4302:0:b0:210:824:48ee with SMTP id h2-20020a5d4302000000b00210082448eemr18896425wrq.471.1653926860552; Mon, 30 May 2022 09:07:40 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi12-20020a05600c3d8c00b003974b95d897sm10232152wmb.37.2022.05.30.09.07.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 09:07:40 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 038/117] target/arm: Use TRANS_FEAT for RAX1 Date: Mon, 30 May 2022 17:05:49 +0100 Message-Id: <20220530160708.726466-39-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220530160708.726466-1-peter.maydell@linaro.org> References: <20220530160708.726466-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The decode for RAX1 sets esz to MO_8, because that's what we use by default for "no esz present". We changed that to MO_64 during translation because it is more logical for the operation. However, the esz argument to gen_gvec_rax1 is unused and forces MO_64 within that function, so there is no need to do it here as well. Simplify to use gen_gvec_fn_arg_zzz and TRANS_FEAT. Signed-off-by: Richard Henderson Message-id: 20220527181907.189259-36-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index e92fef23041..36d739d7b2c 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -7814,13 +7814,7 @@ TRANS_FEAT(SM4E, aa64_sve2_sm4, gen_gvec_ool_arg_zzz, TRANS_FEAT(SM4EKEY, aa64_sve2_sm4, gen_gvec_ool_arg_zzz, gen_helper_crypto_sm4ekey, a, 0) -static bool trans_RAX1(DisasContext *s, arg_rrr_esz *a) -{ - if (!dc_isar_feature(aa64_sve2_sha3, s)) { - return false; - } - return gen_gvec_fn_zzz(s, gen_gvec_rax1, MO_64, a->rd, a->rn, a->rm); -} +TRANS_FEAT(RAX1, aa64_sve2_sha3, gen_gvec_fn_arg_zzz, gen_gvec_rax1, a) static bool trans_FCVTNT_sh(DisasContext *s, arg_rpr_esz *a) {