From patchwork Fri May 27 18:18:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 576590 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:8607:0:0:0:0 with SMTP id bb7csp914329mab; Fri, 27 May 2022 12:19:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytDyXcz3gRY6Rv8j17JDX61IMVuFuvtPSISDp5IJEsH236L1YtoXhriSGsWFizUeOGxFi8 X-Received: by 2002:a05:620a:d96:b0:67a:ee04:d947 with SMTP id q22-20020a05620a0d9600b0067aee04d947mr30571756qkl.237.1653679174287; Fri, 27 May 2022 12:19:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653679174; cv=none; d=google.com; s=arc-20160816; b=CYH7WtEA9XS9VhanDP5qajuUK+D3UQ0yqh7s8YC/7IRnZJDxQXrLGLbt+yytdi9U// 0Xc3h8W6m6dUEaP9NFQgwUUN8DuUzQlMxT7ZPJMmy0DvpoKHX/1LoD1QYSoBLN1ZovNh pXoSEY/VSpQwEENM6YBEpHPbNpStoDPdfiTB1+N44T8UN62BtyhVmdFzxxFaCmM7xg99 ui1Q/BjqZpxUg27ngtWj3sU4rOJr60cRTpfWn3ilDf6NPt2RYARkz+y3ECE+qac88oJs gAfl4QBoUcxZii2OAJotm8Kxp7vn6HX93jdATEJo+eXWoKAXx+5bRlFwMNZEmehQJ/VW DiMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6NR9ATMvKmhumYBvg99Iy+IXyN9viWesjZMf+MpW+xY=; b=z3b60KqMSEBT1q1W9Yd5jHDk6/zFmiOvBgMZcUautMrv5OfnqR7i/6QAqc3WzQDY5x 2SqJMgaFq5xx1mHPVIgwoTkjzBR/ZIXrW0VxO8lXMvKgF7+lA0t6B5YduDr0p/4A7MR6 dYl+aSmjJdVhJ1dwd02Db4moBIJLHrcb3KPE2OYWaTt8+U4PYP4SQF4s1LJCzUpR/W+R vMLQicgLxiqYfjdfR0lSomnYxeU1kCHTJ0KfRdfMi6Qg1Te0Y8KlbqBLZ4izw+11t52i scWbtOLc4mSRmEzcG29wy3hpseFo1T0VeJNYYqL2tixAYSa6luXfX9Yx6YmS6uFvbPWk 3Cdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BiM9RtxF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h3-20020ac87d43000000b002f3dcad046dsi3503838qtb.303.2022.05.27.12.19.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 May 2022 12:19:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BiM9RtxF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nufUj-0008HT-Qe for patch@linaro.org; Fri, 27 May 2022 15:19:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuecU-0003ok-93 for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:30 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:41492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuecK-0004UX-O8 for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:29 -0400 Received: by mail-pg1-x532.google.com with SMTP id e66so4561581pgc.8 for ; Fri, 27 May 2022 11:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6NR9ATMvKmhumYBvg99Iy+IXyN9viWesjZMf+MpW+xY=; b=BiM9RtxFufwUuqSXYqWteLQx1m1XzW6aIcQ6sTeM5WNKwtMCMcpo7MP8CxomT5+eUQ QfCE/XFKOxjNNpAlUjfcqqVEsBTOeUDXDAlJkR6fzOHDRO8Qh6eCrJydOZ1bTx2U491F j3aSwMzM8p1ip14CZI3OqLIDwtu9kdZGLLJdNTFYdO61JwIR5r4HDzcHQL7eB4DlJ/Yx UyLqCc+Z7iBWABA3DYCJ+caQMKG97eXHkZbKcjtXw9JeAcJqfIsG7T2tad5WH86Nrymt 37DZDeTgcZ4U+VLjS5Vk1fwTC4x7HTkfnfythfIOGkErBoQ9bF8tOA+aTguixx6Z4mog 0g0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6NR9ATMvKmhumYBvg99Iy+IXyN9viWesjZMf+MpW+xY=; b=tO6sjblEgCLAcvrAzsFIuFFRRW5YZHWf5GuV96XeHElmSZA+uUHrD5E4AjbXlsLS/T OnLM5RVWORI8l9A+440uFZ+BjE6v4XkyVx9jkwdqZTieYW7xLMMfpe9O6a9fPr/tCqUc gPPy7ed+dbodcy5Zt6KjQ6Dp6O6tdRheXt6rknSlTKSESsWdQEcj1NeAlNo5lTE72qBk vPKRquVlsjWMJNir463GLa55xtrQwztuC45VmAn82lMEnn+YOK1JRRSLucv0fUEtD883 ST1n1KVStDRD5Ma2cRS/6uqpE3Aw93zchBlO4GOQskC9riSADSk0IDQRqq2eUcuCJF2U I4jg== X-Gm-Message-State: AOAM530FPy3lDq56INeUC0DCN/i2um5AjuqCSgDL91z0Nh4aSjDRUA5I RtgJqR4NcTfbYx4J0kjNOn1gNLbFTZf5Bg== X-Received: by 2002:a63:82c3:0:b0:3fa:d8cb:f2c5 with SMTP id w186-20020a6382c3000000b003fad8cbf2c5mr13172227pgd.128.1653675795324; Fri, 27 May 2022 11:23:15 -0700 (PDT) Received: from stoup.. (174-21-71-225.tukw.qwest.net. [174.21.71.225]) by smtp.gmail.com with ESMTPSA id b15-20020a170903228f00b00163552a0953sm4033534plh.159.2022.05.27.11.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 11:23:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH 073/114] target/arm: Reject copy w/ shifted byte early Date: Fri, 27 May 2022 11:18:26 -0700 Message-Id: <20220527181907.189259-74-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220527181907.189259-1-richard.henderson@linaro.org> References: <20220527181907.189259-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Remove the unparsed extractions in trans_CPY_{m,z}_i which are intended to reject an 8-bit shift of an 8-bit constant for 8-bit element. Signed-off-by: Richard Henderson --- target/arm/sve.decode | 10 ++++++++-- target/arm/translate-sve.c | 6 ------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index 8cff63cf25..7e79198f5b 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decode @@ -528,8 +528,14 @@ DUPM 00000101 11 0000 dbm:13 rd:5 FCPY 00000101 .. 01 .... 110 imm:8 ..... @rdn_pg4 # SVE copy integer immediate (predicated) -CPY_m_i 00000101 .. 01 .... 01 . ........ ..... @rdn_pg4 imm=%sh8_i8s -CPY_z_i 00000101 .. 01 .... 00 . ........ ..... @rdn_pg4 imm=%sh8_i8s +{ + INVALID 00000101 00 01 ---- 01 1 -------- ----- + CPY_m_i 00000101 .. 01 .... 01 . ........ ..... @rdn_pg4 imm=%sh8_i8s +} +{ + INVALID 00000101 00 01 ---- 00 1 -------- ----- + CPY_z_i 00000101 .. 01 .... 00 . ........ ..... @rdn_pg4 imm=%sh8_i8s +} ### SVE Permute - Extract Group diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index bf988cab3e..83980f5ee6 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -2024,9 +2024,6 @@ static bool trans_FCPY(DisasContext *s, arg_FCPY *a) static bool trans_CPY_m_i(DisasContext *s, arg_rpri_esz *a) { - if (a->esz == 0 && extract32(s->insn, 13, 1)) { - return false; - } if (sve_access_check(s)) { do_cpy_m(s, a->esz, a->rd, a->rn, a->pg, tcg_constant_i64(a->imm)); } @@ -2040,9 +2037,6 @@ static bool trans_CPY_z_i(DisasContext *s, arg_CPY_z_i *a) gen_helper_sve_cpy_z_s, gen_helper_sve_cpy_z_d, }; - if (a->esz == 0 && extract32(s->insn, 13, 1)) { - return false; - } if (sve_access_check(s)) { unsigned vsz = vec_full_reg_size(s); tcg_gen_gvec_2i_ool(vec_full_reg_offset(s, a->rd),