From patchwork Fri May 27 18:18:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 576594 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:8607:0:0:0:0 with SMTP id bb7csp916953mab; Fri, 27 May 2022 12:23:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZk59XzgDqFxCk5ZR0IqafonYnwRRwl1jmzBit9SWumcgiY8EOe/Kq70r85vnIwa0p/kMc X-Received: by 2002:a05:620a:2442:b0:6a5:a0ac:ab3a with SMTP id h2-20020a05620a244200b006a5a0acab3amr9560424qkn.32.1653679414523; Fri, 27 May 2022 12:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653679414; cv=none; d=google.com; s=arc-20160816; b=L4ci0MrO5RPs97XvQ1/Tdq0/P4gnm1I85htlrsGuVP0aGAvVt24Y7R6Dv+mcYKIuqe QeOQpj7O8X0LZIEwUt2RwgU39ar9S6IxiH0BBCiSFu3upd3xL6Prdil45sVxfwsX9imJ k+aMAwKRtx9rZ3Y41ISRVk6QKgTXbF8ZG4U9uGB9tQIMd0iMO8hLth92y4OgtPWA6Iq3 M2LtGg56UnQHzSDa43G+tBA4+w08H8MUsBxn+xnxDLIHSMUNNXVb7aVehu9GMLE+ag6D OWUvB51CDhkkMvxEdd1K7Gcd2nbN/NxWV9wBL36zNx7PcPC4uSnT9goHX7a/G+z4hWQO phpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2WEiKpEgenFmY1LO8ckyA77Vjve+XyxeM9X2y4QnZd0=; b=cMJDbbinSukUlTrkZ/C38UD2jR4Ie19QYUPRxZIj9HIe2vWIZjbhYR9rfgXnSy3WDW 0Gz3SZOMMOZpAr1rST6okKnzK2tuSwJWbnjCNhu4+uyFXy/TZ//y/XR5m1CYHUw7GqOF GKx6uPoSitosmL+E8+fGUU7vA+duWSwMG2Bj18VXMcbDBRL4hDxqd9ASXnGrvRnFvvOi 9JzDAqN6EspKxqgjIwNYMEnT6CTejOsOT046KVWEGX0f6LM4NjRFyhJwPFGEX78umGEE XQo88K8/K8GOA3ymm61v9N2vmIxYgjctpUQwVtXEhan26BuYbEVVNxImAbq1CAyxozVH PjWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fGD3fhVY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id kc24-20020a056214411800b004562cd810dbsi3382663qvb.200.2022.05.27.12.23.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 May 2022 12:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fGD3fhVY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nufYc-00073Y-5A for patch@linaro.org; Fri, 27 May 2022 15:23:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuecW-0003yp-Ud for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:32 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:45940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuecK-0004U7-QY for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:32 -0400 Received: by mail-pf1-x432.google.com with SMTP id b135so4961844pfb.12 for ; Fri, 27 May 2022 11:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2WEiKpEgenFmY1LO8ckyA77Vjve+XyxeM9X2y4QnZd0=; b=fGD3fhVYSWVuJiFEx9+AttEvuhEaBwJwAFRLlLaEM26A1yDbk2uaKeTr5tJuu6S+fN Augyrn5GuX/6KhyA8MqWre0rErDNlCnB7B0RE/RYfhLTk6aWFhWwj6S5DkUKQ1DZJ3Iw qbU9Sh3oywhbeuIpnG+SKQnmKVmp8Zt/r/hRPlH38z64bmMkASL9hMcjvX4+hK4LxdxT kqUIHSGKmbUC2Pjx0yBcjk+ZbfNyWdAE4jznIEiftHXudULNSGJnaZICexcmg98LNQHt 5EcbsdSfihf2KmhfZqnR81Ei4Q6hJP+MM3S2JvOYt3GGFP/NJyX044d6CG4bf93QVJQm BR+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2WEiKpEgenFmY1LO8ckyA77Vjve+XyxeM9X2y4QnZd0=; b=ebrH3rQUTpF8BbxUOhkXwhe+6IblIC3jJs6fWV8rrrZH385xLneejwIij6nmFqUeff xCOyMLPe0c08RLWTvd1tv4NHFJbHR1i1hWApDxsVYT2ifMD7IbHB/WkWf5mB8WApU5fE kT9MjQZk07Jrreonm78NohcCQP7u7yhGJAWnRPXMAxS41cSJuPmYk18iA8X/Tbb7VDwS UIUemFBw3yHGC+FGfdNhlpBvwdxMcUmT7pZwsxb56weGysVLxZUEhqkipdWmOzpjtzGV pIec3Ykvmprqu0C0GmWHK3FuUoS336GQ3sv1N/g8GWAdoV9enZUqKnEsM/lxhPBEde2q DRyg== X-Gm-Message-State: AOAM532jbZDuFukXs4+YVoOI8BuFw0sz9XK5dVTjw39Y15CGQCj+Bj5w LzjRTYYgoJZeG8bjIyvC1zgQzfKevjPD9A== X-Received: by 2002:a05:6a00:1acb:b0:518:986c:a7c4 with SMTP id f11-20020a056a001acb00b00518986ca7c4mr28090458pfv.2.1653675793490; Fri, 27 May 2022 11:23:13 -0700 (PDT) Received: from stoup.. (174-21-71-225.tukw.qwest.net. [174.21.71.225]) by smtp.gmail.com with ESMTPSA id b15-20020a170903228f00b00163552a0953sm4033534plh.159.2022.05.27.11.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 11:23:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH 071/114] target/arm: Reject dup_i w/ shifted byte early Date: Fri, 27 May 2022 11:18:24 -0700 Message-Id: <20220527181907.189259-72-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220527181907.189259-1-richard.henderson@linaro.org> References: <20220527181907.189259-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Remove the unparsed extraction in trans_DUP_i, which is intended to reject an 8-bit shift of an 8-bit constant for 8-bit element. Signed-off-by: Richard Henderson --- target/arm/sve.decode | 5 ++++- target/arm/translate-sve.c | 10 ++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index 0388cce3bd..c02da0a082 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decode @@ -787,7 +787,10 @@ WHILE_ptr 00100101 esz:2 1 rm:5 001 100 rn:5 rw:1 rd:4 FDUP 00100101 esz:2 111 00 1110 imm:8 rd:5 # SVE broadcast integer immediate (unpredicated) -DUP_i 00100101 esz:2 111 00 011 . ........ rd:5 imm=%sh8_i8s +{ + INVALID 00100101 00 111 00 011 1 -------- ----- + DUP_i 00100101 esz:2 111 00 011 . ........ rd:5 imm=%sh8_i8s +} # SVE integer add/subtract immediate (unpredicated) ADD_zzi 00100101 .. 100 000 11 . ........ ..... @rdn_sh_i8u diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index c0781ecf60..14faef0564 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -403,6 +403,12 @@ const uint64_t pred_esz_masks[4] = { 0x1111111111111111ull, 0x0101010101010101ull }; +static bool trans_INVALID(DisasContext *s, arg_INVALID *a) +{ + unallocated_encoding(s); + return true; +} + /* *** SVE Logical - Unpredicated Group */ @@ -3246,13 +3252,9 @@ static bool trans_FDUP(DisasContext *s, arg_FDUP *a) static bool trans_DUP_i(DisasContext *s, arg_DUP_i *a) { - if (a->esz == 0 && extract32(s->insn, 13, 1)) { - return false; - } if (sve_access_check(s)) { unsigned vsz = vec_full_reg_size(s); int dofs = vec_full_reg_offset(s, a->rd); - tcg_gen_gvec_dup_imm(a->esz, dofs, vsz, vsz, a->imm); } return true;