From patchwork Fri May 27 18:17:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 576604 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:8607:0:0:0:0 with SMTP id bb7csp923932mab; Fri, 27 May 2022 12:33:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSljlZx6RD/K5NPwRnbKrn31v5Q36LcvjmKixBM1iewxs9PpQ8S6WY+CuHZTjdH/4J3kfR X-Received: by 2002:a05:620a:22ae:b0:6a0:af9a:1dd4 with SMTP id p14-20020a05620a22ae00b006a0af9a1dd4mr28936826qkh.248.1653680019093; Fri, 27 May 2022 12:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653680019; cv=none; d=google.com; s=arc-20160816; b=F+M1X7PXaosx/tO566265UzFiEZQGy8Jh3AC21ePYGjRqGlesb2UVVDTYWYWY90hNq TmoXfmmXkEwDg7EfWmi3P9FshFQYRbY6zjrQrHfJpDgNiyegIjHrHdTNtOo8RoFqDSWy CUHSnnVlp+d6hNSwkaHqUXNGCFzpwdR/J+ZsFZB2cMPZK+6uRE4cJO8r7l206DDussa1 Z06Ws5Ba9TR3hxvuA9sZkEwtFCiw7TsmX9JNfvcKCtt08tgHqoUWBSikTlZzafsMwyxM Whtg5D6+NO6BcfrlW9Gx3bw5xH2MDTz/rYdCKCW4MrHZCSQfnAbkjfou6VymQ8S9zFBM 7JPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2WxAwM40s96Oyqh2/sR7/3CobKp3pYRH8H0LH0HfcWs=; b=J0HoHE5hLT2WsRpnn3PuPA7eI1W8sZ1CPdSB/SLM1mlUeO4rMysFZ207n934thLbvq g83jspjrbHh9hna9FVKTfHaMFYE6VudJPzaUMkDqDHSrCb7vuRFt80AJvHD7FSRgXuJf UZOY4bd24s/s/7poie4+zJHAgdAOYWhenxvOsht7mGFfogtVrv49+6+Iwgj/SDJUTr8F v6GBDRLaIFX2ss1xfufCmgJLB3CrAfGckOo0k4vkYF6+RVotxeBuiyehrZFvdENm4IK9 9jz8x43lyzKFrhH00/jyw3BTOBVAuOBl4Tnt2bj/lquzso+JmB3+K2ZRFKTbHtD3y31v bu7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LLDDS1Do; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c1-20020a05620a268100b006a36eb7ebe5si3507738qkp.156.2022.05.27.12.33.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 May 2022 12:33:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LLDDS1Do; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nufiM-0005Pk-KO for patch@linaro.org; Fri, 27 May 2022 15:33:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuec6-0003N1-4T for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:06 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:44645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuebx-0004JL-Up for qemu-devel@nongnu.org; Fri, 27 May 2022 14:23:04 -0400 Received: by mail-pj1-x1036.google.com with SMTP id pq9-20020a17090b3d8900b001df622bf81dso5018479pjb.3 for ; Fri, 27 May 2022 11:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2WxAwM40s96Oyqh2/sR7/3CobKp3pYRH8H0LH0HfcWs=; b=LLDDS1DozQuRO1nrYbyf+Y1SSXNozCvqd1llitSTuMvbI2QK+Cthb09XjWGWnmHJic ohQiXjRMTSP9gwVYMfRtO/bUh/7zCN+ph219CQasnpxIOlC0Rf+z3dRK83N5WNXln/S0 mutxe5GvFLka+31VyxCdltz6gHhQHk1LO5ZspDeGw/xPrI9f06n3Sk+551dOd/kvraVh kC0kvqEK5pzL6/sAgT+N01nI8iHaeOQFzZdp63/V5++pWjPyxw+mf9tr44oX1yPnnXk0 h3fu/Yh+NuWl9do4aUtV4tn74BySZL0rpy6QV897LCrQtlQsYDvI64rctRsbZqp/Ur10 rkyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2WxAwM40s96Oyqh2/sR7/3CobKp3pYRH8H0LH0HfcWs=; b=pyWmdEJLl0ToJ7qMBmJWdtZss96hqjJ6NiQnwZgLBzmZrA/0xVH+ZHf6roeSNVAOMX J+zn1bNwnKObczOWPCkC15RdVSGoAs6+2YA4tRunUS0AFnzdNxZlANbC+wOIZ5XUiLns VXlmF5SSVtSrXRh92QTbWtMZ+kqiLKUkeD9KO+NX29+ZKmnXHT6909x25KgtJK7k5DFg lhDNxkegduKZAM8NaODc745huUt6n4RpAyeonqUCCgNcSOFB37/BiXBHzJWjYN7nQYTm 5z2s1iAPnjD1dhP04ITvDJWdeoQmN/QKNRRombOa2Iz2mCqcWXwBy7dlmJPkJC0Xv/3I +uYA== X-Gm-Message-State: AOAM530xfm9Cz2CKaIUKkIzx/Yx6u46DGeNPy6nBF5U3/hsI0efXvkgf 7Bvgyphtu5TyjUx7yAFDQ3ShIbhAG8qaLg== X-Received: by 2002:a17:902:9303:b0:15f:446e:dccc with SMTP id bc3-20020a170902930300b0015f446edcccmr44854630plb.35.1653675767205; Fri, 27 May 2022 11:22:47 -0700 (PDT) Received: from stoup.. (174-21-71-225.tukw.qwest.net. [174.21.71.225]) by smtp.gmail.com with ESMTPSA id b15-20020a170903228f00b00163552a0953sm4033534plh.159.2022.05.27.11.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 11:22:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH 041/114] target/arm: Introduce gen_gvec_fn_arg_zzi Date: Fri, 27 May 2022 11:17:54 -0700 Message-Id: <20220527181907.189259-42-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220527181907.189259-1-richard.henderson@linaro.org> References: <20220527181907.189259-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We have two places that perform this particular operation. Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 62bfc6fe7c..7a3b5f137a 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -273,6 +273,16 @@ static bool gen_gvec_fn_zzi(DisasContext *s, GVecGen2iFn *gvec_fn, return true; } +static bool gen_gvec_fn_arg_zzi(DisasContext *s, GVecGen2iFn *gvec_fn, + arg_rri_esz *a) +{ + if (a->esz < 0) { + /* Invalid tsz encoding -- see tszimm_esz. */ + return false; + } + return gen_gvec_fn_zzi(s, gvec_fn, a->esz, a->rd, a->rn, a->imm); +} + /* Invoke a vector expander on three Zregs. */ static bool gen_gvec_fn_zzz(DisasContext *s, GVecGen3Fn *gvec_fn, int esz, int rd, int rn, int rm) @@ -3503,12 +3513,7 @@ static bool trans_ADD_zzi(DisasContext *s, arg_rri_esz *a) if (a->esz == 0 && extract32(s->insn, 13, 1)) { return false; } - if (sve_access_check(s)) { - unsigned vsz = vec_full_reg_size(s); - tcg_gen_gvec_addi(a->esz, vec_full_reg_offset(s, a->rd), - vec_full_reg_offset(s, a->rn), a->imm, vsz, vsz); - } - return true; + return gen_gvec_fn_arg_zzi(s, tcg_gen_gvec_addi, a); } static bool trans_SUB_zzi(DisasContext *s, arg_rri_esz *a) @@ -6825,10 +6830,10 @@ TRANS_FEAT(ADCLT, aa64_sve2, do_adcl, a, true) static bool do_sve2_fn2i(DisasContext *s, arg_rri_esz *a, GVecGen2iFn *fn) { - if (a->esz < 0 || !dc_isar_feature(aa64_sve2, s)) { + if (!dc_isar_feature(aa64_sve2, s)) { return false; } - return gen_gvec_fn_zzi(s, fn, a->esz, a->rd, a->rn, a->imm); + return gen_gvec_fn_arg_zzi(s, fn, a); } static bool trans_SSRA(DisasContext *s, arg_rri_esz *a)