From patchwork Sat Apr 30 17:53:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 568159 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp7378038map; Sat, 30 Apr 2022 11:10:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxli9YfPtFd0deXu22KM7Cg/vr1OESx4NvokAs4G6Du/hq1Nl39tNjbgD5Lp8+d+j2/Ok/x X-Received: by 2002:ac8:7d09:0:b0:2f3:677f:dd76 with SMTP id g9-20020ac87d09000000b002f3677fdd76mr4305724qtb.326.1651342250027; Sat, 30 Apr 2022 11:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651342250; cv=none; d=google.com; s=arc-20160816; b=gUPMXtbnhvJJCXHwewwutdOFYDbxw9CiCVQPEjtG7ktV8o8pz0MI7hDTILx9/zTcnX Y0ql3OIbkcnDjpPBO46mxNP4ok5NKFbapsg/PeNz+xRRTjUN/XGqpeXfBq9KqdBtjoPn meQ/rOjfzfELkKnX3vGUUNPJYjqzU2E4OF+MOpNnGp0op4vBK8flrKFqBQrZFG7tJJfS LzOIizvb8CSFmNnMmayGAxCLttCqBg1++Y1Zn1MDzqQXibirESBXfEvH1wyyXrwOZEKA gLaRT4xc4Gg0NZlNASQIzd/0QvKq/DCLHsMhDSlst19/K5AdAxwKXiC3nEPyVk1YokuJ uDHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=qLuJ3kY0B/Vq78Y89l2hbdJvKBIIYeH0UMXub8wd6WI=; b=ox8NZpMoa548cR2Pp/k0mYUprJ3OetfaURgv8bmFinaWp8t5p6cnR4m7jf1XjaAYvn r33USvBPoOhodY13bt8Z2mfa94TXucNcCXXz8cYZL2vk+33rvyOdPTUOj/x6cEPoYvOE iUJ71Zcr6OlLI4UcwxESBJ9+FHic+9HP5K8uFo3JOijukMJBfFQSla3YLDNd+XA/XibU 1PubSVec/J3BeOwiwz0fkhUzDknc1d2TXTJsVo1DPnJp1on90jElj+t6i7V4EYKiL6H/ xa3+1ycjYDVFW3yo3HlEwx26+dJI1aECacWJy2Jf97FqtXQ/vrsVO2ecDy2/whKbi2OL V4xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gQVkNqF3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l12-20020ad4472c000000b0044666032979si3828326qvz.547.2022.04.30.11.10.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Apr 2022 11:10:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gQVkNqF3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkrYP-0002Cu-Kh for patch@linaro.org; Sat, 30 Apr 2022 14:10:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkrIB-0004nj-AX for qemu-devel@nongnu.org; Sat, 30 Apr 2022 13:54:03 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkrI9-00084O-1L for qemu-devel@nongnu.org; Sat, 30 Apr 2022 13:54:03 -0400 Received: by mail-pg1-x533.google.com with SMTP id z21so8821421pgj.1 for ; Sat, 30 Apr 2022 10:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qLuJ3kY0B/Vq78Y89l2hbdJvKBIIYeH0UMXub8wd6WI=; b=gQVkNqF3Smny5Ybua0zY9Rz95BZwya97y1092Va/hLnU/oDJODFCW10cX11r/S/hyp 6MvzHJSrWNX8VddPFMZ5WRuHyoTXGsr/LuZuhMsiTWyBOapYhaLtMqEAFY6Xb8UXwvEI YtnLH9UYx/x0MKTvY0mY5BOX1EvoDD6C5j8jvr0oRmjswKf4thohwo+XL0fK5tPbrU/a exOAZxf87k3X39Sx2junLj/LxYwtvuV4iGOxGWSxHFAUmXG9fI/TqAYpbrKeUgHVJ7sN FVEqbNUIME21VEaa+cBnkFpDqLzD8ib7+EC+p5ujUPa4bTwYv0Qh/PF2//As+CkQzoUR hlfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qLuJ3kY0B/Vq78Y89l2hbdJvKBIIYeH0UMXub8wd6WI=; b=CweUmDF2aK0TgCQpRtMv9JvqKn02znV+0wQkqHgt+UQhWJHm0yIe8N1ekK1ntVxy3g cmsXide0K3wvJ8+/ZJjQjtQk6zEOE7JIw5EbCvJStv870Os7xwbdYvnaVEur0PPX1uqF cMI1EMBZrkg/Uwqs0OXw08COnEyP2bXm5aws90VJbPB0RL6wsPGEmqeup0Q+OTuC7MMI cegDlF6Fc0TsumO1nKf91fqLrlxJN/8Vqk02KZEVqecHYemM4tXcxkc/MrmKx7Ay/EhL 9bU1oNA+j3riXFyxgrU5lyWNKVG0p9xgluQbL5wWrjiApLhJPh6CpBGSBfLOn226R5V0 fsAA== X-Gm-Message-State: AOAM531XMROVhaiPOs75V3uKYZx2uBqH12qW851+KeXDqbAwFVZSCpID tx9Q/LKABqkmKJjHWYvBfIP9oshto57BLg== X-Received: by 2002:a05:6a00:1a06:b0:4fc:d6c5:f3d7 with SMTP id g6-20020a056a001a0600b004fcd6c5f3d7mr4315325pfv.53.1651341239810; Sat, 30 Apr 2022 10:53:59 -0700 (PDT) Received: from stoup.. ([71.212.142.129]) by smtp.gmail.com with ESMTPSA id 5-20020a170902c20500b0015e8d4eb282sm1740910pll.204.2022.04.30.10.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Apr 2022 10:53:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 17/17] target/m68k: Mark helper_raise_exception as noreturn Date: Sat, 30 Apr 2022 10:53:42 -0700 Message-Id: <20220430175342.370628-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220430175342.370628-1-richard.henderson@linaro.org> References: <20220430175342.370628-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Also mark raise_exception_ra and raise_exception, lest we generate a warning about helper_raise_exception returning. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- target/m68k/helper.h | 2 +- target/m68k/op_helper.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/helper.h b/target/m68k/helper.h index f016c4c1c2..c9bed2b884 100644 --- a/target/m68k/helper.h +++ b/target/m68k/helper.h @@ -109,7 +109,7 @@ DEF_HELPER_3(set_mac_extu, void, env, i32, i32) DEF_HELPER_2(flush_flags, void, env, i32) DEF_HELPER_2(set_ccr, void, env, i32) DEF_HELPER_FLAGS_1(get_ccr, TCG_CALL_NO_WG_SE, i32, env) -DEF_HELPER_2(raise_exception, void, env, i32) +DEF_HELPER_2(raise_exception, noreturn, env, i32) DEF_HELPER_FLAGS_3(bfffo_reg, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 61948d92bb..d9937ca8dc 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -532,7 +532,8 @@ bool m68k_cpu_exec_interrupt(CPUState *cs, int interrupt_request) #endif /* !CONFIG_USER_ONLY */ -static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) +G_NORETURN static void +raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) { CPUState *cs = env_cpu(env); @@ -540,7 +541,7 @@ static void raise_exception_ra(CPUM68KState *env, int tt, uintptr_t raddr) cpu_loop_exit_restore(cs, raddr); } -static void raise_exception(CPUM68KState *env, int tt) +G_NORETURN static void raise_exception(CPUM68KState *env, int tt) { raise_exception_ra(env, tt, 0); }