From patchwork Thu Apr 28 09:46:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 567143 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp5290034map; Thu, 28 Apr 2022 02:53:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVr7HTvky497lhubF7X34cbTp06WJktVVUjFdTYb+jvi4B3xwK9u7QqFbFMC7P06GK2A+1 X-Received: by 2002:ac8:7d09:0:b0:2f3:677f:dd76 with SMTP id g9-20020ac87d09000000b002f3677fdd76mr13910360qtb.326.1651139627559; Thu, 28 Apr 2022 02:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651139627; cv=none; d=google.com; s=arc-20160816; b=wxIzr5ojfiwnOELtVRpXD1ifXo10Olzi6+w7j7XUp+qbIbuVqIC19EOQ3ZqRH4EdIw mNj1QtcCaq6xVLL5uuA9x1hUlWMqJ/VGc1s3d2M/wB9nOs/OXnbfpqBYBxTMAYQVrWUq VAFfU3HwhCCVU9lt9zCr+hJcwyk6nOGRte4a9AQMmcZ3dQJlIRCWEUA7ygOAzbmSpOEl qfIUbXbUMc2IsGo09nlow1RjXrh4ONPeE3+G2Z+/3G69NLhEWn2yp3/yxa6TLcFG9gaC VuDuFQ4okVtD8ZiBvXCDWPkSYXKFaBCK1I8SN7NUM5QmEHS+FzGT8IoXN2QlmpC8vbTj ufvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nWTa/VK2W1usgH2WMO8nBJqO1YZe1fxR5G6cQyMlefc=; b=uejTTgnGjFGE5gdsDr7rPqpBr5rNGdGXxAi2SqsfMGkQv+J20DTJg9QoHmWdjwFIFv ITUmWh1T4eBECp5AcYNtgZfFcFUcX49g5BAo8R8iA+OiDMCvI56Fa+2P8SR8lE7e/gCs io+8MobTl6VRxE9aAWoYfh4uZ67QBZqCnTDrY4MrP/VGgVWvMev5O9+u86VpkdktlxL3 ecG3SSZktl4HZ/F1yEzfzIjo7bdg5UGfRxBiI1SBj3RrDvSI2+6LjGIufY/ttJGyoLR1 qReu8N60CLJqGeStqoY45sKCzdTSMECH8rEWjKVU4cHdCvElaaZ5R6aI93mfvv59AKcU GCXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CMilYL3n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o16-20020ac87c50000000b002f381de62cbsi1508501qtv.230.2022.04.28.02.53.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Apr 2022 02:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CMilYL3n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk0qI-000097-5M for patch@linaro.org; Thu, 28 Apr 2022 05:53:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk0k6-00035h-Ay for qemu-devel@nongnu.org; Thu, 28 Apr 2022 05:47:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk0k3-0008CA-NR for qemu-devel@nongnu.org; Thu, 28 Apr 2022 05:47:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651139238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nWTa/VK2W1usgH2WMO8nBJqO1YZe1fxR5G6cQyMlefc=; b=CMilYL3nnzGX07xcYCfwSmyLLioVJ8ktlH9mxRH7hhRWmQx6sBtJztT3wap1g9GmLKxrOq w3nthcCyCiD5u2Xh7RW4AUBgaH5BFMzYNuK9OS5aMXvu+YoeSnSjWCEj2KR9bc6soNIjRo 1wKkrvSGGX/Vv7BuMNHkhhuP9FjKOOg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-_mG9esfWNcCYDsWO0lyqow-1; Thu, 28 Apr 2022 05:47:14 -0400 X-MC-Unique: _mG9esfWNcCYDsWO0lyqow-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67587281AF02; Thu, 28 Apr 2022 09:47:14 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.194.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D5E140CF8FA; Thu, 28 Apr 2022 09:47:11 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v6 01/13] target/s390x: Fix writeback to v1 in helper_vstl Date: Thu, 28 Apr 2022 11:46:56 +0200 Message-Id: <20220428094708.84835-2-david@redhat.com> In-Reply-To: <20220428094708.84835-1-david@redhat.com> References: <20220428094708.84835-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Richard Henderson , Eric Farman , David Miller , Halil Pasic , qemu-s390x@nongnu.org, Christian Borntraeger Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH") Signed-off-by: Richard Henderson Reviewed-by: David Miller Reviewed-by: David Hildenbrand Tested-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/tcg/vec_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c index ededf13cf0..48d86722b2 100644 --- a/target/s390x/tcg/vec_helper.c +++ b/target/s390x/tcg/vec_helper.c @@ -200,7 +200,6 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, uint64_t addr, addr = wrap_address(env, addr + 8); cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC()); } else { - S390Vector tmp = {}; int i; for (i = 0; i < bytes; i++) { @@ -209,6 +208,5 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, uint64_t addr, cpu_stb_data_ra(env, addr, byte, GETPC()); addr = wrap_address(env, addr + 1); } - *(S390Vector *)v1 = tmp; } }