[23/47] target/arm: Use tcg_constant for disas_iwmmxt_insn

Message ID	20220426163043.100432-24-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 23/47] target/arm: Use tcg_constant for disas_iwmmxt_insn Date: Tue, 26 Apr 2022 09:30:19 -0700 Message-Id: <20220426163043.100432-24-richard.henderson@linaro.org> In-Reply-To: <20220426163043.100432-1-richard.henderson@linaro.org> References: <20220426163043.100432-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action Precedence: list Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	target/arm: Use tcg_constant \| expand [00/47] target/arm: Use tcg_constant [01/47] target/arm: Use tcg_constant in gen_probe_access [02/47] target/arm: Use tcg_constant in gen_mte_check* [03/47] target/arm: Use tcg_constant in gen_exception* [04/47] target/arm: Use tcg_constant in gen_adc_CC [05/47] target/arm: Use tcg_constant in handle_msr_i [06/47] target/arm: Use tcg_constant in handle_sys [07/47] target/arm: Use tcg_constant in disas_exc [08/47] target/arm: Use tcg_constant in gen_compare_and_swap_pair [09/47] target/arm: Use tcg_constant in disas_ld_lit [10/47] target/arm: Use tcg_constant in disas_ldst_* [11/47] target/arm: Use tcg_constant in disas_add_sum_imm* [12/47] target/arm: Use tcg_constant in disas_movw_imm [13/47] target/arm: Use tcg_constant in shift_reg_imm [14/47] target/arm: Use tcg_constant in disas_cond_select [15/47] target/arm: Use tcg_constant in handle_{rev16,crc32} [16/47] target/arm: Use tcg_constant in disas_data_proc_2src [17/47] target/arm: Use tcg_constant in disas_fp* [18/47] target/arm: Use tcg_constant in simd shift expanders [19/47] target/arm: Use tcg_constant in simd fp/int conversion [20/47] target/arm: Use tcg_constant in 2misc expanders [21/47] target/arm: Use tcg_constant in balance of translate-a64.c [22/47] target/arm: Use tcg_constant for aa32 exceptions [23/47] target/arm: Use tcg_constant for disas_iwmmxt_insn [24/47] target/arm: Use tcg_constant for gen_{msr,mrs} [25/47] target/arm: Use tcg_constant for vector shift expanders [26/47] target/arm: Use tcg_constant for do_coproc_insn [27/47] target/arm: Use tcg_constant for gen_srs [28/47] target/arm: Use tcg_constant for op_s_{rri,rxi}_rot [29/47] target/arm: Use tcg_constant for MOVW, UMAAL, CRC32 [30/47] target/arm: Use tcg_constant for v7m MRS, MSR [31/47] target/arm: Use tcg_constant for TT, SAT, SMMLA [32/47] target/arm: Use tcg_constant in LDM, STM [33/47] target/arm: Use tcg_constant in CLRM, DLS, WLS, LE [34/47] target/arm: Use tcg_constant in trans_CPS_v7m [35/47] target/arm: Use tcg_constant in trans_CSEL [36/47] target/arm: Use tcg_constant for trans_INDEX_* [37/47] target/arm: Use tcg_constant in SINCDEC, INCDEC [38/47] target/arm: Use tcg_constant in FCPY, CPY [39/47] target/arm: Use tcg_constant in {incr, wrap}_last_active [40/47] target/arm: Use tcg_constant in do_clast_scalar [41/47] target/arm: Use tcg_constant in WHILE [42/47] target/arm: Use tcg_constant in LD1, ST1 [43/47] target/arm: Use tcg_constant in SUBR [44/47] target/arm: Use tcg_constant in do_zzi_{sat, ool}, do_fp_imm [45/47] target/arm: Use tcg_constant for predicate descriptors [46/47] target/arm: Use tcg_constant for do_brk{2,3} [47/47] target/arm: Use tcg_constant for vector descriptor

Message ID

20220426163043.100432-24-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
 qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as
 permitted sender) client-ip=209.51.188.17;
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 23/47] target/arm: Use tcg_constant for disas_iwmmxt_insn
Date: Tue, 26 Apr 2022 09:30:19 -0700
Message-Id: <20220426163043.100432-24-richard.henderson@linaro.org>
In-Reply-To: <20220426163043.100432-1-richard.henderson@linaro.org>
References: <20220426163043.100432-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::62e;
 envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: qemu-arm@nongnu.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

target/arm: Use tcg_constant | expand

Comments

Peter Maydell April 28, 2022, 10:23 a.m. UTC | #1

On Tue, 26 Apr 2022 at 17:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/translate.c | 25 ++++++++++---------------
>  1 file changed, 10 insertions(+), 15 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

diff --git a/target/arm/translate.c b/target/arm/translate.c
index 9bd1b46a52..501192ed55 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -1845,24 +1845,21 @@  static int disas_iwmmxt_insn(DisasContext *s, uint32_t insn)
         gen_op_iwmmxt_movq_M0_wRn(wrd);
         switch ((insn >> 6) & 3) {
         case 0:
-            tmp2 = tcg_const_i32(0xff);
-            tmp3 = tcg_const_i32((insn & 7) << 3);
+            tmp2 = tcg_constant_i32(0xff);
+            tmp3 = tcg_constant_i32((insn & 7) << 3);
             break;
         case 1:
-            tmp2 = tcg_const_i32(0xffff);
-            tmp3 = tcg_const_i32((insn & 3) << 4);
+            tmp2 = tcg_constant_i32(0xffff);
+            tmp3 = tcg_constant_i32((insn & 3) << 4);
             break;
         case 2:
-            tmp2 = tcg_const_i32(0xffffffff);
-            tmp3 = tcg_const_i32((insn & 1) << 5);
+            tmp2 = tcg_constant_i32(0xffffffff);
+            tmp3 = tcg_constant_i32((insn & 1) << 5);
             break;
         default:
-            tmp2 = NULL;
-            tmp3 = NULL;
+            g_assert_not_reached();
         }
         gen_helper_iwmmxt_insr(cpu_M0, cpu_M0, tmp, tmp2, tmp3);
-        tcg_temp_free_i32(tmp3);
-        tcg_temp_free_i32(tmp2);
         tcg_temp_free_i32(tmp);
         gen_op_iwmmxt_movq_wRn_M0(wrd);
         gen_op_iwmmxt_set_mup();
@@ -2318,10 +2315,9 @@  static int disas_iwmmxt_insn(DisasContext *s, uint32_t insn)
         rd0 = (insn >> 16) & 0xf;
         rd1 = (insn >> 0) & 0xf;
         gen_op_iwmmxt_movq_M0_wRn(rd0);
-        tmp = tcg_const_i32((insn >> 20) & 3);
         iwmmxt_load_reg(cpu_V1, rd1);
-        gen_helper_iwmmxt_align(cpu_M0, cpu_M0, cpu_V1, tmp);
-        tcg_temp_free_i32(tmp);
+        gen_helper_iwmmxt_align(cpu_M0, cpu_M0, cpu_V1,
+                                tcg_constant_i32((insn >> 20) & 3));
         gen_op_iwmmxt_movq_wRn_M0(wrd);
         gen_op_iwmmxt_set_mup();
         break;
@@ -2375,9 +2371,8 @@  static int disas_iwmmxt_insn(DisasContext *s, uint32_t insn)
         wrd = (insn >> 12) & 0xf;
         rd0 = (insn >> 16) & 0xf;
         gen_op_iwmmxt_movq_M0_wRn(rd0);
-        tmp = tcg_const_i32(((insn >> 16) & 0xf0) | (insn & 0x0f));
+        tmp = tcg_constant_i32(((insn >> 16) & 0xf0) | (insn & 0x0f));
         gen_helper_iwmmxt_shufh(cpu_M0, cpu_env, cpu_M0, tmp);
-        tcg_temp_free_i32(tmp);
         gen_op_iwmmxt_movq_wRn_M0(wrd);
         gen_op_iwmmxt_set_mup();
         gen_op_iwmmxt_set_cup();

[23/47] target/arm: Use tcg_constant for disas_iwmmxt_insn

Commit Message

Comments

Patch