From patchwork Tue Apr 26 16:30:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 566027 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp3757966map; Tue, 26 Apr 2022 09:42:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDKGDBxYRS99qBjsdJIRsDFL0QMVN7nPIddLgEk6dFk4sfHHzkS8jPOg1QygoQBQ7J/ZTP X-Received: by 2002:a25:2e4e:0:b0:648:6652:ca6e with SMTP id b14-20020a252e4e000000b006486652ca6emr10789628ybn.345.1650991349498; Tue, 26 Apr 2022 09:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650991349; cv=none; d=google.com; s=arc-20160816; b=lrwdP1svGYf33m2E2ih1XP+BnBtbRrHUhLwc8gUafaBlTv3MeEm8AMpmXqKg84T23m f7XKEVt0WQYJTtYFl9MQLd9ikDaM0pLntwG35NAqxYHB5upUvMpAnTquElrAVtEa+LB+ rkDxo2trOUclPe7PkWMdI8lyKOpkPMNRlO5skV71RbCoQaw0rMjRc3urKXQwHmU3vGn2 1PpPOlCJapcGVS5ZClpgNYPyAzBUm4eHlVn8xIcaeR62u40OamXnuGAo+LdlTFZpPWn4 qFM3gwHcc8WLRaBXMUOpdaEH7GaFMnEKyDD5B2jXdWTkC8K4SuIYcXsgEjiOskGrDFM5 uhyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=QR3LzJQ6YjEzf58rv5ySxFoYa24sQiIxhi3F4IlHklA=; b=zPG6GUkozBOlZ4XWmaK0ZYJae7h+V70uLxg3rY0Qey2ZtirkZxSZIw0/b8IPd15B2l eMtIiP28oupor2h9D1ni9Evn+cznmY94SxCYHCiZZVjeZORU2S6WihyeBZDzKsNoq0Pa w8RJACb+1s7xoMcigvB5FOBH91gbob1RYuRMkKvpgFLAZUtrzY3ypeQx2goAAIKO+Rt4 XJDBJj79KIlujHyaBGWpG7Hby+xFlaxTv9gzZoHzmz0gPaBF/hLCqnLgFgxPs24AkTFZ CcCgsNcldzTVD76APb/HHB/2ewC9Ikl7V7+dsMtgjcumN/RrLm2jvOF+WeWSxxtun8pK VNww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UCegV80k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a123-20020a818a81000000b002f1c9e07835si14506597ywg.144.2022.04.26.09.42.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Apr 2022 09:42:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UCegV80k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njOGh-0006ks-Vw for patch@linaro.org; Tue, 26 Apr 2022 12:42:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njO5i-0002yL-Fg for qemu-devel@nongnu.org; Tue, 26 Apr 2022 12:31:14 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:42944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njO5g-0003pU-4V for qemu-devel@nongnu.org; Tue, 26 Apr 2022 12:31:05 -0400 Received: by mail-pg1-x52f.google.com with SMTP id bg9so16478558pgb.9 for ; Tue, 26 Apr 2022 09:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QR3LzJQ6YjEzf58rv5ySxFoYa24sQiIxhi3F4IlHklA=; b=UCegV80kHjMJgyMY1v1XvaO0Oyjozb2CuLqCUKctNaKWfD1bJBPsCo73bpEMWIRCWj /C4jfoJV+DfUHXfL/z3/uL80FmrOMPE2diOTwg6FawZHE3MK1Euy8GlaPVkYklDWEvQh Is8/X7jmXjmx788NWByBA0QqaMy8KeA9W7j9SLAKqdVbnVPLmES7nocnlkhgwigCjVZ2 BmbvEnTSdwCbf/02UEXV+ms9KVBAMiMan0ujMbCQ4N9hCpVz+Aj+0beuqoRdm3nebq5y hsWUcqGdTVDhQVokiUtzY5FO6nxMrsjzOIwxMmDl2SE46VP437FdH0caay9Y1UJUI069 sYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QR3LzJQ6YjEzf58rv5ySxFoYa24sQiIxhi3F4IlHklA=; b=zVbCSsVCddBvsyBwgekq7LsTJF2/Z3Yk/OFZ/MAKuM3+lQntGszXt6ogJCOESg14UB aCtNhg78gmNdGhh+bdPXRTszMuH9a8Sdv+nVV+DfliAjOEcRXhhWcu5vPklOvx4znPb0 nStvpY9vREf64T99JWhszbYv+BRFg4PWRHXq2zGvGgwwq0ZzLALQDQr0OjUGFlF8A7Ww FSucKUA89NS8EkZ6iTSLM6ux7SYu6QYkvjBA95dXamgBNPZXuiU9OVy/HtzD1OQXy9Ey Iuxw51guP5GBIi8Csa0bsTzJh89xiNMKcN2KPGoIX8Se6mOdLqABIDR0IrloyzCrqTJT Mqog== X-Gm-Message-State: AOAM5324GY3n8dNaDWZUmW/hU4Vxgdz7ITZ6+RYTiYnFpqUXlGzcZscO /WtQ8q4WuUdnYlltY7Fwo/YvbSFQVr3xFQ== X-Received: by 2002:a62:be14:0:b0:505:a43b:cf6e with SMTP id l20-20020a62be14000000b00505a43bcf6emr25299684pff.33.1650990661702; Tue, 26 Apr 2022 09:31:01 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id y131-20020a626489000000b00505a8f36965sm15655813pfb.184.2022.04.26.09.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 09:31:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 16/47] target/arm: Use tcg_constant in disas_data_proc_2src Date: Tue, 26 Apr 2022 09:30:12 -0700 Message-Id: <20220426163043.100432-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426163043.100432-1-richard.henderson@linaro.org> References: <20220426163043.100432-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Existing temp usage treats t1 as both zero and as a temporary. Rearrange to only require one temporary, so remove t1 and rename t2. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-a64.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ff08306d2b..358f42026c 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5734,15 +5734,13 @@ static void disas_data_proc_2src(DisasContext *s, uint32_t insn) if (sf == 0 || !dc_isar_feature(aa64_mte_insn_reg, s)) { goto do_unallocated; } else { - TCGv_i64 t1 = tcg_const_i64(1); - TCGv_i64 t2 = tcg_temp_new_i64(); + TCGv_i64 t = tcg_temp_new_i64(); - tcg_gen_extract_i64(t2, cpu_reg_sp(s, rn), 56, 4); - tcg_gen_shl_i64(t1, t1, t2); - tcg_gen_or_i64(cpu_reg(s, rd), cpu_reg(s, rm), t1); + tcg_gen_extract_i64(t, cpu_reg_sp(s, rn), 56, 4); + tcg_gen_shl_i64(t, tcg_constant_i64(1), t); + tcg_gen_or_i64(cpu_reg(s, rd), cpu_reg(s, rm), t); - tcg_temp_free_i64(t1); - tcg_temp_free_i64(t2); + tcg_temp_free_i64(t); } break; case 8: /* LSLV */