From patchwork Fri Apr 22 16:52:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 564877 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp686181map; Fri, 22 Apr 2022 10:31:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTPDZJcY4h5ObtHTBqrUK4pwa5DKZrVyVzr9M4Fg2vv4GtdP0qvJrRGb+gGTNHzqCTC7ZI X-Received: by 2002:a25:dc7:0:b0:641:329b:5914 with SMTP id 190-20020a250dc7000000b00641329b5914mr5653385ybn.425.1650648719137; Fri, 22 Apr 2022 10:31:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650648719; cv=none; d=google.com; s=arc-20160816; b=TJ7mvhOGhzJS2LWybev8sWqWIGs0bgggjLeOPzOUFVafp7qkuobKjqWpGhmLfc8dgj ZDqpk8BI0MBeJx7gH6YGRFGI4wXvM/x4bopMV0zMcKT6vbqLj6XSdFDlR4Dcn/fYYJDl tWGVzQ1XkwaIodvAlVSGzNHxYb9cUcnbKE256H0tUydQrXWUiHYLzPtWhS9kEe9WP3+E Mta8mYBegCWxg6KI4A5jZ98PZAbjCAkyXalByMaWqgmTLyaXBoOVPR32amjMCjK+AFlV A2sXhlMBbQznFRqnMFN1aTkHErzT6dYGXl6TS83S/SCUBtZR2hB+gLScMvw0uJMMMCdX nCLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=iObdQHKU6ufFuXLN7memyKU5XMdRsjU+okk71a73SR+M8Fy1Kv21goFh/akv3wJvcQ N/X3t0LIfZKS+ELD15gSx3iyAX1aecS6bWTUbgKQlBsiZ9ttOK6useZtmYOROkmL5pq2 NttGE9evRk0xy+FccNPWzw4eaIq+murBMw+kduwptdeSWlT6sxv3tFzuwnWeyLXNicDu ngVv7755e8UutsRGqPGlzsHS6fyO3CINPAzwjNMPBoGpVtFi77yXigYIAA37nNCIDx/9 BdOrrAlU+u+o/ATy8kOVcoWTprKik0Uf75fz6WRQ+rPAKhNHEfCMQ5O2L2eBxrXHbr8C /eeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sy9rN8wM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f128-20020a811f86000000b002e5bb9dc98fsi5499313ywf.24.2022.04.22.10.31.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Apr 2022 10:31:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sy9rN8wM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhx8Q-0000kk-LQ for patch@linaro.org; Fri, 22 Apr 2022 13:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhwav-0000EV-7F for qemu-devel@nongnu.org; Fri, 22 Apr 2022 12:57:21 -0400 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]:45603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhwas-00082K-Om for qemu-devel@nongnu.org; Fri, 22 Apr 2022 12:57:20 -0400 Received: by mail-il1-x12e.google.com with SMTP id t4so5409313ilo.12 for ; Fri, 22 Apr 2022 09:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=sy9rN8wM7V48nLg45maUYRInF1jbJgujxhGx3r3y0aGr+ReHBgWcJYrUhyhTOYXH0a Oe8pVJZmwoKuyglZYFVvn+jDOAQygFLz9wbeEFs0fpuOPVtm36DGqObHpMTQNPCGzD+Y OvJKAMmPtEAO1vwpKVJrbRO5snc1obtv8JcFO1bDad4o/nvQzcafe4zyHrryvEDB0Jfq w/qmAmV/sK/g3+Q1v2FG33etL3JiAI2AEQ/dB6TzHNrfDHrXm1DZAdu8BBjHmRrIEygr HhvMuqMIgvuVJKV2WRZTNM1TdpV6QDpgyKtgN6n4dp1WS1ZORgahrHLeD3H5ioytOohd OrTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=0CvKiU6DhgABTrwGb5L4TAv2hpAPF4qqSqJVl+a74XB8L/lrCsBviyaqLPCgUuSiz3 UfhArzBIq5qVG93ZBXxq5azRP4somVZ4PA/fuCrSEDYKST/7ses7KLFXAG+JZs6G6qD+ nOhL+kbTo1Y24oRTu1bs0mlN8Nng5BW3XYxKLy89B9qExcr3UGMZ/9W1D2E+Z4J6KEl8 EkDrvsKBKctMfGgTEjjQ6cc/hUWvagH+dY99e8n/ACfYSsmRyTr1dmrYG4ufnH3+bOl9 JF5BdMXcMT5chUebn8j515h0grBBwBg4vtl0MqbpJEmxB8R6BKaUsOaxwPTPx5U/8PD9 4MVw== X-Gm-Message-State: AOAM531sd3CtUHKxaZk/bbS2JBqxrVNxaz/ndZ5MnDNCFZs0jNDsuFEJ zGQrPDkPviBV9ITeO1XpVTL1YsNT0VALZZtW X-Received: by 2002:a05:6e02:1348:b0:2ca:b398:1144 with SMTP id k8-20020a056e02134800b002cab3981144mr2563530ilr.163.1650646636321; Fri, 22 Apr 2022 09:57:16 -0700 (PDT) Received: from stoup.. ([2607:fb90:27d0:b0f2:934d:3e2:9f8c:dd1]) by smtp.gmail.com with ESMTPSA id n23-20020a6b8b17000000b00649a2634725sm816380iod.17.2022.04.22.09.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 09:57:15 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v8 53/68] target/nios2: Hoist set of is_jmp into gen_goto_tb Date: Fri, 22 Apr 2022 09:52:23 -0700 Message-Id: <20220422165238.1971496-54-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220422165238.1971496-1-richard.henderson@linaro.org> References: <20220422165238.1971496-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::12e; envelope-from=richard.henderson@linaro.org; helo=mail-il1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Rather than force all callers to set this, do it within the subroutine. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-50-richard.henderson@linaro.org> --- target/nios2/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 8616813365..a55270cefa 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -192,6 +192,7 @@ static void gen_goto_tb(DisasContext *dc, int n, uint32_t dest) tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(NULL, 0); } + dc->base.is_jmp = DISAS_NORETURN; } static void gen_jumpr(DisasContext *dc, int regno, bool is_call) @@ -235,7 +236,6 @@ static void jmpi(DisasContext *dc, uint32_t code, uint32_t flags) { J_TYPE(instr, code); gen_goto_tb(dc, 0, (dc->pc & 0xF0000000) | (instr.imm26 << 2)); - dc->base.is_jmp = DISAS_NORETURN; } static void call(DisasContext *dc, uint32_t code, uint32_t flags) @@ -278,7 +278,6 @@ static void br(DisasContext *dc, uint32_t code, uint32_t flags) I_TYPE(instr, code); gen_goto_tb(dc, 0, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) @@ -290,7 +289,6 @@ static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) gen_goto_tb(dc, 0, dc->base.pc_next); gen_set_label(l1); gen_goto_tb(dc, 1, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } /* Comparison instructions */