From patchwork Wed Apr 20 18:05:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 563992 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp4412001map; Wed, 20 Apr 2022 11:26:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsFmGDnsolwC2169MeG1QCqCCo7ku7UD0A73ccoFTqflFh1uq2hahdAHnk84El1A5MIm8t X-Received: by 2002:a81:8507:0:b0:2eb:9715:78d3 with SMTP id v7-20020a818507000000b002eb971578d3mr22577417ywf.304.1650479179524; Wed, 20 Apr 2022 11:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650479179; cv=none; d=google.com; s=arc-20160816; b=anw2dnzO5mlclK6xNzXZC/IXF9Z6Wp6oAWFsy3D9MazL1VUh+JTgiobwU1s3aNAOli JFUYcP+hbHq/xoMN8ZIbQnlLE+nQIlfDqcYiXnO/AX36ZscXWBbIP6Gg043GX/F7Ob+l TJHeqWnnqbM4ue/FrCp6pafK8Bhr07yfxVmg2N+tXFkQkJE9PcUrzsVTvhzCGxvjwc5/ k7uyYnrq8jfXfOHz1Bcq8ne2BsgBdLaDozx23OU2qzXN5k9jsj67wXYxRm830hBTLkqC M1f98Eo3YRTN66xu7ycZTDoEeqOPjh4hjZ41WBsYEkClmOoiUDOCkGf4569TMD86pB1o GfMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nV9NUHGE3OwdaVnxN1+80eLd/X0Cf+bcd/I1jEloa/Y=; b=WXc4Ux8kw6tNHtgInQA5jnDfin46Q6B7cpHIVM8QltbySlwiM3SpECy4qtl77guOwQ 7iwy7MoHqBrxfavIEuRsbaWpk/tIzLax9ohu6Do0NoySAKAWlxnZSpmKx4FiL//KDttd sIHsQwuuBqDtXZzk4ljsScA5qsoYlRuvUbASN+sDxgTZc5DV0Re2VHPR1rcD5Y1hhFdP Evc/ScagirEQQetub/0BFjtPkHeN8KTznV2GCyIBGr4pMml1axyc+ZQ2n/tM10b6GGli RYr9fvObQQV+1ohSAzX2KJy9/WgLi8iqApJYkFwg7+/G71wLHplzAs0b/yH1b1dMejTO HGcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r+VbEOcr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x1-20020a5b0281000000b00641c83eaa8dsi632293ybl.132.2022.04.20.11.26.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Apr 2022 11:26:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r+VbEOcr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhF1v-0006CF-2T for patch@linaro.org; Wed, 20 Apr 2022 14:26:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhEiv-0005he-Tz for qemu-devel@nongnu.org; Wed, 20 Apr 2022 14:06:41 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:53045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhEiu-0001FT-Gt for qemu-devel@nongnu.org; Wed, 20 Apr 2022 14:06:41 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 2so2682921pjw.2 for ; Wed, 20 Apr 2022 11:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nV9NUHGE3OwdaVnxN1+80eLd/X0Cf+bcd/I1jEloa/Y=; b=r+VbEOcrHJi7H0lgJHSg9Jc4AOakhitDcSF9LzkeaLqazxQMiYi7fPO+q+HDnQA1cS RjExJJ7iroUlKj3/Dct3KyWYuaXZCkpN3Vz8szBMJVD+YLpB8RT6fqpGGywXl075OF/M fVtlUVAgFSU/mj5lK/XbwvxfHPYR7+7vUr3EPO4rJhWO/DKX8wiK/fkIBSSO/ZH48okO R/rPhuGzx/C75pL9Zf3d0AuzmD0qAizRrI+FmGoexOKL5jZszFTESyZiJotZHcBLCrdN j68Htmh/cJ0bYSkWXi6R55ytLdx/UX8cbFawk6UIkZdesvhfpKj7bkgexik6OopdL7kG r+vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nV9NUHGE3OwdaVnxN1+80eLd/X0Cf+bcd/I1jEloa/Y=; b=QIXMSwcIjq0GEJTPXoLADfwD0nLoFifxXYCvG/Q0Lp8NC7Apd2LypaUDmYBD2AsLhV CJ5IaYFrzxDgrdB1d9iZvgryi3P7ZdcB2AAsTYjiupAXykaamxHRUxG8vIPvpqIBQUtr ZedCFXTpbQqYjXyAjAaJKR+oZMVNtRFuq8TmQnA6jJ+Rz50YSP+mFjuHG9xxRCvR7NAT R4agn/898/HYWkklN+jgcvA+21NN8Lv6UTH/LjKvzAIFr+uMCaV9PSSFPBbghhjxYZpS bZLEpJ9xwbLd9mCeDtDTjfi3olw1V6O84a+A+x+XBlL04NZ1bHMkvGt4RUfSqs+ycODU 9sgg== X-Gm-Message-State: AOAM532Z1qoMtOZH4x3abB1yYbBSt40Z4sq2sgN/Odcq274t+3fkx+ZY 0e+eW+7umDRqhyxEF72AgzpNp+o75EqyEQ== X-Received: by 2002:a17:903:4052:b0:155:fc0b:48fb with SMTP id n18-20020a170903405200b00155fc0b48fbmr21706776pla.27.1650477999202; Wed, 20 Apr 2022 11:06:39 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id i2-20020a17090a058200b001d2fc489b8asm56681pji.25.2022.04.20.11.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 11:06:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 18/39] util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT Date: Wed, 20 Apr 2022 11:05:57 -0700 Message-Id: <20220420180618.1183855-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420180618.1183855-1-richard.henderson@linaro.org> References: <20220420180618.1183855-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now that all uses have been updated, consider a missing test of the result of qemu_log_trylock a bug and Werror. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-Id: <20220417183019.755276-19-richard.henderson@linaro.org> --- include/qemu/log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 2d9455dc85..3a1f3a6020 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -67,7 +67,7 @@ static inline bool qemu_log_separate(void) /* Lock/unlock output. */ -FILE *qemu_log_trylock(void); +FILE *qemu_log_trylock(void) G_GNUC_WARN_UNUSED_RESULT; void qemu_log_unlock(FILE *fd); /* Logging functions: */