From patchwork Sun Apr 17 18:29:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 562882 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp1883764map; Sun, 17 Apr 2022 11:58:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtM4YDvhBNVIqjvb0qCbjlAz2oKmWqm7hW0Krsnp+fSGOtP+Uz/5/TPItVV0nO0X1dC64P X-Received: by 2002:ac8:5bd2:0:b0:2f2:107:bfa2 with SMTP id b18-20020ac85bd2000000b002f20107bfa2mr504755qtb.38.1650221906893; Sun, 17 Apr 2022 11:58:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650221906; cv=none; d=google.com; s=arc-20160816; b=gwy9MKgjMnupxC860f6YEQjBKQRVAi0k5btVasOK0i/kNzK1bnNldYMQfGqls1UPSo xd/ly+sTzn7tP4Dv2gNsGzIIc5ZQQnqNZhotmOxGHTs5KYlos5SNQqvjhE3oEx2u03sM iyFNeo7OPHulQFuWoaPo8UYPE8ZchAeXet3W70NOWeNpmpRCz7txs/azPBeh0+x2vhTz ipbT3dyAWJMVynbL/cEBmxV19xKMhuJ1cUwk7BL+rPDIjyQ0mqYSv1CDqyKsVvtzWPvB qwdOnu+deQdKOTS8olGQluL+vJU2NWTlbuXJMGIBI/PMcX9fDqKI+K9DcJXm7x4tucdx I7yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=B84XsHdMWG4qa6c/oiGTMvbi1xCiD5iL4SqQb6KsdqNI3icUUBFKcYmcBeHbkKCjsQ q3pD8HPqi+UR0dyWcZAAkbiG+Um93iAd6vblbF23otegUws4iZ8z6iT4wuIXFjOhTaSj HVE0Fuvyq6FE1CAw8pHt9a/jugE/6vhEUHOikLxK3Ui3i0LgfJfGUuklOSm20cgr+c7L Dhb+tE6eLQVSAlJqwQ7Nrvs6PYoni89ukIKP4Ox/KGgqibYwrk5n+phSImubVi6/Cbgn tfDsIuMiisrVpAvDqYAF0T9YnkpQRDtXkNITDaXjjCe0zE4NuD1/pU1+CNWTo86kdyR1 CI7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y5IflK46; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gm3-20020a056214268300b004465ecf4a93si231915qvb.260.2022.04.17.11.58.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Apr 2022 11:58:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y5IflK46; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngA6M-00048J-E8 for patch@linaro.org; Sun, 17 Apr 2022 14:58:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng9fH-0000P8-TP for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:31 -0400 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:45888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng9fD-0001jh-T6 for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:25 -0400 Received: by mail-pg1-x531.google.com with SMTP id k29so15048317pgm.12 for ; Sun, 17 Apr 2022 11:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=Y5IflK46uLun63N0EBTAWzspumDw3Qmb5P3qn1olZyhJkTj0RJ+yeH2jnzDfdIXZwj 7sZW9E84fBFc6Tzauvqh8z9gOyXuSjUDiZn0AcLolVs5rwtj3aMaiw5HFVV8P0Z+DJDb dIhhSk6uSvq6HLWP+vAbgm4i/2yV+Sv4xo5h9HqJ0xQE9aztdUwZjXTLoNc+Ij+pzP8f Wvpsl61WKkNGuitj4MWwr2uB2YPHH+kpeOQOZJDabYa1lHLHqEZXtDXTTDDhIE2j5uM5 xNKUtOCNmEyqrsbs/xusZlwBqPTV9JVQJkyqubcI95s97+MLHgM4UKx/IyfH85vQkPHO ku/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=yBr3ODSvTFlDTyVbfG/584qye8TQTIvBA5sNDNcBy7aiINCsi4V//dx+WXCDZUMTRC ESJc4uYCsHF/T1e3hrD6YgdPhEdonRi+erthsZGEwEBqI0qOFJZ9sWFzQ83FBeUQNn4+ iG+36mo1PGHCTNyarjyrcFrUkA5XqpKtBRIlzCg5uk/a6RYwmaesO9QmE3NfRYJuFTyE B5KpRYWfaNA0KB6M70IR2Q2b3Jrip3QLkwaKZkz9t4dHCS+fkjzLZB8VJ1vI3KNb7zI+ D350SlcG1MsVf+vXiFGXK0iRfejjfxTOwivFPYVHhCRjFXlyAgT9i/vTbfyf2Tn7YY/w j9vA== X-Gm-Message-State: AOAM532uyo9IXv5EtArxMePnNEKT+zA3EcyxbtTwg9+cAOPtVhqXsCzL azapm8GwU/cEWpSSQi3rtWIPIpvq+ChUqg== X-Received: by 2002:a05:6a00:814:b0:505:9fad:4252 with SMTP id m20-20020a056a00081400b005059fad4252mr8582399pfk.54.1650220222178; Sun, 17 Apr 2022 11:30:22 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id on10-20020a17090b1d0a00b001d08a7d569csm8154011pjb.56.2022.04.17.11.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 11:30:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init Date: Sun, 17 Apr 2022 11:29:42 -0700 Message-Id: <20220417183019.755276-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220417183019.755276-1-richard.henderson@linaro.org> References: <20220417183019.755276-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This code appears to be trying to make sure there is a logfile. But that's already true -- the logfile will either be set by -D, or will be stderr. In either case, not appropriate here. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/hexagon/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index b6f541ecb2..98f1452cad 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -874,12 +874,6 @@ void hexagon_translate_init(void) opcode_init(); - if (HEX_DEBUG) { - if (!qemu_logfile) { - qemu_set_log(qemu_loglevel); - } - } - for (i = 0; i < TOTAL_PER_THREAD_REGS; i++) { hex_gpr[i] = tcg_global_mem_new(cpu_env, offsetof(CPUHexagonState, gpr[i]),