From patchwork Sun Apr 17 18:30:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 562904 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp1890942map; Sun, 17 Apr 2022 12:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrjm9fY88IpMoHr12qwslnqBS+wxpEdXUjGmlQh34654/p7cyVPUT0KXT51SElDVkuizxm X-Received: by 2002:a05:622a:6185:b0:2f1:ebdd:58c with SMTP id hh5-20020a05622a618500b002f1ebdd058cmr5245686qtb.400.1650222868443; Sun, 17 Apr 2022 12:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650222868; cv=none; d=google.com; s=arc-20160816; b=mnFdJJDFphgvFtQsvdR2PS8DgqnjjXCwAfehVIZeOnAS5Ds88veCs9y9RChE0faJYS KEcz+x9lhhch6bS7nxTg4wRMXVMBchdkwcIFgbv6aDxsVEqf2IqKsBsFXNXrf2ZNqhJM mqzKMrfnu3T/GESwzqe58g46oSgxy97iuyPHXsbLn1U57ZpYTuiywYi/jS9K4rNkA0rx A/5wKUEgM3grBK3TEy741LlTOgZXpD4hPAzJIBOFSxdBFismGCwz+T2LHPUO0rXupayt mxqTLXuMKgbMwczRjhGUXvKl9bY97vSL0XIxPBmRJIFJ1tImKmqdsdYs9Xs1tv0eBxmc 6pfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=InZstGK3OSOKG4KiyoWd4So9y/2uE4PZQH7gwFG8oNw=; b=Kv+IjgZPf7RMBVPleoHKwFJx95CSUbJ6Sv2futYs11VmVTFxyCzgphZy05cpPpMEFy hp4UYyxmGqx2y4fmLGJP4Bq96CGLZxH51bf2JyoJdgxIK9l0XyvgdDSqg9y9wLx2gAZz DYpxpHgHylUThFw+58x34C+6lTN+EQDMeD/gkdEcmKP2FlAMq2xDlu1RDzlyObkXWBZV R10RF9QUA5LkLWIVvPrt/UCD/CM4l58+XkId0QkxwaKpHO8P+DYafA5d+OXRPO0t3lAk l0fDwnooX+iMGKDEIj8Bim0PkCX+Sqoj9QqIPAj9Z6qsIvmxR+aO+bwz7c05gRUaoUuq dHdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=spWiBeXB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z6-20020ac81006000000b002f1ea872066si2190669qti.488.2022.04.17.12.14.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Apr 2022 12:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=spWiBeXB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngALs-0003rK-1w for patch@linaro.org; Sun, 17 Apr 2022 15:14:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng9fW-0000Tz-WB for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:46 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:51010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng9fU-0001nq-Aq for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:42 -0400 Received: by mail-pj1-x102a.google.com with SMTP id o5so11413549pjr.0 for ; Sun, 17 Apr 2022 11:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=InZstGK3OSOKG4KiyoWd4So9y/2uE4PZQH7gwFG8oNw=; b=spWiBeXBTEyENU3yk+r8I8lsjTtsOHb8HsU87ccc6OdoZ0+4KtMmaJjHZRfUZRX4Bv 0Z06MBOcRp9KXprVa+pTkxJKzQtzsvTOPmdtyJQRJWPE3hahVIGtY5QIT6ADuRg5jYbC k13g2QV5K1nHhCdO7BIRHSB0OGvz6uMW/ORvZVPfc/R2toXWgxbJZxZ2YmyV5ofqbMyr rh5FTISt2oryBDY0G/EZAX0IRIRSEVcnr5Bnq/7KD9poG7Wj+0k2PQ48ZvmuV5lO35Bc ewhHKEUCmnFd+oiilVx44bUSBZ6GOQKt5UygmcRsxF5X2Mf9AivNTQzsFNWeL3jNCFGb Mazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=InZstGK3OSOKG4KiyoWd4So9y/2uE4PZQH7gwFG8oNw=; b=IzpyNsQSa6JyC+KP09V0O063XBR7U7AgslQ+dIS9j2xZEDkbxH3Pvvwy2FPlt6fBGI EaijmeQqFg1fLaDzkKaTRI8Mveq0gtw4a7ze1TAuZ9DVRc7tbZeHUsD5SNwFGo2HZT/6 CEsBG4Fn7Yg11kckfKzwfsrwb+xcyzsQuVloisMWNGeTcjzb/6aN3CHn/tL43JDwI5j2 2TN3YX1KAjHTBHD034chmp3WAvM8wa8RVua65rYHhtqr/OQLNTbqfsVH8Ot6y7Ix+UOF gkeXsVTXBlQrwe3EAyfjz05BJHBcgWsxHjVNnztENi9FgZlR1+XNsTdMSL+voi5+qX4y CoyQ== X-Gm-Message-State: AOAM530zTYqAk/avPO7ONmHfSQrpwMskLgvqxCwg52eX8ZSCR/+wWI4Y t928so0uarH5rBaPpo5CNl2T6FS/W7fQKw== X-Received: by 2002:a17:90a:7147:b0:1bd:24ac:13bd with SMTP id g7-20020a17090a714700b001bd24ac13bdmr14728488pjs.70.1650220237959; Sun, 17 Apr 2022 11:30:37 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id on10-20020a17090b1d0a00b001d08a7d569csm8154011pjb.56.2022.04.17.11.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 11:30:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 20/39] util/log: Drop call to setvbuf Date: Sun, 17 Apr 2022 11:30:00 -0700 Message-Id: <20220417183019.755276-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220417183019.755276-1-richard.henderson@linaro.org> References: <20220417183019.755276-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now that the log buffer is flushed after every qemu_log_unlock, which includes every call to qemu_log, we do not need to force line buffering (or unbuffering for windows). Block buffer the entire loggable unit. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- util/log.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/util/log.c b/util/log.c index cab0642a7f..caa38e707b 100644 --- a/util/log.c +++ b/util/log.c @@ -136,12 +136,6 @@ bool qemu_set_log(int log_flags, Error **errp) logfile->fd = stderr; } -#if defined(_WIN32) - /* Win32 doesn't support line-buffering, so use unbuffered output. */ - setvbuf(logfile->fd, NULL, _IONBF, 0); -#else - setvbuf(logfile->fd, NULL, _IOLBF, 0); -#endif log_append = 1; qatomic_rcu_set(&qemu_logfile, logfile); }